Re: [Qemu-devel] [PATCH 05/11] hw/display/cirrus: Convert printf() calls to trace events

From: Gerd Hoffmann <kraxel@redhat.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: Stefan Hajnoczi <stefanha@redhat.com>,
	qemu-devel@nongnu.org, qemu-trivial@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 05/11] hw/display/cirrus: Convert printf() calls to trace events
Date: Fri, 22 Jun 2018 08:22:25 +0200	[thread overview]
Message-ID: <20180622062225.ay4bubgshxjj3uey@sirius.home.kraxel.org> (raw)
In-Reply-To: <20180621171257.14897-6-f4bug@amsat.org>

On Thu, Jun 21, 2018 at 02:12:51PM -0300, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  hw/display/cirrus_vga.c | 25 ++++++-------------------
>  hw/display/trace-events |  2 ++
>  2 files changed, 8 insertions(+), 19 deletions(-)
> 
> diff --git a/hw/display/cirrus_vga.c b/hw/display/cirrus_vga.c
> index 138ae961b9..a826bef6ec 100644
> --- a/hw/display/cirrus_vga.c
> +++ b/hw/display/cirrus_vga.c
> @@ -2608,11 +2608,8 @@ static uint64_t cirrus_vga_ioport_read(void *opaque, hwaddr addr,
>  	    break;
>  	case 0x3c5:
>  	    val = cirrus_vga_read_sr(c);
> +        trace_vga_cirrus_read_reg("SR", s->sr_index, val);
>              break;
> -#ifdef DEBUG_VGA_REG
> -	    printf("vga: read SR%x = 0x%02x\n", s->sr_index, val);
> -#endif

Indention looks weird.

otherwise the patch looks fine.

cheers,
  Gerd