Re: [PATCH 2/3] migration/memory: Evaluate LMB assoc changes

From: kbuild test robot <lkp@intel.com>
To: Michael Bringmann <mwb@linux.vnet.ibm.com>
Cc: kbuild-all@01.org, linuxppc-dev@lists.ozlabs.org,
	Nathan Fontenot <nfont@linux.vnet.ibm.com>,
	Michael Bringmann <mwb@linux.vnet.ibm.com>,
	Thomas Falcon <tlfalcon@linux.vnet.ibm.com>,
	Tyrel Datwyler <tyreld@linux.vnet.ibm.com>,
	John Allen <jallen@linux.vnet.ibm.com>
Subject: Re: [PATCH 2/3] migration/memory: Evaluate LMB assoc changes
Date: Fri, 22 Jun 2018 13:41:11 +0800	[thread overview]
Message-ID: <201806221340.zig0oLSu%fengguang.wu@intel.com> (raw)
In-Reply-To: <8e886b24-1226-756e-369a-ceca2e30c620@linux.vnet.ibm.com>

[-- Attachment #1: Type: text/plain, Size: 2898 bytes --]

Hi Michael,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on powerpc/next]
[also build test ERROR on v4.18-rc1 next-20180621]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Michael-Bringmann/powerpc-migration-Affinity-fix-for-memory/20180621-090151
base:   https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
config: powerpc-allmodconfig (attached as .config)
compiler: powerpc64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.2.0 make.cross ARCH=powerpc 

All errors (new ones prefixed by >>):

   arch/powerpc/platforms/pseries/hotplug-memory.c: In function 'pseries_update_drconf_memory':
>> arch/powerpc/platforms/pseries/hotplug-memory.c:1032:4: error: implicit declaration of function 'dlpar_queue_action'; did you mean 'waitqueue_active'? [-Werror=implicit-function-declaration]
       dlpar_queue_action(
       ^~~~~~~~~~~~~~~~~~
       waitqueue_active
   cc1: some warnings being treated as errors

vim +1032 arch/powerpc/platforms/pseries/hotplug-memory.c

   999	
  1000	static int pseries_update_drconf_memory(struct drmem_lmb_info *new_dinfo)
  1001	{
  1002		struct drmem_lmb *old_lmb, *new_lmb;
  1003		unsigned long memblock_size;
  1004		int rc = 0;
  1005	
  1006		if (rtas_hp_event)
  1007			return 0;
  1008	
  1009		memblock_size = pseries_memory_block_size();
  1010		if (!memblock_size)
  1011			return -EINVAL;
  1012	
  1013		/* Arrays should have the same size and DRC indexes */
  1014		for_each_pair_dinfo_lmb(drmem_info, old_lmb, new_dinfo, new_lmb) {
  1015	
  1016			if (new_lmb->drc_index != old_lmb->drc_index)
  1017				continue;
  1018	
  1019			if ((old_lmb->flags & DRCONF_MEM_ASSIGNED) &&
  1020			    (!(new_lmb->flags & DRCONF_MEM_ASSIGNED))) {
  1021				rc = pseries_remove_memblock(
  1022					old_lmb->base_addr, memblock_size);
  1023				break;
  1024			} else if ((!(old_lmb->flags & DRCONF_MEM_ASSIGNED)) &&
  1025				   (new_lmb->flags & DRCONF_MEM_ASSIGNED)) {
  1026				rc = memblock_add(old_lmb->base_addr,
  1027						memblock_size);
  1028				rc = (rc < 0) ? -EINVAL : 0;
  1029				break;
  1030			} else if ((old_lmb->aa_index != new_lmb->aa_index) &&
  1031				   (new_lmb->flags & DRCONF_MEM_ASSIGNED)) {
> 1032				dlpar_queue_action(
  1033						PSERIES_HP_ELOG_RESOURCE_MEM,
  1034						PSERIES_HP_ELOG_ACTION_READD,
  1035						new_lmb->drc_index);
  1036			}
  1037		}
  1038		return rc;
  1039	}
  1040	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 56130 bytes --]