All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Whitmore <johnfwhitmore@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
	John Whitmore <johnfwhitmore@gmail.com>
Subject: [PATCH v3 3/8] staging: rtl8192u: User memset to initialize memory, instead of loop.
Date: Sun, 24 Jun 2018 16:34:49 +0100	[thread overview]
Message-ID: <20180624153454.27356-4-johnfwhitmore@gmail.com> (raw)
In-Reply-To: <20180624153454.27356-1-johnfwhitmore@gmail.com>

Replaced memory initialising loop with memset, as suggested by Andy Shevchenko

Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
---
 drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
index 4bfadb49c363..ccb7bdf5ad5d 100644
--- a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
+++ b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
@@ -742,8 +742,6 @@ void HTConstructRT2RTAggElement(struct ieee80211_device *ieee, u8 *posRT2RTAgg,
  */
 static u8 HT_PickMCSRate(struct ieee80211_device *ieee, u8 *pOperateMCS)
 {
-	u8					i;
-
 	if (!pOperateMCS) {
 		IEEE80211_DEBUG(IEEE80211_DL_ERR, "pOperateMCS can't be null in HT_PickMCSRate()\n");
 		return false;
@@ -756,8 +754,7 @@ static u8 HT_PickMCSRate(struct ieee80211_device *ieee, u8 *pOperateMCS)
 		//legacy rate routine handled at selectedrate
 
 		//no MCS rate
-		for (i = 0; i <= 15; i++)
-			pOperateMCS[i] = 0;
+		memset(pOperateMCS, 0, 16);
 		break;
 
 	case IEEE_N_24G:	//assume CCK rate ok
-- 
2.17.1


  parent reply	other threads:[~2018-06-24 16:10 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-24 15:34 staging: rtl8192u: v3 Coding style changes. Plus one change to use memset() John Whitmore
2018-06-24 15:34 ` [PATCH v3 1/8] staging: rtl8192u: change block comments to prefered style - Coding Style John Whitmore
2018-06-24 15:34 ` [PATCH v3 2/8] staging: rtl8192u: Correct indentation of switch statement " John Whitmore
2018-06-24 15:34 ` John Whitmore [this message]
2018-06-25  9:06   ` [PATCH v3 3/8] staging: rtl8192u: User memset to initialize memory, instead of loop Andy Shevchenko
2018-06-25 12:36     ` John Whitmore
2018-06-25 13:05       ` Justin Skists
2018-06-25 19:50         ` John Whitmore
2018-06-26  3:56           ` Greg Kroah-Hartman
2018-06-27 15:48             ` John Whitmore
2018-06-24 15:34 ` [PATCH v3 4/8] staging: rtl8192u: Truncate block comments to 80 character length - Style John Whitmore
2018-06-24 15:34 ` [PATCH v3 5/8] staging: rtl8192u: Use %s and __func__ instead of hardcoded string " John Whitmore
2018-06-26  3:56   ` Greg KH
2018-06-27 20:22     ` John Whitmore
2018-06-28  7:38       ` Dan Carpenter
2018-06-28 12:32         ` John Whitmore
2018-06-28 12:48           ` Greg KH
2018-06-24 15:34 ` [PATCH v3 6/8] staging: rtl8192u: Remove braces from single statement blocks " John Whitmore
2018-06-24 15:34 ` [PATCH v3 7/8] staging: rtl8192u: Correct if statement - Coding Style John Whitmore
2018-06-24 15:59   ` Joe Perches
2018-06-25 11:46     ` John Whitmore
2018-06-24 15:34 ` [PATCH v3 8/8] staging: rtl8192u: Correction of spelling mistake in comment John Whitmore
2018-06-24 15:40 staging: rtl8192u: V3 Coding style changes. Plus one change to use memset() John Whitmore
2018-06-24 15:40 ` [PATCH v3 3/8] staging: rtl8192u: User memset to initialize memory, instead of loop John Whitmore
2018-06-24 15:49   ` John Whitmore

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180624153454.27356-4-johnfwhitmore@gmail.com \
    --to=johnfwhitmore@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.