From: Fabrice Fontaine <fontaine.fabrice@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] collectd: use --disable-werror
Date: Sun, 24 Jun 2018 17:44:52 +0200 [thread overview]
Message-ID: <20180624154452.31187-1-fontaine.fabrice@gmail.com> (raw)
Since version 5.6.0, --disable-werror is available:
https://github.com/collectd/collectd/pull/1222
So use this option, instead of adding a hook to remove it from
Makefile.in
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/collectd/collectd.mk | 9 +--------
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/package/collectd/collectd.mk b/package/collectd/collectd.mk
index ef45f342ae..589324e612 100644
--- a/package/collectd/collectd.mk
+++ b/package/collectd/collectd.mk
@@ -42,6 +42,7 @@ COLLECTD_CONF_OPTS += \
--with-nan-emulation \
--with-fp-layout=$(COLLECTD_FP_LAYOUT) \
--with-perl-bindings=no \
+ --disable-werror \
$(foreach p, $(COLLECTD_PLUGINS_DISABLE), --disable-$(p)) \
$(if $(BR2_PACKAGE_COLLECTD_AGGREGATION),--enable-aggregation,--disable-aggregation) \
$(if $(BR2_PACKAGE_COLLECTD_APACHE),--enable-apache,--disable-apache) \
@@ -194,14 +195,6 @@ else
COLLECTD_CONF_OPTS += --with-libgcrypt=no
endif
-# released software should not break on minor warnings
-define COLLECTD_DROP_WERROR
- $(SED) 's/-Werror//' \
- $(@D)/src/Makefile.in $(@D)/src/libcollectdclient/Makefile.in
-endef
-
-COLLECTD_POST_PATCH_HOOKS += COLLECTD_DROP_WERROR
-
define COLLECTD_INSTALL_TARGET_CMDS
$(TARGET_MAKE_ENV) $(MAKE) DESTDIR=$(TARGET_DIR) -C $(@D) install
rm -f $(TARGET_DIR)/usr/bin/collectd-nagios
--
2.14.1
next reply other threads:[~2018-06-24 15:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-24 15:44 Fabrice Fontaine [this message]
2018-06-24 19:10 ` [Buildroot] [PATCH 1/1] collectd: use --disable-werror Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180624154452.31187-1-fontaine.fabrice@gmail.com \
--to=fontaine.fabrice@gmail.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.