From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5A65C43144 for ; Mon, 25 Jun 2018 07:50:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9F4872555E for ; Mon, 25 Jun 2018 07:50:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9F4872555E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753012AbeFYHuY (ORCPT ); Mon, 25 Jun 2018 03:50:24 -0400 Received: from mx2.suse.de ([195.135.220.15]:50869 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752530AbeFYHuX (ORCPT ); Mon, 25 Jun 2018 03:50:23 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (charybdis-ext-too.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 47DD4AE86; Mon, 25 Jun 2018 07:50:21 +0000 (UTC) Date: Mon, 25 Jun 2018 09:50:20 +0200 From: Petr Mladek To: Andrew Morton Cc: Steven Rostedt , Thierry Escande , David Miller , Rasmus Villemoes , "Tobin C . Harding" , linux-kernel@vger.kernel.org, Andy Shevchenko , Linus Torvalds Subject: Re: [PATCH RESEND] lib/test_printf.c: call wait_for_random_bytes() before plain %p tests Message-ID: <20180625075020.xcb6jqup3dhq2agf@pathway.suse.cz> References: <20180604113708.11554-1-thierry.escande@linaro.org> <20180607122434.i4x7b5ij4p6dpx7w@pathway.suse.cz> <20180622205346.owyjk33wplzh7nhs@home.goodmis.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170421 (1.8.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri 2018-06-22 23:50:20, Thierry Escande wrote: > On 22/06/2018 22:53, Steven Rostedt wrote: > > On Thu, Jun 07, 2018 at 02:24:34PM +0200, Petr Mladek wrote: > > > On Mon 2018-06-04 13:37:08, Thierry Escande wrote: > > > > If the test_printf module is loaded before the crng is initialized, the > > > > plain 'p' tests will fail because the printed address will not be hashed > > > > and the buffer will contain '(ptrval)' instead. > > > > This patch adds a call to wait_for_random_bytes() before plain 'p' tests > > > > to make sure the crng is initialized. > > > > > > Hmm, my system did not boot with this patch and > > > CONFIG_TEST_PRINTF=y > > > > And neither does my test box. It killed my tests I was running, as one of the > > configs I test has this set. > > > > It appears that Andrew pulled it in and sent it to Linus, as it is in > > 4.18-rc1, and I need to now revert this patch to make my tests work. > > This patch has been superseded with a v2 and a v3 pushed into Petr > printk.git tree (https://git.kernel.org/pub/scm/linux/kernel/git/pmladek/printk.git/commit/?h=for-4.19&id=ce041c43f22298485122bab15c14d062383fbc67). > Sorry for the mess... Andrew, should I send the revert and the better fix to Linus or would you like to do so? Best Regards, Petr