All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 1/4] lib: fdtdec: Add new variable ram_start to global data
Date: Mon, 25 Jun 2018 08:56:07 -0400	[thread overview]
Message-ID: <20180625125607.GJ4609@bill-the-cat.ec.rr.com> (raw)
In-Reply-To: <b248252e-455f-f9a2-4ce5-93a1a89cba90@xilinx.com>

On Mon, Jun 25, 2018 at 08:15:34AM +0200, Michal Simek wrote:
> Hi,
> 
> On 22.6.2018 21:28, Simon Glass wrote:
> > Hi,
> > 
> > On 22 June 2018 at 01:41, Michal Simek <michal.simek@xilinx.com> wrote:
> >> Hi Simon,
> >>
> >> On 18.6.2018 08:18, Siva Durga Prasad Paladugu wrote:
> >>> Added new variable ram_start to global data structure for holding
> >>> the start address of first bank of RAM, and then use this ram_start
> >>> for calculating ram_top properly. This patch fixes the erroneous
> >>> calculation of ram_top incase of non zero ram start address.
> >>> This patch also renames fdtdec_setup_memory_size() to
> >>> fdtdec_setup_mem_size_start() as this routine now takes care
> >>> of memory size and start.
> >>>
> >>> Signed-off-by: Siva Durga Prasad Paladugu <siva.durga.paladugu@xilinx.com>
> >>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> >>> ---
> >>> Changes from v2:
> >>> - Used new varibale ram_start
> >>> - Rename fdtdec_setup_memory_size
> >>>
> >>> Changes from v1:
> >>> - None
> >>> ---
> >>>  arch/arm/mach-mvebu/arm64-common.c                       |  2 +-
> >>>  board/emulation/qemu-arm/qemu-arm.c                      |  2 +-
> >>>  board/renesas/alt/alt.c                                  |  2 +-
> >>>  board/renesas/blanche/blanche.c                          |  2 +-
> >>>  board/renesas/draak/draak.c                              |  2 +-
> >>>  board/renesas/eagle/eagle.c                              |  2 +-
> >>>  board/renesas/gose/gose.c                                |  2 +-
> >>>  board/renesas/koelsch/koelsch.c                          |  2 +-
> >>>  board/renesas/lager/lager.c                              |  2 +-
> >>>  board/renesas/porter/porter.c                            |  2 +-
> >>>  board/renesas/salvator-x/salvator-x.c                    |  2 +-
> >>>  board/renesas/silk/silk.c                                |  2 +-
> >>>  board/renesas/stout/stout.c                              |  2 +-
> >>>  board/renesas/ulcb/ulcb.c                                |  2 +-
> >>>  board/st/stm32f429-discovery/stm32f429-discovery.c       |  2 +-
> >>>  board/st/stm32f429-evaluation/stm32f429-evaluation.c     |  2 +-
> >>>  board/st/stm32f469-discovery/stm32f469-discovery.c       |  2 +-
> >>>  board/st/stm32h743-disco/stm32h743-disco.c               |  2 +-
> >>>  board/st/stm32h743-eval/stm32h743-eval.c                 |  2 +-
> >>>  board/xilinx/zynq/board.c                                |  2 +-
> >>>  board/xilinx/zynqmp/zynqmp.c                             |  2 +-
> >>>  board/xilinx/zynqmp_r5/board.c                           |  2 +-
> >>>  common/board_f.c                                         |  4 ++--
> >>>  include/asm-generic/global_data.h                        |  1 +
> >>>  include/fdtdec.h                                         | 16 +++++++++-------
> >>>  lib/fdtdec.c                                             |  3 ++-
> >>>  tools/patman/func_test.py                                |  2 +-
> >>>  tools/patman/test/0000-cover-letter.patch                |  2 +-
> >>>  ...orrect-cast-for-sandbox-in-fdtdec_setup_memory_.patch |  4 ++--
> >>>  tools/patman/test/test01.txt                             |  2 +-
> >>>  30 files changed, 41 insertions(+), 37 deletions(-)
> > 
> > [...]
> > 
> >> sjg: Do you see any issue with this patch?
> > 
> > I think it is OK. Would like to get more people to look at it though.
> > 
> >>
> >> I can't see the reason for fixing tools/patman but I will wait for you.
> > 
> > Changing patman tests is OK with me. Keeps thing consistent.
> 
> thanks Simon.
> 
> Tom: Do you see any issue with this change?

Yes, thanks.  You can take it via your tree once Marek has had a chance
to test things.

Reviewed-by: Tom Rini <trini@konsulko.com>

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180625/9e8b77d7/attachment.sig>

  reply	other threads:[~2018-06-25 12:56 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-18  6:18 [U-Boot] [PATCH v3 1/4] lib: fdtdec: Add new variable ram_start to global data Siva Durga Prasad Paladugu
2018-06-22  7:41 ` Michal Simek
2018-06-22 19:28   ` Simon Glass
2018-06-25  6:15     ` Michal Simek
2018-06-25 12:56       ` Tom Rini [this message]
2018-07-12  7:20         ` Marek Vasut
2018-07-12 11:28           ` Michal Simek
2018-07-13  6:37 ` Michal Simek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180625125607.GJ4609@bill-the-cat.ec.rr.com \
    --to=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.