Re: [PATCH 27/32] imx-gpu-viv: Add i.MX 8 support

[Gary Bisson <gary.bisson@boundarydevices.com>]

Hi Otavio, Tom,

On Mon, Jun 25, 2018 at 04:30:27PM -0300, Otavio Salvador wrote:
> From: Tom Hochstein <tom.hochstein@nxp.com>
> 
> Signed-off-by: Tom Hochstein <tom.hochstein@nxp.com>
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> ---
> 
>  .../imx-gpu-viv/imx-gpu-viv-6.inc             | 37 ++++++++++++++++---
>  .../imx-gpu-viv_6.2.4.p1.2-aarch64.bb         |  6 +++
>  2 files changed, 37 insertions(+), 6 deletions(-)
>  create mode 100644 recipes-graphics/imx-gpu-viv/imx-gpu-viv_6.2.4.p1.2-aarch64.bb
> 
> diff --git a/recipes-graphics/imx-gpu-viv/imx-gpu-viv-6.inc b/recipes-graphics/imx-gpu-viv/imx-gpu-viv-6.inc
> index 6cc8cbb1..d5023bdf 100644
> --- a/recipes-graphics/imx-gpu-viv/imx-gpu-viv-6.inc
> +++ b/recipes-graphics/imx-gpu-viv/imx-gpu-viv-6.inc
> @@ -12,11 +12,11 @@ DEPENDS += " \
>         bb.utils.contains('DISTRO_FEATURES',     'x11', 'virtual/libx11 libxdamage libxext libxfixes', \
>                                                         '', d), d)} \
>  "
> -DEPENDS += "libdrm"
>  DEPENDS += " \
>      ${@bb.utils.contains('DISTRO_FEATURES',     'x11', 'libxcb libxshmfence libxxf86vm', \
>                                                         '', d)} \
>  "
> +DEPENDS_append_mx8 = " libdrm wayland"
>  
>  # imx-gpu-viv does not provide everything it needs to for virtual/libgl
>  # on x11 backend or on Wayland backend with XWayland support.
> @@ -29,6 +29,8 @@ EXTRA_PROVIDES_append_imxgpu3d = " \
>      virtual/libgles1 \
>      virtual/libgles2 \
>  "
> +EXTRA_PROVIDES_append_mx8 = " \
> +    virtual/libopenvx \

Isn't OpenVx only available on i.MX8QM? Same I think it'd be better not
to expose openvx for imx8mq since it's not supported.
https://www.nxp.com/products/processors-and-microcontrollers/applications-processors/i.mx-applications-processors/i.mx-8-processors:IMX8-SERIES

Also, it seems the i.MX8M Mini only supports OpenGL ES 2.0, not 3.1 and
that Vulkan isn't supported either.

I know it complexifies the recipe but it still should matches what the
HW is capable of, otherwise users will be lost.

To be honest I'd leave i.MX8M Mini out of the picture for now since only
the i.MX8MQ is publicly available.

Regards,
Gary