From mboxrd@z Thu Jan 1 00:00:00 1970 From: Qi Zhang Subject: [PATCH v5 16/24] net/failsafe: enable port detach on secondary process Date: Wed, 27 Jun 2018 15:17:32 +0800 Message-ID: <20180627071740.19870-17-qi.z.zhang@intel.com> References: <20180607123849.14439-1-qi.z.zhang@intel.com> <20180627071740.19870-1-qi.z.zhang@intel.com> Cc: konstantin.ananyev@intel.com, dev@dpdk.org, bruce.richardson@intel.com, ferruh.yigit@intel.com, benjamin.h.shelton@intel.com, narender.vangati@intel.com, Qi Zhang To: thomas@monjalon.net, anatoly.burakov@intel.com Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 79B4D1BDE6 for ; Wed, 27 Jun 2018 09:17:38 +0200 (CEST) In-Reply-To: <20180627071740.19870-1-qi.z.zhang@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Previously, detach port on secondary process will mess primary process and cause same device can't be attached again, by take advantage of rte_eth_release_port_private, we can support this with minor change. Signed-off-by: Qi Zhang --- drivers/net/failsafe/failsafe.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/drivers/net/failsafe/failsafe.c b/drivers/net/failsafe/failsafe.c index eafbb75df..c5e8651f6 100644 --- a/drivers/net/failsafe/failsafe.c +++ b/drivers/net/failsafe/failsafe.c @@ -328,6 +328,7 @@ rte_pmd_failsafe_probe(struct rte_vdev_device *vdev) } /* TODO: request info from primary to set up Rx and Tx */ eth_dev->dev_ops = &failsafe_ops; + eth_dev->device = &vdev->device; rte_eth_dev_probing_finish(eth_dev); return 0; } @@ -338,10 +339,25 @@ rte_pmd_failsafe_probe(struct rte_vdev_device *vdev) static int rte_pmd_failsafe_remove(struct rte_vdev_device *vdev) { + struct rte_eth_dev *eth_dev; const char *name; name = rte_vdev_device_name(vdev); INFO("Uninitializing " FAILSAFE_DRIVER_NAME " for %s", name); + + eth_dev = rte_eth_dev_allocated(name); + if (!eth_dev) + return -ENODEV; + if (rte_eal_process_type() != RTE_PROC_PRIMARY) { + /* detach device on local pprocess only */ + if (strlen(rte_vdev_device_args(vdev)) == 0) + return rte_eth_dev_release_port_private(eth_dev); + /** + * else this is a private device for current process + * so continue with normal detach scenario. + */ + } + return fs_rte_eth_free(name); } -- 2.13.6