Re: [PATCH 2/2] x86/cpuid: Alter the policy logic for leaf 0xb to be multi-invocation

From: Wei Liu <wei.liu2@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>,
	Xen-devel <xen-devel@lists.xen.org>,
	Wei Liu <wei.liu2@citrix.com>, Jan Beulich <JBeulich@suse.com>,
	Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: [PATCH 2/2] x86/cpuid: Alter the policy logic for leaf 0xb to be multi-invocation
Date: Wed, 27 Jun 2018 17:00:03 +0100	[thread overview]
Message-ID: <20180627160003.kuvh5fgwnsnaqy3s@citrix.com> (raw)
In-Reply-To: <5936b8d9-033f-9568-db23-5f8b45b8d710@citrix.com>

On Wed, Jun 27, 2018 at 04:58:08PM +0100, Andrew Cooper wrote:
> On 27/06/18 15:58, Jan Beulich wrote:
> >>>> On 27.06.18 at 15:55, <andrew.cooper3@citrix.com> wrote:
> >> @@ -316,6 +319,33 @@ static void __init calculate_raw_policy(void)
> >>              cpuid_count_leaf(7, i, &p->feat.raw[i]);
> >>      }
> >>  
> >> +    if ( p->basic.max_leaf >= 0xb )
> >> +    {
> >> +        union {
> >> +            struct cpuid_leaf l;
> >> +            struct cpuid_topo_leaf t;
> >> +        } u;
> >> +
> >> +        for ( i = 0; i < ARRAY_SIZE(p->topo.raw); ++i )
> >> +        {
> >> +            cpuid_count_leaf(0xb, i, &u.l);
> >> +
> >> +            if ( u.t.type == 0 )
> >> +                break;
> >> +
> >> +            p->topo.subleaf[i] = u.t;
> >> +        }
> >> +
> >> +        /*
> >> +         * The choice of CPUID_GUEST_NR_TOPO is per the manual.  It may need
> >> +         * to grow for future harware.
> > Missing d.
> 
> Where?  I'm afraid that after repeated re-reads, I can't spot any issue.
> 

har d ware. ;p

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel