From: Daniel Mack <daniel@zonque.org>
To: jacek.anaszewski@gmail.com, robh+dt@kernel.org
Cc: linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
Daniel Mack <daniel@zonque.org>
Subject: [PATCH v5 0/5] leds: add devicetree functionality to lltc,lt3593 driver
Date: Wed, 27 Jun 2018 20:52:32 +0200 [thread overview]
Message-ID: <20180627185237.24830-1-daniel@zonque.org> (raw)
This is v5 of the series that brings devicetree support for the
lltc,lt3593 LED driver.
Before this series, the driver supported controlling multiple LEDs
through an array in the platform data. IOW, a single instance of the
driver was able to control multiple hardware chips.
This series changes that, and requires a distinct platform device to
be set up for each of them, if a board has multiple of these hardware
chips. The reason is that in DT, nodes should represent hardware, and
it's much cleaner this way.
As stated earlier in the thread for v1, the driver currently only has
one user in mainline (the Raumfeld platform) which is soon to be
replaced by a devicetree file. This user only uses one LED via pdata, so
the change mentioned above does not cause a regression.
Once the platform is fully ported to DT, I'll send another patch that
removes pdata handling from this driver completely, but it's kept around
as legacy bridge for now.
Changelog:
v4 → v5:
* Moved GPIO property from LED subnode to device node, as requested
by Rob Herring.
* Squashed the patch titled "sync module license information with
header" in 5/5.
v3 → v4:
* Fixed a mishap that slipped in during rebase which caused a compile
error
* Removed empty line at end of the DT documentation file
* Switched to SPDX license header in the driver
v2 → v3:
* Fixed a typo in the commit log of 1/5
* Rebased onto 4.18-rc1
v1 → v2:
* Moved LED-specific properties into a sub-node in DT, as requested by
Jacek Anaszewski.
Daniel Mack (5):
dt-bindings: leds: Add bindings for lltc,lt3593
leds: lt3593: merge functions and clean up code
leds: lt3593: switch to gpiod interface
leds: lt3593: Add device tree probing glue
leds: lt3593: update email address and switch to SPDX license header
.../devicetree/bindings/leds/leds-lt3593.txt | 32 +++
drivers/leds/leds-lt3593.c | 190 ++++++++++--------
2 files changed, 137 insertions(+), 85 deletions(-)
create mode 100644 Documentation/devicetree/bindings/leds/leds-lt3593.txt
--
2.17.1
next reply other threads:[~2018-06-27 18:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-27 18:52 Daniel Mack [this message]
2018-06-27 18:52 ` [PATCH v5 1/5] dt-bindings: leds: Add bindings for lltc,lt3593 Daniel Mack
2018-07-03 17:01 ` Rob Herring
2018-06-27 18:52 ` [PATCH v5 2/5] leds: lt3593: merge functions and clean up code Daniel Mack
2018-06-27 18:52 ` [PATCH v5 3/5] leds: lt3593: switch to gpiod interface Daniel Mack
2018-06-27 18:52 ` [PATCH v5 4/5] leds: lt3593: Add device tree probing glue Daniel Mack
2018-06-27 18:52 ` [PATCH v5 5/5] leds: lt3593: update email address and switch to SPDX license header Daniel Mack
2018-06-28 19:50 ` [PATCH v5 0/5] leds: add devicetree functionality to lltc,lt3593 driver Jacek Anaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180627185237.24830-1-daniel@zonque.org \
--to=daniel@zonque.org \
--cc=devicetree@vger.kernel.org \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-leds@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.