All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ming Lei <ming.lei@redhat.com>
To: Bart Van Assche <bart.vanassche@wdc.com>
Cc: "hch@lst.de" <hch@lst.de>,
	"drjones@redhat.com" <drjones@redhat.com>,
	"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
	"osandov@fb.com" <osandov@fb.com>,
	"axboe@kernel.dk" <axboe@kernel.dk>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"martin.petersen@oracle.com" <martin.petersen@oracle.com>
Subject: Re: [blk-mq Bug] race on removing hctx->dispatch_wait from wait queue
Date: Thu, 28 Jun 2018 07:24:25 +0800	[thread overview]
Message-ID: <20180627232424.GB7583@ming.t460p> (raw)
In-Reply-To: <9285867f-1534-ddbe-0f9f-62dff527de4b@wdc.com>

On Wed, Jun 27, 2018 at 01:00:08PM -0700, Bart Van Assche wrote:
> On 06/26/18 17:49, Ming Lei wrote:
> > Only the waitqueue's lock is held for blk_mq_dispatch_wake(), but this
> > hctx->dispatch_wait can be added to another waitqueue, so it isn't
> > enough to just hold waitqueue's lock.
> 
> Hello Ming,
> 
> That makes sense to me. I will post an update that addresses this issue.

I have sent a new patch days ago:

	https://marc.info/?l=linux-block&m=152998658713265&w=2

Thanks,
Ming

  reply	other threads:[~2018-06-27 23:24 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-24 10:16 [blk-mq Bug] race on removing hctx->dispatch_wait from wait queue Ming Lei
2018-06-24 16:33 ` Bart Van Assche
2018-06-25  7:24   ` Ming Lei
2018-06-26 20:19     ` Bart Van Assche
2018-06-27  0:49       ` Ming Lei
2018-06-27 20:00         ` Bart Van Assche
2018-06-27 23:24           ` Ming Lei [this message]
2018-06-25 11:15 ` Ming Lei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180627232424.GB7583@ming.t460p \
    --to=ming.lei@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=bart.vanassche@wdc.com \
    --cc=drjones@redhat.com \
    --cc=hch@lst.de \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=osandov@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.