From: Benson Leung <bleung@google.com>
To: mac.chiang@intel.com
Cc: alsa-devel@alsa-project.org, broonie@kernel.org,
bleung@chromium.org, pierre-louis.bossart@linux.intel.com,
bleung@google.com
Subject: Re: [PATCH] ASoC: Intel: kbl_da7219_max98357a: Map BTN_0 to KEY_PLAYPAUSE
Date: Wed, 27 Jun 2018 23:13:37 -0700 [thread overview]
Message-ID: <20180628061337.GA128601@decatoncale.mtv.corp.google.com> (raw)
In-Reply-To: <1530166267-13731-1-git-send-email-mac.chiang@intel.com>
[-- Attachment #1.1: Type: text/plain, Size: 1180 bytes --]
Hi Mac,
On Thu, Jun 28, 2018 at 02:11:07PM +0800, mac.chiang@intel.com wrote:
> From: Mac Chiang <mac.chiang@intel.com>
>
> On kbl_rt5663_max98927, commit 38a5882e4292
> ("ASoC: Intel: kbl_rt5663_max98927: Map BTN_0 to KEY_PLAYPAUSE")
> This key pair mapping to play/pause when playing Youtube
>
> The Android 3.5mm Headset jack specification mentions that BTN_0 should
> be mapped to KEY_MEDIA, but this is less logical than KEY_PLAYPAUSE,
> which has much broader userspace support.
>
> For example, the Chrome OS userspace now supports KEY_PLAYPAUSE to toggle
> play/pause of videos and audio, but does not handle KEY_MEDIA.
>
> Furthermore, Android itself now supports KEY_PLAYPAUSE equivalently, as the
> new USB headset spec requires KEY_PLAYPAUSE for BTN_0.
> https://source.android.com/devices/accessories/headset/usb-headset-spec
>
> The same fix is required on Chrome kbl_da7219_max98357a.
>
> Signed-off-by: Mac Chiang <mac.chiang@intel.com>
Reviewed-by: Benson Leung <bleung@chromium.org>
--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
bleung@google.com
Chromium OS Project
bleung@chromium.org
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2018-06-28 6:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-28 6:11 [PATCH] ASoC: Intel: kbl_da7219_max98357a: Map BTN_0 to KEY_PLAYPAUSE mac.chiang
2018-06-28 6:13 ` Benson Leung [this message]
2018-06-29 5:46 ` Pierre-Louis Bossart
2018-06-29 5:59 ` Naveen M
2018-06-29 21:31 ` Pierre-Louis Bossart
2019-05-02 6:12 mac.chiang@intel.com--cc=pierre-louis.bossart
2019-05-02 16:14 ` Pierre-Louis Bossart
2019-05-02 6:16 mac.chiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180628061337.GA128601@decatoncale.mtv.corp.google.com \
--to=bleung@google.com \
--cc=alsa-devel@alsa-project.org \
--cc=bleung@chromium.org \
--cc=broonie@kernel.org \
--cc=mac.chiang@intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.