All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sean Paul <seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
To: freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
	linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: jsanka-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
	robdclark-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	Sean Paul <seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
	hoegsberg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org,
	abhinavk-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org
Subject: [DPU PATCH 05/15] drm/msm: More cleanup in msm_drv
Date: Thu, 28 Jun 2018 14:28:56 -0400	[thread overview]
Message-ID: <20180628182906.84926-6-seanpaul@chromium.org> (raw)
In-Reply-To: <20180628182906.84926-1-seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>

Revert the component_bind function back to upstream.

Signed-off-by: Sean Paul <seanpaul@chromium.org>
---
 drivers/gpu/drm/msm/msm_drv.c | 30 +++++-------------------------
 1 file changed, 5 insertions(+), 25 deletions(-)

diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c
index 561617db7338..5181f997f071 100644
--- a/drivers/gpu/drm/msm/msm_drv.c
+++ b/drivers/gpu/drm/msm/msm_drv.c
@@ -380,26 +380,6 @@ static int msm_init_vram(struct drm_device *dev)
 	return ret;
 }
 
-#ifdef CONFIG_OF
-static int msm_component_bind_all(struct device *dev,
-				struct drm_device *drm_dev)
-{
-	int ret;
-
-	ret = component_bind_all(dev, drm_dev);
-	if (ret)
-		DRM_ERROR("component_bind_all failed: %d\n", ret);
-
-	return ret;
-}
-#else
-static int msm_component_bind_all(struct device *dev,
-				struct drm_device *drm_dev)
-{
-	return 0;
-}
-#endif
-
 static int msm_drm_init(struct device *dev, struct drm_driver *drv)
 {
 	struct platform_device *pdev = to_platform_device(dev);
@@ -455,16 +435,16 @@ static int msm_drm_init(struct device *dev, struct drm_driver *drv)
 
 	drm_mode_config_init(ddev);
 
-	msm_gem_shrinker_init(ddev);
+	/* Bind all our sub-components: */
+	ret = component_bind_all(dev, ddev);
+	if (ret)
+		goto bind_fail;
 
 	ret = msm_init_vram(ddev);
 	if (ret)
 		goto fail;
 
-	/* Bind all our sub-components: */
-	ret = msm_component_bind_all(dev, ddev);
-	if (ret)
-		goto bind_fail;
+	msm_gem_shrinker_init(ddev);
 
 	switch (get_mdp_ver(pdev)) {
 	case KMS_MDP4:
-- 
Sean Paul, Software Engineer, Google / Chromium OS

_______________________________________________
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/freedreno

  parent reply	other threads:[~2018-06-28 18:28 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-28 18:28 [DPU PATCH 00/15] drm/msm: dpu cleanup in msm Sean Paul
     [not found] ` <20180628182906.84926-1-seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2018-06-28 18:28   ` [DPU PATCH 01/15] drm/msm: Remove more dpu changes from msm core Sean Paul
2018-06-28 18:28   ` [DPU PATCH 02/15] video: Remove LF copyright in mipi_display.h Sean Paul
2018-06-28 18:28   ` [DPU PATCH 03/15] drm/msm: Move dpu_dbg init/destroy into dpu_kms Sean Paul
2018-06-28 18:28   ` [DPU PATCH 04/15] drm/msm: Remove more dpu-related code from msm_drv Sean Paul
     [not found]     ` <20180628182906.84926-5-seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2018-06-28 20:09       ` Jordan Crouse
     [not found]         ` <20180628200955.GF24526-9PYrDHPZ2Orvke4nUoYGnHL1okKdlPRT@public.gmane.org>
2018-06-28 20:29           ` Sean Paul
2018-06-28 18:28   ` Sean Paul [this message]
2018-06-28 18:28   ` [DPU PATCH 06/15] drm/msm: Move debugfs root tracking to dpu Sean Paul
2018-06-28 18:28   ` [DPU PATCH 07/15] drm/msm: Remove _dpu_format_calc_offset_linear() Sean Paul
2018-06-28 18:28   ` [DPU PATCH 08/15] drm/msm: dpu: Do debugfs init in the debugfs_init() hook Sean Paul
2018-06-28 18:29   ` [DPU PATCH 09/15] drm/msm: Remove get_address_space msm_kms hook Sean Paul
2018-06-28 18:29   ` [DPU PATCH 10/15] drm/msm: Remove dpu_kms_fbo and associated functions Sean Paul
2018-06-28 18:29   ` [DPU PATCH 11/15] drm/msm: Remove dpu module parameters Sean Paul
2018-06-28 18:29   ` [DPU PATCH 12/15] drm/msm: Remove unused backpointers from dpu_crtc Sean Paul
2018-06-28 18:29   ` [DPU PATCH 13/15] drm/msm: Reduce dpu_crtc_atomic_check frame size Sean Paul
2018-06-28 18:29   ` [DPU PATCH 14/15] drm/msm: Remove atomic_check() from msm_kms Sean Paul
2018-06-28 18:29   ` [DPU PATCH 15/15] drm/msm: Remove wait_for_tx_complete() " Sean Paul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180628182906.84926-6-seanpaul@chromium.org \
    --to=seanpaul-f7+t8e8rja9g9huczpvpmw@public.gmane.org \
    --cc=abhinavk-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
    --cc=freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    --cc=hoegsberg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
    --cc=jsanka-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
    --cc=linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=robdclark-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.