From: Guenter Roeck <linux@roeck-us.net>
To: Andrew Lunn <andrew@lunn.ch>
Cc: netdev <netdev@vger.kernel.org>,
Florian Fainelli <f.fainelli@gmail.com>,
Russell King <rmk+kernel@arm.linux.org.uk>,
vadimp@mellanox.com, linux-hwmon@vger.kernel.org
Subject: Re: [PATCH RFC 1/2] hwmon: Add support for power min, lcrit, min_alarm and lcrit_alarm
Date: Thu, 28 Jun 2018 15:42:36 -0700 [thread overview]
Message-ID: <20180628224236.GB20118@roeck-us.net> (raw)
In-Reply-To: <1530218475-4369-2-git-send-email-andrew@lunn.ch>
On Thu, Jun 28, 2018 at 10:41:14PM +0200, Andrew Lunn wrote:
> Some sensors support reporting minimal and lower critical power, as
> well as alarms when these thresholds are reached. Add support for
> these attributes to the hwmon core.
>
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
I am inclined to accept this patch immediately. I'll do that
in the next couple of days unless someone gives me a good reason
not to.
Guenter
> ---
> drivers/hwmon/hwmon.c | 4 ++++
> include/linux/hwmon.h | 8 ++++++++
> 2 files changed, 12 insertions(+)
>
> diff --git a/drivers/hwmon/hwmon.c b/drivers/hwmon/hwmon.c
> index e88c01961948..33d51281272b 100644
> --- a/drivers/hwmon/hwmon.c
> +++ b/drivers/hwmon/hwmon.c
> @@ -394,12 +394,16 @@ static const char * const hwmon_power_attr_templates[] = {
> [hwmon_power_cap_hyst] = "power%d_cap_hyst",
> [hwmon_power_cap_max] = "power%d_cap_max",
> [hwmon_power_cap_min] = "power%d_cap_min",
> + [hwmon_power_min] = "power%d_min",
> [hwmon_power_max] = "power%d_max",
> + [hwmon_power_lcrit] = "power%d_lcrit",
> [hwmon_power_crit] = "power%d_crit",
> [hwmon_power_label] = "power%d_label",
> [hwmon_power_alarm] = "power%d_alarm",
> [hwmon_power_cap_alarm] = "power%d_cap_alarm",
> + [hwmon_power_min_alarm] = "power%d_min_alarm",
> [hwmon_power_max_alarm] = "power%d_max_alarm",
> + [hwmon_power_lcrit_alarm] = "power%d_lcrit_alarm",
> [hwmon_power_crit_alarm] = "power%d_crit_alarm",
> };
>
> diff --git a/include/linux/hwmon.h b/include/linux/hwmon.h
> index 1b74ad11a5a4..b217101ca76e 100644
> --- a/include/linux/hwmon.h
> +++ b/include/linux/hwmon.h
> @@ -188,12 +188,16 @@ enum hwmon_power_attributes {
> hwmon_power_cap_hyst,
> hwmon_power_cap_max,
> hwmon_power_cap_min,
> + hwmon_power_min,
> hwmon_power_max,
> hwmon_power_crit,
> + hwmon_power_lcrit,
> hwmon_power_label,
> hwmon_power_alarm,
> hwmon_power_cap_alarm,
> + hwmon_power_min_alarm,
> hwmon_power_max_alarm,
> + hwmon_power_lcrit_alarm,
> hwmon_power_crit_alarm,
> };
>
> @@ -214,12 +218,16 @@ enum hwmon_power_attributes {
> #define HWMON_P_CAP_HYST BIT(hwmon_power_cap_hyst)
> #define HWMON_P_CAP_MAX BIT(hwmon_power_cap_max)
> #define HWMON_P_CAP_MIN BIT(hwmon_power_cap_min)
> +#define HWMON_P_MIN BIT(hwmon_power_min)
> #define HWMON_P_MAX BIT(hwmon_power_max)
> +#define HWMON_P_LCRIT BIT(hwmon_power_lcrit)
> #define HWMON_P_CRIT BIT(hwmon_power_crit)
> #define HWMON_P_LABEL BIT(hwmon_power_label)
> #define HWMON_P_ALARM BIT(hwmon_power_alarm)
> #define HWMON_P_CAP_ALARM BIT(hwmon_power_cap_alarm)
> +#define HWMON_P_MIN_ALARM BIT(hwmon_power_max_alarm)
> #define HWMON_P_MAX_ALARM BIT(hwmon_power_max_alarm)
> +#define HWMON_P_LCRIT_ALARM BIT(hwmon_power_lcrit_alarm)
> #define HWMON_P_CRIT_ALARM BIT(hwmon_power_crit_alarm)
>
> enum hwmon_energy_attributes {
> --
> 2.18.0.rc2
>
next prev parent reply other threads:[~2018-06-28 22:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-28 20:41 [PATCH RFC 0/2] HWMON support for SFP modules Andrew Lunn
2018-06-28 20:41 ` [PATCH RFC 1/2] hwmon: Add support for power min, lcrit, min_alarm and lcrit_alarm Andrew Lunn
2018-06-28 22:42 ` Guenter Roeck [this message]
2018-06-29 7:21 ` Andrew Lunn
2018-06-29 17:12 ` Guenter Roeck
2018-06-28 20:41 ` [PATCH RFC 2/2] net: phy: sfp: Add HWMON support for module sensors Andrew Lunn
2018-06-28 22:41 ` Guenter Roeck
2018-06-29 7:45 ` Andrew Lunn
2018-06-29 15:47 ` Russell King - ARM Linux
2018-06-29 17:34 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180628224236.GB20118@roeck-us.net \
--to=linux@roeck-us.net \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=vadimp@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.