From mboxrd@z Thu Jan 1 00:00:00 1970 From: Miquel Raynal Subject: Re: [PATCH v3 07/17] irqchip/irq-mvebu-icu: make irq_domain local Date: Fri, 29 Jun 2018 14:32:11 +0200 Message-ID: <20180629143211.4b4f827a@xps13> References: <20180622151432.1566-1-miquel.raynal@bootlin.com> <20180622151432.1566-8-miquel.raynal@bootlin.com> <2f751e0a-857e-22ab-1748-5fd1cb127766@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <2f751e0a-857e-22ab-1748-5fd1cb127766@arm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Marc Zyngier Cc: Mark Rutland , Andrew Lunn , Jason Cooper , devicetree@vger.kernel.org, Antoine Tenart , Catalin Marinas , Gregory Clement , Haim Boot , Will Deacon , Maxime Chevallier , Nadav Haklai , Rob Herring , Thomas Petazzoni , Thomas Gleixner , Hanna Hawa , linux-arm-kernel@lists.infradead.org, Sebastian Hesselbarth List-Id: devicetree@vger.kernel.org SGkgTWFyYywKCk1hcmMgWnluZ2llciA8bWFyYy56eW5naWVyQGFybS5jb20+IHdyb3RlIG9uIFRo dSwgMjggSnVuIDIwMTggMTM6MTA6MDUKKzAxMDA6Cgo+IE9uIDIyLzA2LzE4IDE2OjE0LCBNaXF1 ZWwgUmF5bmFsIHdyb3RlOgo+ID4gTWFrZSB0aGUgY3VycmVudCBNU0kgaXJxX2RvbWFpbiBsb2Nh bCB0byBlYXNlIHRoZSBzcGxpdCBiZXR3ZWVuIElDVQo+ID4gcGxhdGZvcm0gZGV2aWNlIGNvZGUg YW5kIE5TUiBwbGF0Zm9ybSBkZXZpY2UgY29kZS4KPiA+IAo+ID4gU2lnbmVkLW9mZi1ieTogTWlx dWVsIFJheW5hbCA8bWlxdWVsLnJheW5hbEBib290bGluLmNvbT4KPiA+IFJldmlld2VkLWJ5OiBU aG9tYXMgUGV0YXp6b25pIDx0aG9tYXMucGV0YXp6b25pQGJvb3RsaW4uY29tPgo+ID4gLS0tCj4g PiAgZHJpdmVycy9pcnFjaGlwL2lycS1tdmVidS1pY3UuYyB8IDYgKysrLS0tCj4gPiAgMSBmaWxl IGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKPiA+IAo+ID4gZGlmZiAt LWdpdCBhL2RyaXZlcnMvaXJxY2hpcC9pcnEtbXZlYnUtaWN1LmMgYi9kcml2ZXJzL2lycWNoaXAv aXJxLW12ZWJ1LWljdS5jCj4gPiBpbmRleCAzNjk0YzBkNzNjMGQuLjYwNzk0ODg3MGExNCAxMDA2 NDQKPiA+IC0tLSBhL2RyaXZlcnMvaXJxY2hpcC9pcnEtbXZlYnUtaWN1LmMKPiA+ICsrKyBiL2Ry aXZlcnMvaXJxY2hpcC9pcnEtbXZlYnUtaWN1LmMKPiA+IEBAIC00MSw3ICs0MSw2IEBACj4gPiAg c3RydWN0IG12ZWJ1X2ljdSB7Cj4gPiAgCXN0cnVjdCBpcnFfY2hpcCBpcnFfY2hpcDsKPiA+ICAJ c3RydWN0IHJlZ21hcCAqcmVnbWFwOwo+ID4gLQlzdHJ1Y3QgaXJxX2RvbWFpbiAqZG9tYWluOwo+ ID4gIAlzdHJ1Y3QgZGV2aWNlICpkZXY7Cj4gPiAgCWF0b21pY190IGluaXRpYWxpemVkOwo+ID4g IH07Cj4gPiBAQCAtMjE4LDYgKzIxNyw3IEBAIHN0YXRpYyBpbnQgbXZlYnVfaWN1X3Byb2JlKHN0 cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYpCj4gPiAgCXN0cnVjdCBtdmVidV9pY3UgKmljdTsK PiA+ICAJc3RydWN0IGRldmljZV9ub2RlICpub2RlID0gcGRldi0+ZGV2Lm9mX25vZGU7Cj4gPiAg CXN0cnVjdCBkZXZpY2Vfbm9kZSAqZ2ljcF9kbjsKPiA+ICsJc3RydWN0IGlycV9kb21haW4gKmly cV9kb21haW47Cj4gPiAgCXN0cnVjdCByZXNvdXJjZSAqcmVzOwo+ID4gIAl2b2lkIF9faW9tZW0g KnJlZ3M7Cj4gPiAgCWludCBpOwo+ID4gQEAgLTI4MiwxMSArMjgyLDExIEBAIHN0YXRpYyBpbnQg bXZlYnVfaWN1X3Byb2JlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYpCj4gPiAgCQkJcmVn bWFwX3dyaXRlKGljdS0+cmVnbWFwLCBJQ1VfSU5UX0NGRyhpKSwgMCk7Cj4gPiAgCX0KPiA+ICAK PiA+IC0JaWN1LT5kb21haW4gPQo+ID4gKwlpcnFfZG9tYWluID0KPiA+ICAJCXBsYXRmb3JtX21z aV9jcmVhdGVfZGV2aWNlX2RvbWFpbigmcGRldi0+ZGV2LCBJQ1VfTUFYX0lSUVMsCj4gPiAgCQkJ CQkJICBtdmVidV9pY3Vfd3JpdGVfbXNnLAo+ID4gIAkJCQkJCSAgJm12ZWJ1X2ljdV9kb21haW5f b3BzLCBpY3UpOyAgCj4gCj4gbml0OiB0aGlzIHJlYWxseSBodXJ0cyBteSBleWVzLiBQbGVhc2Ug cHV0IHRoZSA9IHNpZ24gYW5kIHRoZSBmdW5jdGlvbgo+IGNhbGwgb24gYSBzaW5nbGUgbGluZS4g SSByZWFsbHkgZG9uJ3QgY2FyZSBpZiBpdCBjaGVja3BhdGNoIGlzIGhhdmluZyBhCj4gZml0IGJl Y2F1c2Ugb2YgdGhhdC4KCkkgYWxzbyBkaXNsaWtlLiBXaWxsIGNoYW5nZS4KCj4gCj4gPiAtCWlm ICghaWN1LT5kb21haW4pIHsKPiA+ICsJaWYgKCFpcnFfZG9tYWluKSB7Cj4gPiAgCQlkZXZfZXJy KCZwZGV2LT5kZXYsICJGYWlsZWQgdG8gY3JlYXRlIElDVSBkb21haW5cbiIpOwo+ID4gIAkJcmV0 dXJuIC1FTk9NRU07Cj4gPiAgCX0KPiA+ICAgCj4gCj4gQnV0IGxvb2tpbmcgYXQgdGhlIG5leHQg cGF0Y2gsIHlvdSBtaWdodCBhcyB3ZWxsIGZvbGQgdGhlIHR3by4gT24gaXRzCj4gb3duLCB0aGlz IHBhdGNoZXMgaXMgcHJldHR5IHBvaW50bGVzcy4KCk1vc3Qgb2Z0ZW4gcGVvcGxlIGFzayB0byBz cGxpdCBsb2dpY2FsIGNoYW5nZXMgYXMgbXVjaCBhcyBwb3NzaWJsZS4gQnV0CkkgaGF2ZSBubyBw cm9ibGVtIHNxdWFzaGluZyB0aGVzZSB0d28gcGF0Y2hlcy4KCgpUaGFua3MsCk1pcXXDqGwKCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1r ZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpo dHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJu ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: miquel.raynal@bootlin.com (Miquel Raynal) Date: Fri, 29 Jun 2018 14:32:11 +0200 Subject: [PATCH v3 07/17] irqchip/irq-mvebu-icu: make irq_domain local In-Reply-To: <2f751e0a-857e-22ab-1748-5fd1cb127766@arm.com> References: <20180622151432.1566-1-miquel.raynal@bootlin.com> <20180622151432.1566-8-miquel.raynal@bootlin.com> <2f751e0a-857e-22ab-1748-5fd1cb127766@arm.com> Message-ID: <20180629143211.4b4f827a@xps13> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Marc, Marc Zyngier wrote on Thu, 28 Jun 2018 13:10:05 +0100: > On 22/06/18 16:14, Miquel Raynal wrote: > > Make the current MSI irq_domain local to ease the split between ICU > > platform device code and NSR platform device code. > > > > Signed-off-by: Miquel Raynal > > Reviewed-by: Thomas Petazzoni > > --- > > drivers/irqchip/irq-mvebu-icu.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/irqchip/irq-mvebu-icu.c b/drivers/irqchip/irq-mvebu-icu.c > > index 3694c0d73c0d..607948870a14 100644 > > --- a/drivers/irqchip/irq-mvebu-icu.c > > +++ b/drivers/irqchip/irq-mvebu-icu.c > > @@ -41,7 +41,6 @@ > > struct mvebu_icu { > > struct irq_chip irq_chip; > > struct regmap *regmap; > > - struct irq_domain *domain; > > struct device *dev; > > atomic_t initialized; > > }; > > @@ -218,6 +217,7 @@ static int mvebu_icu_probe(struct platform_device *pdev) > > struct mvebu_icu *icu; > > struct device_node *node = pdev->dev.of_node; > > struct device_node *gicp_dn; > > + struct irq_domain *irq_domain; > > struct resource *res; > > void __iomem *regs; > > int i; > > @@ -282,11 +282,11 @@ static int mvebu_icu_probe(struct platform_device *pdev) > > regmap_write(icu->regmap, ICU_INT_CFG(i), 0); > > } > > > > - icu->domain = > > + irq_domain = > > platform_msi_create_device_domain(&pdev->dev, ICU_MAX_IRQS, > > mvebu_icu_write_msg, > > &mvebu_icu_domain_ops, icu); > > nit: this really hurts my eyes. Please put the = sign and the function > call on a single line. I really don't care if it checkpatch is having a > fit because of that. I also dislike. Will change. > > > - if (!icu->domain) { > > + if (!irq_domain) { > > dev_err(&pdev->dev, "Failed to create ICU domain\n"); > > return -ENOMEM; > > } > > > > But looking at the next patch, you might as well fold the two. On its > own, this patches is pretty pointless. Most often people ask to split logical changes as much as possible. But I have no problem squashing these two patches. Thanks, Miqu?l