From mboxrd@z Thu Jan 1 00:00:00 1970 From: Miquel Raynal Subject: Re: [PATCH v3 01/17] platform-msi: allow creation of MSI domain without interrupt number Date: Fri, 29 Jun 2018 16:43:23 +0200 Message-ID: <20180629164323.7fb2a0c3@xps13> References: <20180622151432.1566-1-miquel.raynal@bootlin.com> <20180622151432.1566-2-miquel.raynal@bootlin.com> <20180629094035.5199fe89@xps13> <86bmbtzmhk.wl-marc.zyngier@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <86bmbtzmhk.wl-marc.zyngier@arm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Marc Zyngier Cc: Mark Rutland , Andrew Lunn , Jason Cooper , devicetree@vger.kernel.org, Antoine Tenart , Catalin Marinas , Gregory Clement , Haim Boot , Will Deacon , Maxime Chevallier , Nadav Haklai , Rob Herring , Thomas Petazzoni , Thomas Gleixner , Hanna Hawa , linux-arm-kernel@lists.infradead.org, Sebastian Hesselbarth List-Id: devicetree@vger.kernel.org SGkgTWFyYywKCk1hcmMgWnluZ2llciA8bWFyYy56eW5naWVyQGFybS5jb20+IHdyb3RlIG9uIEZy aSwgMjkgSnVuIDIwMTggMTU6Mzg6MzEKKzAxMDA6Cgo+IE9uIEZyaSwgMjkgSnVuIDIwMTggMDg6 NDA6MzUgKzAxMDAsCj4gTWlxdWVsIFJheW5hbCA8bWlxdWVsLnJheW5hbEBib290bGluLmNvbT4g d3JvdGU6Cj4gPiAKPiA+IEhpIE1hcmMsCj4gPiAKPiA+IE1hcmMgWnluZ2llciA8bWFyYy56eW5n aWVyQGFybS5jb20+IHdyb3RlIG9uIFRodSwgMjggSnVuIDIwMTggMTI6MTI6MDQKPiA+ICswMTAw Ogo+ID4gICAKPiA+ID4gT24gMjIvMDYvMTggMTY6MTQsIE1pcXVlbCBSYXluYWwgd3JvdGU6ICAK PiA+ID4gPiBwbGF0Zm9ybV9tc2lfYWxsb2NfcHJpdl9kYXRhKCkgY2hlY2tzIHRoYXQgYSBudW1i ZXIgb2YgaW50ZXJydXB0cyBpcwo+ID4gPiA+IGFsd2F5cyBnaXZlbi4gVGhpcyBleHRyYS1jaGVj ayBoYXMgbm8gcmVhbCBpbXBhY3QgYW5kIGp1c3QgcHJldmVudHMKPiA+ID4gPiB1c2VsZXNzbHkg dGhlIHVzZXIgdG8gY3JlYXRlIGFuIE1TSSB0cmVlIGRvbWFpbjogcmVtb3ZlIGl0Lgo+ID4gPiA+ IAo+ID4gPiA+IFNpZ25lZC1vZmYtYnk6IE1pcXVlbCBSYXluYWwgPG1pcXVlbC5yYXluYWxAYm9v dGxpbi5jb20+Cj4gPiA+ID4gLS0tCj4gPiA+ID4gIGRyaXZlcnMvYmFzZS9wbGF0Zm9ybS1tc2ku YyB8IDIgKy0KPiA+ID4gPiAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0 aW9uKC0pCj4gPiA+ID4gCj4gPiA+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvYmFzZS9wbGF0Zm9y bS1tc2kuYyBiL2RyaXZlcnMvYmFzZS9wbGF0Zm9ybS1tc2kuYwo+ID4gPiA+IGluZGV4IDYwZDZj YzYxOGYxYy4uOWYwMDFmNGNjYzBmIDEwMDY0NAo+ID4gPiA+IC0tLSBhL2RyaXZlcnMvYmFzZS9w bGF0Zm9ybS1tc2kuYwo+ID4gPiA+ICsrKyBiL2RyaXZlcnMvYmFzZS9wbGF0Zm9ybS1tc2kuYwo+ ID4gPiA+IEBAIC0yMDMsNyArMjAzLDcgQEAgcGxhdGZvcm1fbXNpX2FsbG9jX3ByaXZfZGF0YShz dHJ1Y3QgZGV2aWNlICpkZXYsIHVuc2lnbmVkIGludCBudmVjLAo+ID4gPiA+ICAJICogYWNjb3Jk aW5nbHkgKHdoaWNoIHdvdWxkIGltcGFjdCB0aGUgbWF4IG51bWJlciBvZiBNU0kKPiA+ID4gPiAg CSAqIGNhcGFibGUgZGV2aWNlcykuCj4gPiA+ID4gIAkgKi8KPiA+ID4gPiAtCWlmICghZGV2LT5t c2lfZG9tYWluIHx8ICF3cml0ZV9tc2lfbXNnIHx8ICFudmVjIHx8IG52ZWMgPiBNQVhfREVWX01T SVMpCj4gPiA+ID4gKwlpZiAoIWRldi0+bXNpX2RvbWFpbiB8fCAhd3JpdGVfbXNpX21zZyB8fCBu dmVjID4gTUFYX0RFVl9NU0lTKQo+ID4gPiA+ICAJCXJldHVybiBFUlJfUFRSKC1FSU5WQUwpOwo+ ID4gPiA+ICAKPiA+ID4gPiAgCWlmIChkZXYtPm1zaV9kb21haW4tPmJ1c190b2tlbiAhPSBET01B SU5fQlVTX1BMQVRGT1JNX01TSSkgewo+ID4gPiA+ICAgICAKPiA+ID4gCj4gPiA+IEh1aC4uLiBJ dCdzIG5vdCB0aGF0IHNpbXBsZS4KPiA+ID4gCj4gPiA+IFllcywgaXQgYWxsb3dzIHlvdSB0byBn ZXQgYSB0cmVlIHZpYSBwbGF0Zm9ybV9tc2lfY3JlYXRlX2RldmljZV9kb21haW4KPiA+ID4gKGFz c3VtaW5nIHRoYXQncyB3aHkgeW91J3JlIGNoYW5naW5nIGl0IC0tIHlvdXIgY29tbWl0IG1lc3Nh Z2UgZG9lc24ndAo+ID4gPiBzYXkgbXVjaCkgIAo+ID4gCj4gPiBJbmRlZWQuIFRoYXQgd2FzIGV4 YWN0bHkgbXkgaW50ZW50aW9uLgo+ID4gICAKPiA+ID4gYnV0IGl0IGFsc28gaGFzIHNvbWUgaW1w YWN0IG9uIHRoZSB3YXkgbXNpX2RvbWFpbl9wcmVwYXJlX2lycXMKPiA+ID4gd29ya3MgKHNlZSBo b3cgaXQgaXMgY2FsbGVkIGZyb20gcGxhdGZvcm1fbXNpX2NyZWF0ZV9kZXZpY2VfZG9tYWluKS4K PiA+ID4gCj4gPiA+IEltcG9ydGFudGx5LCB0aGUgbXNpX3ByZXBhcmUgY2FsbGJhY2sgdGFrZXMg bnZlYyBhcyBhIHBhcmFtZXRlciwgYW5kCj4gPiA+IHRoYXQgZW5kcyB1cCB0cmlja2xpbmcgZG93 biB0byB0aGUgaXJxY2hpcCwgb3Igd2hhdGV2ZXIgd2lsbCBzZXR1cCB0aGUKPiA+ID4gTVNJIGRv bWFpbi4gVGhpbmdzIGxpa2UgdGhlIEdJQ3YzIElUUyBkbyByZWx5IG9uIHRoYXQgdG8gY2FydmUg b3V0IHRoZQo+ID4gPiBMUEkgc3BhY2UgdGhhdCBzdWJzZXF1ZW50bHkgZ2V0cyB1c2VkIHRvIHBv cHVsYXRlIHRoZSBkb21haW4uCj4gPiA+IAo+ID4gPiBTbyBubywgeW91IGNhbid0IGRvIGl0IGxp a2UgdGhhdC4gSWYgeW91IHJlYWxseSB3YW50IGEgdHJlZSwgYWRkIGEKPiA+ID4gaGVscGVyIHRo YXQgZG9lcyBzby4gIAo+ID4gCj4gPiBTbyBpZiBJIHVuZGVyc3RhbmQgY29ycmVjdGx5LCB3aGF0 IHNob3VsZCBiZSBkb25lIGlzIHdyaXR0aW5nIGEgbmV3Cj4gPiBoZWxwZXIgdGhhdCB3b3VsZCBk byBzb21ldGhpbmcgc2ltaWxhciB0bwo+ID4gcGxhdGZvcm1fbXNpX2NyZWF0ZV9kZXZpY2VfZG9t YWluKCksIGJ1dCBjcmVhdGluZyBpbnN0ZWFkIGEgdHJlZSBkb21haW4KPiA+IGFuZCBzdGlsbCBn aXZpbmcgbXNpX2RvbWFpbl9wcmVwYXJlX2lycXMoKSBhIG1lYW5pbmdmdWwgbnVtYmVyIChhcwo+ ID4gbnZlYykgdGhhdCB3b3VsZCBiZSB0aGUgbWF4aW11bSBudW1iZXIgb2YgTVNJcyB0aGF0IGNv dWxkIGJlIGFsbG9jYXRlZC4KPiA+IEFtIEkgcmlnaHQgaGVyZT8gIAo+IAo+IFdoYXQgSSBoYXZl IGluIG1pbmQgaXMgdGhlIGZvbGxvd2luZyAodW50ZXN0ZWQpIHBhdGNoLiBMZXQgbWUga25vdyBp Zgo+IHRoYXQgd29ya3MgZm9yIHlvdS4KCk9rLCB0aGF0J3MgcmVhbGx5IGNsb3NlIHRvIHdoYXQg SSB3cm90ZSB0aGlzIG1vcm5pbmcsIGNvb2wuIEkgd2FzIG5vdApzdXJlIHRoYXQgd2FzIHRoZSBv bmx5IHRoaW5nIHRvIG1vZGlmeS4KClRoYW5rcywKTWlxdcOobAoKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxp c3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZy YWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: miquel.raynal@bootlin.com (Miquel Raynal) Date: Fri, 29 Jun 2018 16:43:23 +0200 Subject: [PATCH v3 01/17] platform-msi: allow creation of MSI domain without interrupt number In-Reply-To: <86bmbtzmhk.wl-marc.zyngier@arm.com> References: <20180622151432.1566-1-miquel.raynal@bootlin.com> <20180622151432.1566-2-miquel.raynal@bootlin.com> <20180629094035.5199fe89@xps13> <86bmbtzmhk.wl-marc.zyngier@arm.com> Message-ID: <20180629164323.7fb2a0c3@xps13> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Marc, Marc Zyngier wrote on Fri, 29 Jun 2018 15:38:31 +0100: > On Fri, 29 Jun 2018 08:40:35 +0100, > Miquel Raynal wrote: > > > > Hi Marc, > > > > Marc Zyngier wrote on Thu, 28 Jun 2018 12:12:04 > > +0100: > > > > > On 22/06/18 16:14, Miquel Raynal wrote: > > > > platform_msi_alloc_priv_data() checks that a number of interrupts is > > > > always given. This extra-check has no real impact and just prevents > > > > uselessly the user to create an MSI tree domain: remove it. > > > > > > > > Signed-off-by: Miquel Raynal > > > > --- > > > > drivers/base/platform-msi.c | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > diff --git a/drivers/base/platform-msi.c b/drivers/base/platform-msi.c > > > > index 60d6cc618f1c..9f001f4ccc0f 100644 > > > > --- a/drivers/base/platform-msi.c > > > > +++ b/drivers/base/platform-msi.c > > > > @@ -203,7 +203,7 @@ platform_msi_alloc_priv_data(struct device *dev, unsigned int nvec, > > > > * accordingly (which would impact the max number of MSI > > > > * capable devices). > > > > */ > > > > - if (!dev->msi_domain || !write_msi_msg || !nvec || nvec > MAX_DEV_MSIS) > > > > + if (!dev->msi_domain || !write_msi_msg || nvec > MAX_DEV_MSIS) > > > > return ERR_PTR(-EINVAL); > > > > > > > > if (dev->msi_domain->bus_token != DOMAIN_BUS_PLATFORM_MSI) { > > > > > > > > > > Huh... It's not that simple. > > > > > > Yes, it allows you to get a tree via platform_msi_create_device_domain > > > (assuming that's why you're changing it -- your commit message doesn't > > > say much) > > > > Indeed. That was exactly my intention. > > > > > but it also has some impact on the way msi_domain_prepare_irqs > > > works (see how it is called from platform_msi_create_device_domain). > > > > > > Importantly, the msi_prepare callback takes nvec as a parameter, and > > > that ends up trickling down to the irqchip, or whatever will setup the > > > MSI domain. Things like the GICv3 ITS do rely on that to carve out the > > > LPI space that subsequently gets used to populate the domain. > > > > > > So no, you can't do it like that. If you really want a tree, add a > > > helper that does so. > > > > So if I understand correctly, what should be done is writting a new > > helper that would do something similar to > > platform_msi_create_device_domain(), but creating instead a tree domain > > and still giving msi_domain_prepare_irqs() a meaningful number (as > > nvec) that would be the maximum number of MSIs that could be allocated. > > Am I right here? > > What I have in mind is the following (untested) patch. Let me know if > that works for you. Ok, that's really close to what I wrote this morning, cool. I was not sure that was the only thing to modify. Thanks, Miqu?l