From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F4092C6778C for ; Fri, 29 Jun 2018 17:31:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BA75D278D9 for ; Fri, 29 Jun 2018 17:31:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BA75D278D9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934093AbeF2Ra6 (ORCPT ); Fri, 29 Jun 2018 13:30:58 -0400 Received: from mga17.intel.com ([192.55.52.151]:17766 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932548AbeF2Ra4 (ORCPT ); Fri, 29 Jun 2018 13:30:56 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Jun 2018 10:30:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,286,1526367600"; d="scan'208";a="67446535" Received: from theros.lm.intel.com (HELO linux.intel.com) ([10.232.112.164]) by fmsmga004.fm.intel.com with ESMTP; 29 Jun 2018 10:30:55 -0700 Date: Fri, 29 Jun 2018 11:30:55 -0600 From: Ross Zwisler To: Matthew Wilcox Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Jan Kara , Jeff Layton , Lukas Czerner , Ross Zwisler , Christoph Hellwig , Goldwyn Rodrigues , Nicholas Piggin , Ryusuke Konishi , linux-nilfs@vger.kernel.org, Jaegeuk Kim , Chao Yu , linux-f2fs-devel@lists.sourceforge.net Subject: Re: [PATCH v14 68/74] dax: Convert dax_lock_page to XArray Message-ID: <20180629173055.GA2973@linux.intel.com> Mail-Followup-To: Ross Zwisler , Matthew Wilcox , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Jan Kara , Jeff Layton , Lukas Czerner , Christoph Hellwig , Goldwyn Rodrigues , Nicholas Piggin , Ryusuke Konishi , linux-nilfs@vger.kernel.org, Jaegeuk Kim , Chao Yu , linux-f2fs-devel@lists.sourceforge.net References: <20180617020052.4759-1-willy@infradead.org> <20180617020052.4759-69-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180617020052.4759-69-willy@infradead.org> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jun 16, 2018 at 07:00:46PM -0700, Matthew Wilcox wrote: > Signed-off-by: Matthew Wilcox > --- <> > +static void *dax_make_page_entry(struct page *page, void *entry) > +{ > + pfn_t pfn = page_to_pfn_t(page); > + return dax_make_entry(pfn, dax_is_pmd_entry(entry)); > +} This function is defined and never used, so we get: fs/dax.c:106:14: warning: ‘dax_make_page_entry’ defined but not used [-Wunused-function] static void *dax_make_page_entry(struct page *page, void *entry) ^~~~~~~~~~~~~~~~~~~ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl0-f72.google.com (mail-pl0-f72.google.com [209.85.160.72]) by kanga.kvack.org (Postfix) with ESMTP id DC42E6B0005 for ; Fri, 29 Jun 2018 13:30:58 -0400 (EDT) Received: by mail-pl0-f72.google.com with SMTP id ba8-v6so3147463plb.4 for ; Fri, 29 Jun 2018 10:30:58 -0700 (PDT) Received: from mga11.intel.com (mga11.intel.com. [192.55.52.93]) by mx.google.com with ESMTPS id e9-v6si1317322pgu.636.2018.06.29.10.30.56 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 29 Jun 2018 10:30:56 -0700 (PDT) Date: Fri, 29 Jun 2018 11:30:55 -0600 From: Ross Zwisler Subject: Re: [PATCH v14 68/74] dax: Convert dax_lock_page to XArray Message-ID: <20180629173055.GA2973@linux.intel.com> References: <20180617020052.4759-1-willy@infradead.org> <20180617020052.4759-69-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180617020052.4759-69-willy@infradead.org> Sender: owner-linux-mm@kvack.org List-ID: To: Matthew Wilcox Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Jan Kara , Jeff Layton , Lukas Czerner , Ross Zwisler , Christoph Hellwig , Goldwyn Rodrigues , Nicholas Piggin , Ryusuke Konishi , linux-nilfs@vger.kernel.org, Jaegeuk Kim , Chao Yu , linux-f2fs-devel@lists.sourceforge.net On Sat, Jun 16, 2018 at 07:00:46PM -0700, Matthew Wilcox wrote: > Signed-off-by: Matthew Wilcox > --- <> > +static void *dax_make_page_entry(struct page *page, void *entry) > +{ > + pfn_t pfn = page_to_pfn_t(page); > + return dax_make_entry(pfn, dax_is_pmd_entry(entry)); > +} This function is defined and never used, so we get: fs/dax.c:106:14: warning: a??dax_make_page_entrya?? defined but not used [-Wunused-function] static void *dax_make_page_entry(struct page *page, void *entry) ^~~~~~~~~~~~~~~~~~~