From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from verein.lst.de ([213.95.11.211]:60936 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751539AbeGAGVV (ORCPT ); Sun, 1 Jul 2018 02:21:21 -0400 Date: Sun, 1 Jul 2018 08:21:42 +0200 From: Christoph Hellwig To: Andreas Gruenbacher Cc: Christoph Hellwig , cluster-devel@redhat.com, linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH] iomap: Add inline data support to iomap_readpage_actor Message-ID: <20180701062141.GA27281@lst.de> References: <20180615130209.1970-2-hch@lst.de> <20180629144444.28826-1-agruenba@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180629144444.28826-1-agruenba@redhat.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Looks sensible, although I think it could use some more sanity checking and a changelog. Does the version below work for you? --- >>From e4603b7acde9b77e7a4aad6038c7ac42ca35772d Mon Sep 17 00:00:00 2001 From: Andreas Gruenbacher Date: Fri, 29 Jun 2018 16:44:44 +0200 Subject: iomap: Add inline data support to iomap_readpage_actor Just copy the inline data into the page using the existing helper. Signed-off-by: Andreas Gruenbacher Signed-off-by: Christoph Hellwig --- fs/iomap.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/fs/iomap.c b/fs/iomap.c index 4d8ff0f5ecc9..966ffad9706a 100644 --- a/fs/iomap.c +++ b/fs/iomap.c @@ -155,6 +155,13 @@ iomap_readpage_actor(struct inode *inode, loff_t pos, loff_t length, void *data, bool is_contig = false; sector_t sector; + if (iomap->type == IOMAP_INLINE) { + WARN_ON_ONCE(poff); + WARN_ON_ONCE(plen != PAGE_SIZE); + iomap_read_inline_data(inode, page, iomap); + return PAGE_SIZE; + } + /* we don't support blocksize < PAGE_SIZE quite yet. */ WARN_ON_ONCE(pos != page_offset(page)); WARN_ON_ONCE(plen != PAGE_SIZE); -- 2.18.0 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH] iomap: Add inline data support to iomap_readpage_actor Date: Sun, 1 Jul 2018 08:21:42 +0200 Message-ID: <20180701062141.GA27281@lst.de> References: <20180615130209.1970-2-hch@lst.de> <20180629144444.28826-1-agruenba@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: cluster-devel@redhat.com, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, Christoph Hellwig To: Andreas Gruenbacher Return-path: Content-Disposition: inline In-Reply-To: <20180629144444.28826-1-agruenba@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: cluster-devel-bounces@redhat.com Errors-To: cluster-devel-bounces@redhat.com List-Id: linux-ext4.vger.kernel.org Looks sensible, although I think it could use some more sanity checking and a changelog. Does the version below work for you? --- >>From e4603b7acde9b77e7a4aad6038c7ac42ca35772d Mon Sep 17 00:00:00 2001 From: Andreas Gruenbacher Date: Fri, 29 Jun 2018 16:44:44 +0200 Subject: iomap: Add inline data support to iomap_readpage_actor Just copy the inline data into the page using the existing helper. Signed-off-by: Andreas Gruenbacher Signed-off-by: Christoph Hellwig --- fs/iomap.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/fs/iomap.c b/fs/iomap.c index 4d8ff0f5ecc9..966ffad9706a 100644 --- a/fs/iomap.c +++ b/fs/iomap.c @@ -155,6 +155,13 @@ iomap_readpage_actor(struct inode *inode, loff_t pos, loff_t length, void *data, bool is_contig = false; sector_t sector; + if (iomap->type == IOMAP_INLINE) { + WARN_ON_ONCE(poff); + WARN_ON_ONCE(plen != PAGE_SIZE); + iomap_read_inline_data(inode, page, iomap); + return PAGE_SIZE; + } + /* we don't support blocksize < PAGE_SIZE quite yet. */ WARN_ON_ONCE(pos != page_offset(page)); WARN_ON_ONCE(plen != PAGE_SIZE); -- 2.18.0 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Date: Sun, 1 Jul 2018 08:21:42 +0200 Subject: [Cluster-devel] [PATCH] iomap: Add inline data support to iomap_readpage_actor In-Reply-To: <20180629144444.28826-1-agruenba@redhat.com> References: <20180615130209.1970-2-hch@lst.de> <20180629144444.28826-1-agruenba@redhat.com> Message-ID: <20180701062141.GA27281@lst.de> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Looks sensible, although I think it could use some more sanity checking and a changelog. Does the version below work for you? --- >From e4603b7acde9b77e7a4aad6038c7ac42ca35772d Mon Sep 17 00:00:00 2001 From: Andreas Gruenbacher Date: Fri, 29 Jun 2018 16:44:44 +0200 Subject: iomap: Add inline data support to iomap_readpage_actor Just copy the inline data into the page using the existing helper. Signed-off-by: Andreas Gruenbacher Signed-off-by: Christoph Hellwig --- fs/iomap.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/fs/iomap.c b/fs/iomap.c index 4d8ff0f5ecc9..966ffad9706a 100644 --- a/fs/iomap.c +++ b/fs/iomap.c @@ -155,6 +155,13 @@ iomap_readpage_actor(struct inode *inode, loff_t pos, loff_t length, void *data, bool is_contig = false; sector_t sector; + if (iomap->type == IOMAP_INLINE) { + WARN_ON_ONCE(poff); + WARN_ON_ONCE(plen != PAGE_SIZE); + iomap_read_inline_data(inode, page, iomap); + return PAGE_SIZE; + } + /* we don't support blocksize < PAGE_SIZE quite yet. */ WARN_ON_ONCE(pos != page_offset(page)); WARN_ON_ONCE(plen != PAGE_SIZE); -- 2.18.0