From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0D42C6778C for ; Wed, 4 Jul 2018 13:40:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 346C523CAF for ; Wed, 4 Jul 2018 13:40:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 346C523CAF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=davemloft.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932646AbeGDNkn (ORCPT ); Wed, 4 Jul 2018 09:40:43 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:37256 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932328AbeGDNkk (ORCPT ); Wed, 4 Jul 2018 09:40:40 -0400 Received: from localhost (unknown [211.196.191.92]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 6D16D1094D773; Wed, 4 Jul 2018 06:40:39 -0700 (PDT) Date: Wed, 04 Jul 2018 22:40:38 +0900 (KST) Message-Id: <20180704.224038.1110290834924254400.davem@davemloft.net> To: colin.king@canonical.com Cc: christophe.jaillet@wanadoo.fr, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] cnic: remove redundant pointer req and variable func From: David Miller In-Reply-To: <20180704073912.15598-1-colin.king@canonical.com> References: <20180704073912.15598-1-colin.king@canonical.com> X-Mailer: Mew version 6.7 on Emacs 26 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 04 Jul 2018 06:40:40 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin King Date: Wed, 4 Jul 2018 08:39:12 +0100 > From: Colin Ian King > > Pointer req and variable func are being assigned but are never used > hence they are redundant and can be removed. > > Cleans up clang warnings: > warning: variable 'req' set but not used [-Wunused-but-set-variable] > warning: variable 'func' set but not used [-Wunused-but-set-variable] > > Signed-off-by: Colin Ian King Applied. From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Date: Wed, 04 Jul 2018 13:40:38 +0000 Subject: Re: [PATCH] cnic: remove redundant pointer req and variable func Message-Id: <20180704.224038.1110290834924254400.davem@davemloft.net> List-Id: References: <20180704073912.15598-1-colin.king@canonical.com> In-Reply-To: <20180704073912.15598-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: colin.king@canonical.com Cc: christophe.jaillet@wanadoo.fr, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org From: Colin King Date: Wed, 4 Jul 2018 08:39:12 +0100 > From: Colin Ian King > > Pointer req and variable func are being assigned but are never used > hence they are redundant and can be removed. > > Cleans up clang warnings: > warning: variable 'req' set but not used [-Wunused-but-set-variable] > warning: variable 'func' set but not used [-Wunused-but-set-variable] > > Signed-off-by: Colin Ian King Applied.