All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: Eric Blake <eblake@redhat.com>
Cc: Sebastian Bauer <mail@sebastianbauer.info>,
	BALATON Zoltan <balaton@eik.bme.hu>,
	qemu-devel@nongnu.org, thuth@redhat.com, qemu-ppc@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] ppc: Include vga cirrus card into the compiling process
Date: Wed, 4 Jul 2018 11:30:54 +1000	[thread overview]
Message-ID: <20180704013054.GC14043@umbus.fritz.box> (raw)
In-Reply-To: <dbac814a-62bd-d46a-8d7c-b070cc307c87@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 1016 bytes --]

On Tue, Jul 03, 2018 at 10:20:41AM -0500, Eric Blake wrote:
> On 07/02/2018 11:41 PM, David Gibson wrote:
> 
> > That's a good point.  At the moment there's really nothing there about
> > testing your patch before submission, which is a bit of an ommission.
> > 
> > [1] covers a bunch of ways that qemu can be tested, but doesn't give
> > much idea about priority.
> > 
> > +eblake, you seem to have made more mods than anyone else to the
> > SubmitAPatch wiki page.  What do you think about adding a subsection
> > about what basic testing you should do before posting a patch?
> 
> No good deed goes unpunished :)

Heh.  I was just asking if you had any input, not requesting that you
make the change..

> I've added https://wiki.qemu.org/Contribute/SubmitAPatch#Test_your_patches

..but thanks!

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2018-07-04  1:43 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-18 21:56 [Qemu-devel] [PATCH] ppc: Include vga cirrus card into the compiling process Sebastian Bauer
2018-06-18 23:55 ` David Gibson
2018-06-19  4:32   ` Sebastian Bauer
2018-06-19  4:36     ` David Gibson
2018-06-19 10:23       ` [Qemu-devel] [Qemu-ppc] " BALATON Zoltan
2018-06-19 10:46         ` Sebastian Bauer
2018-06-19 10:56           ` Thomas Huth
2018-06-19 10:57         ` Thomas Huth
2018-06-19 19:38       ` [Qemu-devel] " Sebastian Bauer
2018-06-29 18:06       ` Sebastian Bauer
2018-06-30  6:14         ` David Gibson
2018-06-30 11:29           ` BALATON Zoltan
2018-07-02  4:02             ` David Gibson
2018-07-02  5:22               ` David Gibson
2018-07-02  7:42                 ` Sebastian Bauer
2018-07-03  4:41                   ` David Gibson
2018-07-03 15:20                     ` Eric Blake
2018-07-04  1:30                       ` David Gibson [this message]
2018-06-19  5:24   ` Thomas Huth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180704013054.GC14043@umbus.fritz.box \
    --to=david@gibson.dropbear.id.au \
    --cc=balaton@eik.bme.hu \
    --cc=eblake@redhat.com \
    --cc=mail@sebastianbauer.info \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.