From: Pavel Machek <pavel@ucw.cz>
To: Andreas Klinger <ak@it-klinger.de>
Cc: jacek.anaszewski@gmail.com, ben.whitten@gmail.com,
geert+renesas@glider.be, w@1wt.eu, pombredanne@nexb.com,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
linux-leds@vger.kernel.org
Subject: Re: [PATCH v2] leds: ledtrig-morse: send out morse code
Date: Wed, 4 Jul 2018 08:53:05 +0200 [thread overview]
Message-ID: <20180704065305.GA23509@amd> (raw)
In-Reply-To: <20180703155328.GA18299@arbeit>
[-- Attachment #1: Type: text/plain, Size: 944 bytes --]
On Tue 2018-07-03 17:53:28, Andreas Klinger wrote:
> Send out a morse code by using LEDs.
>
> This is useful especially on embedded systems without displays to tell the
> user about error conditions and status information.
>
> The trigger will be called "morse"
>
> The string to be send is written into the file morse_string and sent out
> with a workqueue. Supported are letters and digits.
>
> With the file dot_unit the minimal time unit can be adjusted in
> milliseconds.
>
> Also add documentation for the morse led trigger
>
> Thanks to Greg and Geert for suggesting improvements
>
> Signed-off-by: Andreas Klinger <ak@it-klinger.de>
As I stated before, I don't think morse encoder belongs in kernel.
LED pattern trigger should be merged, instead.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2018-07-04 6:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-03 15:53 [PATCH v2] leds: ledtrig-morse: send out morse code Andreas Klinger
2018-07-03 18:43 ` Andy Shevchenko
2018-07-04 2:41 ` Willy Tarreau
2018-07-04 7:46 ` Geert Uytterhoeven
2018-07-04 16:25 ` Andy Shevchenko
2018-07-06 7:22 ` Geert Uytterhoeven
2018-07-04 6:53 ` Pavel Machek [this message]
2018-07-04 7:34 ` Willy Tarreau
2018-07-04 11:36 ` Greg KH
2018-07-04 18:19 ` Pavel Machek
2018-07-04 20:36 ` Jacek Anaszewski
2018-07-05 10:56 ` David Laight
2018-07-04 20:36 ` Jacek Anaszewski
2018-07-04 21:21 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180704065305.GA23509@amd \
--to=pavel@ucw.cz \
--cc=ak@it-klinger.de \
--cc=ben.whitten@gmail.com \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pombredanne@nexb.com \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.