From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vladimir Zapolskiy Subject: [PATCH v2 03/14] sh_eth: simplify link auto-negotiation by ethtool Date: Wed, 4 Jul 2018 11:12:41 +0300 Message-ID: <20180704081245.7395-4-vladimir_zapolskiy@mentor.com> References: <20180704081245.7395-1-vladimir_zapolskiy@mentor.com> Mime-Version: 1.0 Content-Type: text/plain Cc: Andrew Lunn , Geert Uytterhoeven , , To: Sergei Shtylyov , "David S . Miller" Return-path: Received: from relay1.mentorg.com ([192.94.38.131]:42618 "EHLO relay1.mentorg.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932517AbeGDINH (ORCPT ); Wed, 4 Jul 2018 04:13:07 -0400 In-Reply-To: <20180704081245.7395-1-vladimir_zapolskiy@mentor.com> Sender: netdev-owner@vger.kernel.org List-ID: There is no need to call a heavyweight phy_start_aneg() for phy auto-negotiation by ethtool, the phy is already initialized and link auto-negotiation is started by calling phy_start() from sh_eth_phy_start() when a network device is opened. Signed-off-by: Vladimir Zapolskiy --- drivers/net/ethernet/renesas/sh_eth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c index 8e429e865552..1bed2ee4d709 100644 --- a/drivers/net/ethernet/renesas/sh_eth.c +++ b/drivers/net/ethernet/renesas/sh_eth.c @@ -2249,7 +2249,7 @@ static int sh_eth_nway_reset(struct net_device *ndev) if (!ndev->phydev) return -ENODEV; - return phy_start_aneg(ndev->phydev); + return phy_restart_aneg(ndev->phydev); } static u32 sh_eth_get_msglevel(struct net_device *ndev) -- 2.17.1