From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vladimir Zapolskiy Subject: [PATCH v2 05/14] sh_eth: remove useless serialization in sh_eth_get_link_ksettings() Date: Wed, 4 Jul 2018 11:14:47 +0300 Message-ID: <20180704081451.7482-1-vladimir_zapolskiy@mentor.com> References: <20180704081245.7395-1-vladimir_zapolskiy@mentor.com> Mime-Version: 1.0 Content-Type: text/plain Cc: Andrew Lunn , Geert Uytterhoeven , , To: Sergei Shtylyov , "David S . Miller" Return-path: Received: from relay1.mentorg.com ([192.94.38.131]:42805 "EHLO relay1.mentorg.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932290AbeGDIPT (ORCPT ); Wed, 4 Jul 2018 04:15:19 -0400 In-Reply-To: <20180704081245.7395-1-vladimir_zapolskiy@mentor.com> Sender: netdev-owner@vger.kernel.org List-ID: phy_ethtool_ksettings_get() call does not modify device state or device driver state, hence there is no need to utilize a driver specific spinlock. Signed-off-by: Vladimir Zapolskiy --- drivers/net/ethernet/renesas/sh_eth.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c index 50ff18870be2..152edd1e9a23 100644 --- a/drivers/net/ethernet/renesas/sh_eth.c +++ b/drivers/net/ethernet/renesas/sh_eth.c @@ -2043,15 +2043,10 @@ static int sh_eth_phy_start(struct net_device *ndev) static int sh_eth_get_link_ksettings(struct net_device *ndev, struct ethtool_link_ksettings *cmd) { - struct sh_eth_private *mdp = netdev_priv(ndev); - unsigned long flags; - if (!ndev->phydev) return -ENODEV; - spin_lock_irqsave(&mdp->lock, flags); phy_ethtool_ksettings_get(ndev->phydev, cmd); - spin_unlock_irqrestore(&mdp->lock, flags); return 0; } -- 2.17.1