From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH -next 05/15] drm/vmwgfx: Fix atomic mode set check Date: Wed, 4 Jul 2018 10:35:56 +0200 Message-ID: <20180704083556.GN3891@phenom.ffwll.local> References: <20180703191500.2374-1-thellstrom@vmware.com> <20180703191500.2374-6-thellstrom@vmware.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ed1-x543.google.com (mail-ed1-x543.google.com [IPv6:2a00:1450:4864:20::543]) by gabe.freedesktop.org (Postfix) with ESMTPS id 73B9A6EADB for ; Wed, 4 Jul 2018 08:36:00 +0000 (UTC) Received: by mail-ed1-x543.google.com with SMTP id v22-v6so3458941edq.4 for ; Wed, 04 Jul 2018 01:36:00 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20180703191500.2374-6-thellstrom@vmware.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Thomas Hellstrom Cc: linux-graphics-maintainer@vmware.com, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBKdWwgMDMsIDIwMTggYXQgMDk6MTQ6NTBQTSArMDIwMCwgVGhvbWFzIEhlbGxzdHJv bSB3cm90ZToKPiBGcm9tOiBTaW5jbGFpciBZZWggPHN5ZWhAdm13YXJlLmNvbT4KPiAKPiB2bXdf a21zX2F0b21pY19jaGVja19tb2Rlc2V0KCkgaXMgY3VycmVudGx5IGNoZWNraW5nIGNvbmZpZyB1 c2luZyB0aGUKPiBsZWdhY3kgc3RhdGUsIHdoaWNoIGlzIHVwZGF0ZWQgYWZ0ZXIgYSBjb21taXQg aGFzIGhhcHBlbmVkLgo+IAo+IFRoaXMgbWVhbnMgdm13X2ttc19hdG9taWNfY2hlY2tfbW9kZXNl dCgpIHdpbGwgcmVqZWN0IGFuIGludmFsaWQgY29uZmlnCj4gb24gdGhlIG5leHQgdXBkYXRlIHJh dGhlciB0aGFuIHRoZSBjdXJyZW50IG9uZS4KPiAKPiBGaXggdGhpcyBieSB1c2luZyB0aGUgbmV3 IHN0YXRlcyBmb3IgY29uZmlnIGNoZWNraW5nCj4gCj4gU2lnbmVkLW9mZi1ieTogU2luY2xhaXIg WWVoIDxzeWVoQHZtd2FyZS5jb20+Cj4gUmV2aWV3ZWQtYnk6IERlZXBhayBSYXdhdCA8ZHJhd2F0 QHZtd2FyZS5jb20+Cj4gU2lnbmVkLW9mZi1ieTogVGhvbWFzIEhlbGxzdHJvbSA8dGhlbGxzdHJv bUB2bXdhcmUuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vdm13Z2Z4L3Ztd2dmeF9rbXMu YyB8IDQwICsrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAy NiBpbnNlcnRpb25zKCspLCAxNCBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy9ncHUvZHJtL3Ztd2dmeC92bXdnZnhfa21zLmMgYi9kcml2ZXJzL2dwdS9kcm0vdm13Z2Z4L3Zt d2dmeF9rbXMuYwo+IGluZGV4IGU3YTdhMmU3M2JiZi4uNmI4NTQxZjkyMTVkIDEwMDY0NAo+IC0t LSBhL2RyaXZlcnMvZ3B1L2RybS92bXdnZngvdm13Z2Z4X2ttcy5jCj4gKysrIGIvZHJpdmVycy9n cHUvZHJtL3Ztd2dmeC92bXdnZnhfa21zLmMKPiBAQCAtMTUyNiwzMyArMTUyNiw0NSBAQCBzdGF0 aWMgaW50Cj4gIHZtd19rbXNfYXRvbWljX2NoZWNrX21vZGVzZXQoc3RydWN0IGRybV9kZXZpY2Ug KmRldiwKPiAgCQkJICAgICBzdHJ1Y3QgZHJtX2F0b21pY19zdGF0ZSAqc3RhdGUpCj4gIHsKPiAt CXN0cnVjdCBkcm1fY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZTsKPiArCXN0cnVjdCBkcm1fY3J0Y19z dGF0ZSAqbmV3X2NydGNfc3RhdGU7Cj4gKwlzdHJ1Y3QgZHJtX3BsYW5lX3N0YXRlICpuZXdfcGxh bmVfc3RhdGU7Cj4gKwlzdHJ1Y3QgZHJtX3BsYW5lICpwbGFuZTsKPiAgCXN0cnVjdCBkcm1fY3J0 YyAqY3J0YzsKPiAgCXN0cnVjdCB2bXdfcHJpdmF0ZSAqZGV2X3ByaXYgPSB2bXdfcHJpdihkZXYp Owo+IC0JaW50IGk7Cj4gKwlpbnQgaSwgcmV0LCBjcHAgPSAwOwo+ICAKPiAtCWZvcl9lYWNoX25l d19jcnRjX2luX3N0YXRlKHN0YXRlLCBjcnRjLCBjcnRjX3N0YXRlLCBpKSB7Cj4gLQkJdW5zaWdu ZWQgbG9uZyByZXF1ZXN0ZWRfYmJfbWVtID0gMDsKPiArCXJldCA9IGRybV9hdG9taWNfaGVscGVy X2NoZWNrKGRldiwgc3RhdGUpOwo+ICAKPiAtCQlpZiAoZGV2X3ByaXYtPmFjdGl2ZV9kaXNwbGF5 X3VuaXQgPT0gdm13X2R1X3NjcmVlbl90YXJnZXQpIHsKPiAtCQkJc3RydWN0IGRybV9wbGFuZSAq cGxhbmUgPSBjcnRjLT5wcmltYXJ5Owo+IC0JCQlzdHJ1Y3QgZHJtX3BsYW5lX3N0YXRlICpwbGFu ZV9zdGF0ZTsKPiArCS8qIElmIHRoaXMgaXMgbm90IGEgU1REVSwgdGhlbiBubyBtb3JlIGNoZWNr aW5nIGlzIG5lY2Vzc2FyeSAqLwo+ICsJaWYgKHJldCB8fCBkZXZfcHJpdi0+YWN0aXZlX2Rpc3Bs YXlfdW5pdCAhPSB2bXdfZHVfc2NyZWVuX3RhcmdldCkKPiArCQlyZXR1cm4gcmV0Owo+ICAKPiAt CQkJcGxhbmVfc3RhdGUgPSBkcm1fYXRvbWljX2dldF9uZXdfcGxhbmVfc3RhdGUoc3RhdGUsIHBs YW5lKTsKPiArCWZvcl9lYWNoX25ld19wbGFuZV9pbl9zdGF0ZShzdGF0ZSwgcGxhbmUsIG5ld19w bGFuZV9zdGF0ZSwgaSkgewo+ICsJCWlmIChuZXdfcGxhbmVfc3RhdGUtPmZiKSB7Cj4gKwkJCWlu dCBjdXJyZW50X2NwcCA9IG5ld19wbGFuZV9zdGF0ZS0+ZmItPnBpdGNoZXNbMF0gLwo+ICsJCQkJ CSAgbmV3X3BsYW5lX3N0YXRlLT5mYi0+d2lkdGg7Cj4gIAo+IC0JCQlpZiAocGxhbmVfc3RhdGUg JiYgcGxhbmVfc3RhdGUtPmZiKSB7Cj4gLQkJCQlpbnQgY3BwID0gcGxhbmVfc3RhdGUtPmZiLT5m b3JtYXQtPmNwcFswXTsKPiArCQkJaWYgKGNwcCA9PSAwKQo+ICsJCQkJY3BwID0gY3VycmVudF9j cHA7Cj4gKwkJCWVsc2UgaWYgKGN1cnJlbnRfY3BwICE9IGNwcCkKPiArCQkJCXJldHVybiAtRUlO VkFMOwo+ICsJCX0KPiArCX0KPiAgCj4gLQkJCQlyZXF1ZXN0ZWRfYmJfbWVtICs9IGNydGMtPm1v ZGUuaGRpc3BsYXkgKiBjcHAgKgo+IC0JCQkJCQkgICAgY3J0Yy0+bW9kZS52ZGlzcGxheTsKPiAt CQkJfQo+ICsJZm9yX2VhY2hfbmV3X2NydGNfaW5fc3RhdGUoc3RhdGUsIGNydGMsIG5ld19jcnRj X3N0YXRlLCBpKSB7CgpOb3RlIHRoYXQgdGhlIGFib3ZlIHRvbyBsb29wcyBvbmx5IHdhbGsgb3Zl ciB0aGUgY2hhbmdlZCBzdGF0ZXMgKGJ5CmRlZmF1bHQpLCBub3QgYWxsIHBsYW5lcy9jcnRjLiBZ b3UgZWl0aGVyIG5lZWQgdG8gYWRkIHRoZW0geW91cnNlbGYgKHdoaWNoCmtpbmRhIGRlZmVhdHMg dGhlIHBvaW50IG9mIHRoZSBwZXItcGxhbmUvY3J0YyBsb2NrcyBmb3IgZG9pbmcgcGFnZWZsaXBz IGluCnBhcmFsbGVsKS4gT3IgeW91IG5lZWQgdG8gdHJhY2sgdGhpbmdzIGluIGEgZHJpdmVyIHBy aXZhdGUgc3RydWN0dXJlCih3aGljaCB5b3UnbGwgb25seSBncmFiIG9uIG1vZGVzZXRzKSBhbmQg anVzdCB1cGRhdGUgdGhlIGRlbHRhLgoKSSBkaWRuJ3QgY2hlY2sgdGhlIGVudGlyZSBjb2RlIHRv IHNlZSB3aGV0aGVyIHRoaXMgaXMgYSByZWFsIHByb2JsZW0gZm9yCnlvdSwganVzdCB3YW50ZWQg dG8gcG9pbnQgdGhpcyBvdXQuCi1EYW5pZWwKCj4gKwkJdW5zaWduZWQgbG9uZyByZXF1ZXN0ZWRf YmJfbWVtID0gMDsKPiArCj4gKwkJaWYgKGRybV9hdG9taWNfY3J0Y19uZWVkc19tb2Rlc2V0KG5l d19jcnRjX3N0YXRlKSkgewo+ICsJCQlyZXF1ZXN0ZWRfYmJfbWVtICs9IG5ld19jcnRjX3N0YXRl LT5tb2RlLmhkaXNwbGF5ICoKPiArCQkJCQkgICAgbmV3X2NydGNfc3RhdGUtPm1vZGUudmRpc3Bs YXkgKgo+ICsJCQkJCSAgICBjcHA7Cj4gIAo+ICAJCQlpZiAocmVxdWVzdGVkX2JiX21lbSA+IGRl dl9wcml2LT5wcmltX2JiX21lbSkKPiAgCQkJCXJldHVybiAtRUlOVkFMOwo+ICAJCX0KPiAgCX0K PiAgCj4gLQlyZXR1cm4gZHJtX2F0b21pY19oZWxwZXJfY2hlY2soZGV2LCBzdGF0ZSk7Cj4gKwly ZXR1cm4gcmV0Owo+ICB9Cj4gIAo+ICBzdGF0aWMgY29uc3Qgc3RydWN0IGRybV9tb2RlX2NvbmZp Z19mdW5jcyB2bXdfa21zX2Z1bmNzID0gewo+IC0tIAo+IDIuMTguMC5yYzEKPiAKPiBfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IGRyaS1kZXZlbCBtYWls aW5nIGxpc3QKPiBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwKCi0tIApEYW5pZWwg VmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgpodHRwOi8vYmxvZy5m ZndsbC5jaApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpk cmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK