From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [-next] dmaengine: fsl-edma: fix the error return code in mcf_edma_probe() From: Angelo Dureghello Message-Id: <20180704090445.GD9939@jerusalem> Date: Wed, 4 Jul 2018 11:04:46 +0200 To: Wei Yongjun Cc: Vinod Koul , Dan Williams , dmaengine@vger.kernel.org, kernel-janitors@vger.kernel.org List-ID: UmV2aWV3ZWQtYnk6IEFuZ2VsbyBEdXJlZ2hlbGxvIDxhbmdlbG9Ac3lzYW0uaXQ+CgpUaGFua3Mg Zm9yIHRoZSBmaXguCgpPbiBXZWQsIEp1bCAwNCwgMjAxOCBhdCAwODoyMTo1MUFNICswMDAwLCBX ZWkgWW9uZ2p1biB3cm90ZToKPiBUaGUgZXJyb3IgcmV0dXJuIGNvZGUgUFRSX0VSUihwZGF0YSkg aXMgYWx3YXlzIDAgc2luY2UgcGRhdGEgaXMKPiBOVUxMIGluIHRoaXMgZXJyb3IgaGFuZGxpbmcg Y2FzZS4KPiAKPiBGaXhlczogNWMxMzU1YWQ4N2EyICgiZG1hZW5naW5lOiBmc2wtZWRtYTogYWRk IENvbGRGaXJlIG1jZjU0NDF4IGVkbWEgc3VwcG9ydCIpCj4gU2lnbmVkLW9mZi1ieTogV2VpIFlv bmdqdW4gPHdlaXlvbmdqdW4xQGh1YXdlaS5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZG1hL21jZi1l ZG1hLmMgfCAyICstCj4gIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlv bigtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2RtYS9tY2YtZWRtYS5jIGIvZHJpdmVycy9k bWEvbWNmLWVkbWEuYwo+IGluZGV4IDMxZTUzMTcuLjc4N2I3YjYgMTAwNjQ0Cj4gLS0tIGEvZHJp dmVycy9kbWEvbWNmLWVkbWEuYwo+ICsrKyBiL2RyaXZlcnMvZG1hL21jZi1lZG1hLmMKPiBAQCAt MTc1LDcgKzE3NSw3IEBAIHN0YXRpYyBpbnQgbWNmX2VkbWFfcHJvYmUoc3RydWN0IHBsYXRmb3Jt X2RldmljZSAqcGRldikKPiAgCj4gIAlwZGF0YSA9IGRldl9nZXRfcGxhdGRhdGEoJnBkZXYtPmRl dik7Cj4gIAlpZiAoIXBkYXRhKQo+IC0JCXJldHVybiBQVFJfRVJSKHBkYXRhKTsKPiArCQlyZXR1 cm4gLUVJTlZBTDsKPiAgCj4gIAljaGFucyA9IHBkYXRhLT5kbWFfY2hhbm5lbHM7Cj4gIAlsZW4g PSBzaXplb2YoKm1jZl9lZG1hKSArIHNpemVvZigqbWNmX2NoYW4pICogY2hhbnM7Cj4gCj4gLS0K PiBUbyB1bnN1YnNjcmliZSBmcm9tIHRoaXMgbGlzdDogc2VuZCB0aGUgbGluZSAidW5zdWJzY3Jp YmUgZG1hZW5naW5lIiBpbgo+IHRoZSBib2R5IG9mIGEgbWVzc2FnZSB0byBtYWpvcmRvbW9Admdl ci5rZXJuZWwub3JnCj4gTW9yZSBtYWpvcmRvbW8gaW5mbyBhdCAgaHR0cDovL3ZnZXIua2VybmVs Lm9yZy9tYWpvcmRvbW8taW5mby5odG1sCi0tLQpUbyB1bnN1YnNjcmliZSBmcm9tIHRoaXMgbGlz dDogc2VuZCB0aGUgbGluZSAidW5zdWJzY3JpYmUgZG1hZW5naW5lIiBpbgp0aGUgYm9keSBvZiBh IG1lc3NhZ2UgdG8gbWFqb3Jkb21vQHZnZXIua2VybmVsLm9yZwpNb3JlIG1ham9yZG9tbyBpbmZv IGF0ICBodHRwOi8vdmdlci5rZXJuZWwub3JnL21ham9yZG9tby1pbmZvLmh0bWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: Angelo Dureghello Date: Wed, 04 Jul 2018 09:04:46 +0000 Subject: Re: [PATCH -next] dmaengine: fsl-edma: fix the error return code in mcf_edma_probe() Message-Id: <20180704090445.GD9939@jerusalem> List-Id: References: <1530692511-191869-1-git-send-email-weiyongjun1@huawei.com> In-Reply-To: <1530692511-191869-1-git-send-email-weiyongjun1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Wei Yongjun Cc: Vinod Koul , Dan Williams , dmaengine@vger.kernel.org, kernel-janitors@vger.kernel.org Reviewed-by: Angelo Dureghello Thanks for the fix. On Wed, Jul 04, 2018 at 08:21:51AM +0000, Wei Yongjun wrote: > The error return code PTR_ERR(pdata) is always 0 since pdata is > NULL in this error handling case. > > Fixes: 5c1355ad87a2 ("dmaengine: fsl-edma: add ColdFire mcf5441x edma support") > Signed-off-by: Wei Yongjun > --- > drivers/dma/mcf-edma.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/dma/mcf-edma.c b/drivers/dma/mcf-edma.c > index 31e5317..787b7b6 100644 > --- a/drivers/dma/mcf-edma.c > +++ b/drivers/dma/mcf-edma.c > @@ -175,7 +175,7 @@ static int mcf_edma_probe(struct platform_device *pdev) > > pdata = dev_get_platdata(&pdev->dev); > if (!pdata) > - return PTR_ERR(pdata); > + return -EINVAL; > > chans = pdata->dma_channels; > len = sizeof(*mcf_edma) + sizeof(*mcf_chan) * chans; > > -- > To unsubscribe from this list: send the line "unsubscribe dmaengine" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html