From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC4B8C6778C for ; Wed, 4 Jul 2018 07:11:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 86B5223DE1 for ; Wed, 4 Jul 2018 07:11:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 86B5223DE1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932513AbeGDHLX (ORCPT ); Wed, 4 Jul 2018 03:11:23 -0400 Received: from mail.bootlin.com ([62.4.15.54]:35473 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932319AbeGDHJz (ORCPT ); Wed, 4 Jul 2018 03:09:55 -0400 Received: by mail.bootlin.com (Postfix, from userid 110) id 2CB7F20741; Wed, 4 Jul 2018 09:09:53 +0200 (CEST) Received: from bbrezillon (AAubervilliers-681-1-39-106.w90-88.abo.wanadoo.fr [90.88.158.106]) by mail.bootlin.com (Postfix) with ESMTPSA id 909092069C; Wed, 4 Jul 2018 09:09:42 +0200 (CEST) Date: Wed, 4 Jul 2018 09:09:42 +0200 From: Boris Brezillon To: Miquel Raynal Cc: Wenyou Yang , Josh Wu , Tudor Ambarus , Richard Weinberger , David Woodhouse , Brian Norris , Marek Vasut , Nicolas Ferre , Alexandre Belloni , Kamal Dasu , Masahiro Yamada , Han Xu , Harvey Hunt , Vladimir Zapolskiy , Sylvain Lemieux , Xiaolei Li , Matthias Brugger , Maxime Ripard , Chen-Yu Tsai , Marc Gonzalez , Mans Rullgard , Stefan Agner , linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linux-mediatek@lists.infradead.org Subject: Re: [PATCH v2 01/32] mtd: rawnand: add hooks that may be called during nand_scan() Message-ID: <20180704090942.24a17db1@bbrezillon> In-Reply-To: <20180703220029.19565-2-miquel.raynal@bootlin.com> References: <20180703220029.19565-1-miquel.raynal@bootlin.com> <20180703220029.19565-2-miquel.raynal@bootlin.com> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Miquel, On Tue, 3 Jul 2018 23:59:58 +0200 Miquel Raynal wrote: > In order to remove the limitation that forbids dynamic allocation in > nand_scan_ident(), we must create a path that will be the same for all > controller drivers. The idea is to use nand_scan() instead of the widely > implemented nand_scan_ident()/nand_scan_tail() couple. In order to > achieve this, controller drivers will need to adjust some parameters > between these two functions depending on the NAND chip wired on them. > > For that, a hook called ->attach_chip() is created in the > nand_hw_control structure. This structure may be referenced by two ways: > 1/ if the driver does not implement its own controller, the > chip->controller hook is not populated before nand_scan() so it > cannot be dereferenced: use chip->hwcontrol instead (which is > statically allocated and will be referenced later by chip->controller > anyway). > 2/ through chip->controller if the driver implements its own controller. > > Another hook, ->detach_chip() is also introduced in order to clean the > controller driver's potential allocations in case of failure of > nand_scan_tail(). There is no need for the controller driver to call the > ->detach_chip() hook directly upon error after a successful nand_scan(). > In this situation, calling nand_release() as before is enough. > > Signed-off-by: Miquel Raynal > --- > drivers/mtd/nand/raw/nand_base.c | 21 +++++++++++++++++++-- > include/linux/mtd/rawnand.h | 6 ++++++ > 2 files changed, 25 insertions(+), 2 deletions(-) > > diff --git a/drivers/mtd/nand/raw/nand_base.c b/drivers/mtd/nand/raw/nand_base.c > index faac82b1e058..97a74d48b0cf 100644 > --- a/drivers/mtd/nand/raw/nand_base.c > +++ b/drivers/mtd/nand/raw/nand_base.c > @@ -6712,11 +6712,23 @@ EXPORT_SYMBOL(nand_scan_tail); > int nand_scan_with_ids(struct mtd_info *mtd, int maxchips, > struct nand_flash_dev *ids) > { > + struct nand_chip *chip = mtd_to_nand(mtd); > int ret; > > ret = nand_scan_ident(mtd, maxchips, ids); > - if (!ret) > - ret = nand_scan_tail(mtd); > + if (ret) > + return ret; > + > + if (chip->controller->attach_chip) { > + ret = chip->controller->attach_chip(chip); > + if (ret) > + return ret; > + } > + > + ret = nand_scan_tail(mtd); > + if (ret && chip->controller->detach_chip) > + chip->controller->detach_chip(chip); > + > return ret; > } > EXPORT_SYMBOL(nand_scan_with_ids); > @@ -6744,7 +6756,12 @@ void nand_cleanup(struct nand_chip *chip) > > /* Free manufacturer priv data. */ > nand_manufacturer_cleanup(chip); > + > + /* Free controller specific allocations after chip identification */ > + if (chip->controller->detach_chip) > + chip->controller->detach_chip(chip); > } > + > EXPORT_SYMBOL_GPL(nand_cleanup); > > /** > diff --git a/include/linux/mtd/rawnand.h b/include/linux/mtd/rawnand.h > index 0c6fb316b409..81654211e520 100644 > --- a/include/linux/mtd/rawnand.h > +++ b/include/linux/mtd/rawnand.h > @@ -517,11 +517,17 @@ struct nand_id { > * @wq: wait queue to sleep on if a NAND operation is in > * progress used instead of the per chip wait queue > * when a hw controller is available. > + * @attach_chip: Callback that may be called between nand_detect() and > + * nand_scan_tail() during nand_scan() (optional). > + * @detach_chip: Callback that may be called if nand_scan_tail() fails > + * (optional). > */ > struct nand_hw_control { > spinlock_t lock; > struct nand_chip *active; > wait_queue_head_t wq; > + int (*attach_chip)(struct nand_chip *chip); > + void (*detach_chip)(struct nand_chip *chip); > }; Can we instead declare a nand_controller_ops struct and then have nand_hw_control point to it. Something like: struct nand_controller_ops { int (*attach_chip)(struct nand_chip *chip); void (*detach_chip)(struct nand_chip *chip); }; struct nand_hw_control { ... const struct nand_controller_ops *ops; }; > > static inline void nand_hw_control_init(struct nand_hw_control *nfc) Regards, Boris From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Subject: Re: [PATCH v2 01/32] mtd: rawnand: add hooks that may be called during nand_scan() Date: Wed, 4 Jul 2018 09:09:42 +0200 Message-ID: <20180704090942.24a17db1@bbrezillon> References: <20180703220029.19565-1-miquel.raynal@bootlin.com> <20180703220029.19565-2-miquel.raynal@bootlin.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20180703220029.19565-2-miquel.raynal@bootlin.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Miquel Raynal Cc: Alexandre Belloni , Mans Rullgard , Maxime Ripard , Stefan Agner , linux-kernel@vger.kernel.org, Masahiro Yamada , linux-mtd@lists.infradead.org, Kamal Dasu , Josh Wu , Marc Gonzalez , Marek Vasut , Chen-Yu Tsai , bcm-kernel-feedback-list@broadcom.com, Sylvain Lemieux , Wenyou Yang , Tudor Ambarus , Vladimir Zapolskiy , Harvey Hunt , linux-mediatek@lists.infradead.org, Matthias Brugger , Han Xu , Xiaolei Li , linux-arm-kernel@lists.infradead.org, Richard List-Id: linux-mediatek@lists.infradead.org Hi Miquel, On Tue, 3 Jul 2018 23:59:58 +0200 Miquel Raynal wrote: > In order to remove the limitation that forbids dynamic allocation in > nand_scan_ident(), we must create a path that will be the same for all > controller drivers. The idea is to use nand_scan() instead of the widely > implemented nand_scan_ident()/nand_scan_tail() couple. In order to > achieve this, controller drivers will need to adjust some parameters > between these two functions depending on the NAND chip wired on them. > > For that, a hook called ->attach_chip() is created in the > nand_hw_control structure. This structure may be referenced by two ways: > 1/ if the driver does not implement its own controller, the > chip->controller hook is not populated before nand_scan() so it > cannot be dereferenced: use chip->hwcontrol instead (which is > statically allocated and will be referenced later by chip->controller > anyway). > 2/ through chip->controller if the driver implements its own controller. > > Another hook, ->detach_chip() is also introduced in order to clean the > controller driver's potential allocations in case of failure of > nand_scan_tail(). There is no need for the controller driver to call the > ->detach_chip() hook directly upon error after a successful nand_scan(). > In this situation, calling nand_release() as before is enough. > > Signed-off-by: Miquel Raynal > --- > drivers/mtd/nand/raw/nand_base.c | 21 +++++++++++++++++++-- > include/linux/mtd/rawnand.h | 6 ++++++ > 2 files changed, 25 insertions(+), 2 deletions(-) > > diff --git a/drivers/mtd/nand/raw/nand_base.c b/drivers/mtd/nand/raw/nand_base.c > index faac82b1e058..97a74d48b0cf 100644 > --- a/drivers/mtd/nand/raw/nand_base.c > +++ b/drivers/mtd/nand/raw/nand_base.c > @@ -6712,11 +6712,23 @@ EXPORT_SYMBOL(nand_scan_tail); > int nand_scan_with_ids(struct mtd_info *mtd, int maxchips, > struct nand_flash_dev *ids) > { > + struct nand_chip *chip = mtd_to_nand(mtd); > int ret; > > ret = nand_scan_ident(mtd, maxchips, ids); > - if (!ret) > - ret = nand_scan_tail(mtd); > + if (ret) > + return ret; > + > + if (chip->controller->attach_chip) { > + ret = chip->controller->attach_chip(chip); > + if (ret) > + return ret; > + } > + > + ret = nand_scan_tail(mtd); > + if (ret && chip->controller->detach_chip) > + chip->controller->detach_chip(chip); > + > return ret; > } > EXPORT_SYMBOL(nand_scan_with_ids); > @@ -6744,7 +6756,12 @@ void nand_cleanup(struct nand_chip *chip) > > /* Free manufacturer priv data. */ > nand_manufacturer_cleanup(chip); > + > + /* Free controller specific allocations after chip identification */ > + if (chip->controller->detach_chip) > + chip->controller->detach_chip(chip); > } > + > EXPORT_SYMBOL_GPL(nand_cleanup); > > /** > diff --git a/include/linux/mtd/rawnand.h b/include/linux/mtd/rawnand.h > index 0c6fb316b409..81654211e520 100644 > --- a/include/linux/mtd/rawnand.h > +++ b/include/linux/mtd/rawnand.h > @@ -517,11 +517,17 @@ struct nand_id { > * @wq: wait queue to sleep on if a NAND operation is in > * progress used instead of the per chip wait queue > * when a hw controller is available. > + * @attach_chip: Callback that may be called between nand_detect() and > + * nand_scan_tail() during nand_scan() (optional). > + * @detach_chip: Callback that may be called if nand_scan_tail() fails > + * (optional). > */ > struct nand_hw_control { > spinlock_t lock; > struct nand_chip *active; > wait_queue_head_t wq; > + int (*attach_chip)(struct nand_chip *chip); > + void (*detach_chip)(struct nand_chip *chip); > }; Can we instead declare a nand_controller_ops struct and then have nand_hw_control point to it. Something like: struct nand_controller_ops { int (*attach_chip)(struct nand_chip *chip); void (*detach_chip)(struct nand_chip *chip); }; struct nand_hw_control { ... const struct nand_controller_ops *ops; }; > > static inline void nand_hw_control_init(struct nand_hw_control *nfc) Regards, Boris From mboxrd@z Thu Jan 1 00:00:00 1970 From: boris.brezillon@bootlin.com (Boris Brezillon) Date: Wed, 4 Jul 2018 09:09:42 +0200 Subject: [PATCH v2 01/32] mtd: rawnand: add hooks that may be called during nand_scan() In-Reply-To: <20180703220029.19565-2-miquel.raynal@bootlin.com> References: <20180703220029.19565-1-miquel.raynal@bootlin.com> <20180703220029.19565-2-miquel.raynal@bootlin.com> Message-ID: <20180704090942.24a17db1@bbrezillon> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Miquel, On Tue, 3 Jul 2018 23:59:58 +0200 Miquel Raynal wrote: > In order to remove the limitation that forbids dynamic allocation in > nand_scan_ident(), we must create a path that will be the same for all > controller drivers. The idea is to use nand_scan() instead of the widely > implemented nand_scan_ident()/nand_scan_tail() couple. In order to > achieve this, controller drivers will need to adjust some parameters > between these two functions depending on the NAND chip wired on them. > > For that, a hook called ->attach_chip() is created in the > nand_hw_control structure. This structure may be referenced by two ways: > 1/ if the driver does not implement its own controller, the > chip->controller hook is not populated before nand_scan() so it > cannot be dereferenced: use chip->hwcontrol instead (which is > statically allocated and will be referenced later by chip->controller > anyway). > 2/ through chip->controller if the driver implements its own controller. > > Another hook, ->detach_chip() is also introduced in order to clean the > controller driver's potential allocations in case of failure of > nand_scan_tail(). There is no need for the controller driver to call the > ->detach_chip() hook directly upon error after a successful nand_scan(). > In this situation, calling nand_release() as before is enough. > > Signed-off-by: Miquel Raynal > --- > drivers/mtd/nand/raw/nand_base.c | 21 +++++++++++++++++++-- > include/linux/mtd/rawnand.h | 6 ++++++ > 2 files changed, 25 insertions(+), 2 deletions(-) > > diff --git a/drivers/mtd/nand/raw/nand_base.c b/drivers/mtd/nand/raw/nand_base.c > index faac82b1e058..97a74d48b0cf 100644 > --- a/drivers/mtd/nand/raw/nand_base.c > +++ b/drivers/mtd/nand/raw/nand_base.c > @@ -6712,11 +6712,23 @@ EXPORT_SYMBOL(nand_scan_tail); > int nand_scan_with_ids(struct mtd_info *mtd, int maxchips, > struct nand_flash_dev *ids) > { > + struct nand_chip *chip = mtd_to_nand(mtd); > int ret; > > ret = nand_scan_ident(mtd, maxchips, ids); > - if (!ret) > - ret = nand_scan_tail(mtd); > + if (ret) > + return ret; > + > + if (chip->controller->attach_chip) { > + ret = chip->controller->attach_chip(chip); > + if (ret) > + return ret; > + } > + > + ret = nand_scan_tail(mtd); > + if (ret && chip->controller->detach_chip) > + chip->controller->detach_chip(chip); > + > return ret; > } > EXPORT_SYMBOL(nand_scan_with_ids); > @@ -6744,7 +6756,12 @@ void nand_cleanup(struct nand_chip *chip) > > /* Free manufacturer priv data. */ > nand_manufacturer_cleanup(chip); > + > + /* Free controller specific allocations after chip identification */ > + if (chip->controller->detach_chip) > + chip->controller->detach_chip(chip); > } > + > EXPORT_SYMBOL_GPL(nand_cleanup); > > /** > diff --git a/include/linux/mtd/rawnand.h b/include/linux/mtd/rawnand.h > index 0c6fb316b409..81654211e520 100644 > --- a/include/linux/mtd/rawnand.h > +++ b/include/linux/mtd/rawnand.h > @@ -517,11 +517,17 @@ struct nand_id { > * @wq: wait queue to sleep on if a NAND operation is in > * progress used instead of the per chip wait queue > * when a hw controller is available. > + * @attach_chip: Callback that may be called between nand_detect() and > + * nand_scan_tail() during nand_scan() (optional). > + * @detach_chip: Callback that may be called if nand_scan_tail() fails > + * (optional). > */ > struct nand_hw_control { > spinlock_t lock; > struct nand_chip *active; > wait_queue_head_t wq; > + int (*attach_chip)(struct nand_chip *chip); > + void (*detach_chip)(struct nand_chip *chip); > }; Can we instead declare a nand_controller_ops struct and then have nand_hw_control point to it. Something like: struct nand_controller_ops { int (*attach_chip)(struct nand_chip *chip); void (*detach_chip)(struct nand_chip *chip); }; struct nand_hw_control { ... const struct nand_controller_ops *ops; }; > > static inline void nand_hw_control_init(struct nand_hw_control *nfc) Regards, Boris