From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5697DC3279B for ; Wed, 4 Jul 2018 12:10:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 058BE20847 for ; Wed, 4 Jul 2018 12:10:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linaro.org header.i=@linaro.org header.b="ErjKLl3+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 058BE20847 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934430AbeGDMKz (ORCPT ); Wed, 4 Jul 2018 08:10:55 -0400 Received: from mail-wr0-f194.google.com ([209.85.128.194]:38324 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933407AbeGDMKx (ORCPT ); Wed, 4 Jul 2018 08:10:53 -0400 Received: by mail-wr0-f194.google.com with SMTP id j33-v6so5104520wrj.5 for ; Wed, 04 Jul 2018 05:10:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=PtHGKOmeNRGf+C9+MfTwb0BYvxZqRL3+S1ZqRafqefY=; b=ErjKLl3+bdpM/At/BgiMHeXXbleEizIJ/R+0EQQzNPfHmUKxblfpv8fVerjwqpStyz SJbsnHh5VHoui/XRGOVVaBCYb2JjDxF/7rODP80axFxQF71dn8ElYZEbI+tAK9f2UKmQ ksH6Hhpx8Qj0iTvBZk7X0b/JnccddY+uet3c0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=PtHGKOmeNRGf+C9+MfTwb0BYvxZqRL3+S1ZqRafqefY=; b=ap9lFPDqncI5ZUNIwSsXsiITJQLANfZghS9f+VNKqzgf1vGZ/bDyQOMxjVEfhs9mtF B5K4jfy0seJbz9DQlNQdHtTaTJTZubqRC6WNjdnB26QO9c3xm6eDmc2eBnwHRKoVUQpj oH8CCBw6ETrZJVTE/EsCQ+bP1eLbOlhJtfilutOsuNmzNLg9v8UL3KYyJbPxfCK+6Qqb T3E5BwpiyzvV1o0dc0/Rx2Te/pensmzQamrvXrK2nTV98FZUGOAOSaMODux65Rz/N5XV vLAqwEptZ0GMvr2+L+J0kgAAhtDjT3ZJE2Ih1jA14tDra0YyvPjBLfayjkwMfHfnfLmi eypQ== X-Gm-Message-State: APt69E2A2ekpr2bXwE5W5e/EZXKs8KqSsByMExjStz+b+TP+cAwquDyM yixogL/d84KqI94FY3ZKUUr32A== X-Google-Smtp-Source: AAOMgpeyV0cCMhZyhjfUKmm/4j5W6NFih3kGCPnk7CMLOY+awUfXRy3uoiRC2k/DF/Xew4pEwON+VQ== X-Received: by 2002:adf:a6e2:: with SMTP id t89-v6mr1528378wrc.231.1530706252273; Wed, 04 Jul 2018 05:10:52 -0700 (PDT) Received: from dell ([2.27.167.87]) by smtp.gmail.com with ESMTPSA id c10-v6sm5644849wrh.44.2018.07.04.05.10.51 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 04 Jul 2018 05:10:51 -0700 (PDT) Date: Wed, 4 Jul 2018 13:10:49 +0100 From: Lee Jones To: Daniel Vetter Cc: LKML , DRI Development , Jani Nikula , Daniel Vetter , Daniel Thompson , Jingoo Han Subject: Re: [PATCH] backlight: remove obsolete comment for ->state Message-ID: <20180704121049.GE496@dell> References: <20180503141517.28207-1-daniel.vetter@ffwll.ch> <20180704093447.GU20176@dell> <20180704093816.GV20176@dell> <20180704100506.GT3891@phenom.ffwll.local> <20180704103401.GB496@dell> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 04 Jul 2018, Daniel Vetter wrote: > Hi Lee, > > On Wed, Jul 4, 2018 at 12:34 PM, Lee Jones wrote: > > On Wed, 04 Jul 2018, Daniel Vetter wrote: > >> On Wed, Jul 04, 2018 at 10:38:16AM +0100, Lee Jones wrote: > >> > On Wed, 04 Jul 2018, Lee Jones wrote: > >> > > >> > > > Jani spotted this when reviewing my earlier patch to remove the driver > >> > > > internal usage of this field in > >> > > > > >> > > > commit 3cf91adaa594e8933af1727942ac560e5c7bc70e > >> > > > Author: Daniel Vetter > >> > > > Date: Wed Apr 25 19:42:52 2018 +0200 > >> > > > > >> > > > backlight: Nuke BL_CORE_DRIVER1 > >> > > > >> > > FYI, sending patches like this is not a good idea. > >> > > > >> > > I'll clean it up for you this time, but in future please send patches > >> > > properly and place any additional comments you may have below the > >> > > '---' line. > >> > > >> > Ah, I see what you've tried to do. This hurt my eyes! :) > >> > > >> > It's more conventional to reference commits like: > >> > > >> > Commit 3cf91adaa594 ("backlight: Nuke BL_CORE_DRIVER1") > >> > > >> > Again, I'll make the amendment to avoid further confusion. > >> > >> So the first mail doesn't even bother to explain what's > >> objectionable > > > > In the first instance it looked as though you'd copied and pasted `git > > log`, which if you'd done so would have been obvious to you and would > > have required no further explanation. > > > > Also bear in mind that I took your standing within the kernel > > community into consideration, so speaking to you like a n00b or going > > into unnecessary detail could have been considered superfluous at best > > and condescending at worst. > > Unfortunately minute details like this aren't consistent across the > kernel at all, and white space and layout issues are the number 1 > reason I get shot at for random patches I'm sending out. So maybe > there are people who learned all these local expectations (Arnd > perhaps, or Kees?), it's definitely not me. Not after 10 years for > sure. > > >> the 2nd mail still says "This hurts my eyes!". > > > > It certainly did, yes. > > > > Usually taken to meaning that it was hard to read in these scenarios. > > > >> Over whitespace in the commit message. > > > > Nothing to do with white space. It was the format by which you chose > > to reference a previous commit. Instead it looked like a patch > > formatting error. I have received patches pasted from `git log` > > before, and this looked just the same. > > > > Once I'd realised what was going on, I followed up to explain and > > provided some feedback on what to do differently in future. > > > >> This kind of stuff is why graphics people really don't enjoy contributing > >> to the kernel at large. A friendly request to resend with the color choice > >> adjusted would go a lot further. > > > > I apologise if my brevity hurt your feelings. I have 290 emails to > > get though post-paternity leave before I can start to think about > > getting some real/paid work done. > > This ain't about my feelings, but working together efficiently and in > a constructive environment. > > Also, failing to have adequate maintainer coverage over absence, or > generally being overloaded, is never a valid excuse for how you deal > with contributors. It takes some effort and a bit of time, but group > maintainership in one form or another can take care of this very well. > Brevity justified as efficient communication tends to torpedo that, > since at least in my experience it just drive prospective volunteers > away to more welcoming places. I'm unsure of the foundations which this scenario builds upon. Maybe you've had some bad experiences with other Maintainers in the past which have made you uber-sensitive, but FWIW I think you're over-reacting to what were perfectly adequate review comments provided from one Maintainer to another. There wasn't any malice or harshness in my recommendations to you nor did I make any unreasonable requests of you. Merely an innocent misunderstanding in the first instance and some gentle advice in the second. If constructive feedback isn't something that you deal with well, perhaps life as a contributor (outside of your own domain at least) isn't for you. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH] backlight: remove obsolete comment for ->state Date: Wed, 4 Jul 2018 13:10:49 +0100 Message-ID: <20180704121049.GE496@dell> References: <20180503141517.28207-1-daniel.vetter@ffwll.ch> <20180704093447.GU20176@dell> <20180704093816.GV20176@dell> <20180704100506.GT3891@phenom.ffwll.local> <20180704103401.GB496@dell> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wr0-x242.google.com (mail-wr0-x242.google.com [IPv6:2a00:1450:400c:c0c::242]) by gabe.freedesktop.org (Postfix) with ESMTPS id AB6196EB91 for ; Wed, 4 Jul 2018 12:10:53 +0000 (UTC) Received: by mail-wr0-x242.google.com with SMTP id t6-v6so5104737wrn.7 for ; Wed, 04 Jul 2018 05:10:53 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter Cc: Daniel Thompson , Jani Nikula , Jingoo Han , LKML , DRI Development , Daniel Vetter List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCAwNCBKdWwgMjAxOCwgRGFuaWVsIFZldHRlciB3cm90ZToKCj4gSGkgTGVlLAo+IAo+ IE9uIFdlZCwgSnVsIDQsIDIwMTggYXQgMTI6MzQgUE0sIExlZSBKb25lcyA8bGVlLmpvbmVzQGxp bmFyby5vcmc+IHdyb3RlOgo+ID4gT24gV2VkLCAwNCBKdWwgMjAxOCwgRGFuaWVsIFZldHRlciB3 cm90ZToKPiA+PiBPbiBXZWQsIEp1bCAwNCwgMjAxOCBhdCAxMDozODoxNkFNICswMTAwLCBMZWUg Sm9uZXMgd3JvdGU6Cj4gPj4gPiBPbiBXZWQsIDA0IEp1bCAyMDE4LCBMZWUgSm9uZXMgd3JvdGU6 Cj4gPj4gPgo+ID4+ID4gPiA+IEphbmkgc3BvdHRlZCB0aGlzIHdoZW4gcmV2aWV3aW5nIG15IGVh cmxpZXIgcGF0Y2ggdG8gcmVtb3ZlIHRoZSBkcml2ZXIKPiA+PiA+ID4gPiBpbnRlcm5hbCB1c2Fn ZSBvZiB0aGlzIGZpZWxkIGluCj4gPj4gPiA+ID4KPiA+PiA+ID4gPiBjb21taXQgM2NmOTFhZGFh NTk0ZTg5MzNhZjE3Mjc5NDJhYzU2MGU1YzdiYzcwZQo+ID4+ID4gPiA+IEF1dGhvcjogRGFuaWVs IFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4KPiA+PiA+ID4gPiBEYXRlOiAgIFdlZCBB cHIgMjUgMTk6NDI6NTIgMjAxOCArMDIwMAo+ID4+ID4gPiA+Cj4gPj4gPiA+ID4gICAgIGJhY2ts aWdodDogTnVrZSBCTF9DT1JFX0RSSVZFUjEKPiA+PiA+ID4KPiA+PiA+ID4gRllJLCBzZW5kaW5n IHBhdGNoZXMgbGlrZSB0aGlzIGlzIG5vdCBhIGdvb2QgaWRlYS4KPiA+PiA+ID4KPiA+PiA+ID4g SSdsbCBjbGVhbiBpdCB1cCBmb3IgeW91IHRoaXMgdGltZSwgYnV0IGluIGZ1dHVyZSBwbGVhc2Ug c2VuZCBwYXRjaGVzCj4gPj4gPiA+IHByb3Blcmx5IGFuZCBwbGFjZSBhbnkgYWRkaXRpb25hbCBj b21tZW50cyB5b3UgbWF5IGhhdmUgYmVsb3cgdGhlCj4gPj4gPiA+ICctLS0nIGxpbmUuCj4gPj4g Pgo+ID4+ID4gQWgsIEkgc2VlIHdoYXQgeW91J3ZlIHRyaWVkIHRvIGRvLiAgVGhpcyBodXJ0IG15 IGV5ZXMhIDopCj4gPj4gPgo+ID4+ID4gSXQncyBtb3JlIGNvbnZlbnRpb25hbCB0byByZWZlcmVu Y2UgY29tbWl0cyBsaWtlOgo+ID4+ID4KPiA+PiA+ICAgQ29tbWl0IDNjZjkxYWRhYTU5NCAoImJh Y2tsaWdodDogTnVrZSBCTF9DT1JFX0RSSVZFUjEiKQo+ID4+ID4KPiA+PiA+IEFnYWluLCBJJ2xs IG1ha2UgdGhlIGFtZW5kbWVudCB0byBhdm9pZCBmdXJ0aGVyIGNvbmZ1c2lvbi4KPiA+Pgo+ID4+ IFNvIHRoZSBmaXJzdCBtYWlsIGRvZXNuJ3QgZXZlbiBib3RoZXIgdG8gZXhwbGFpbiB3aGF0J3MK PiA+PiBvYmplY3Rpb25hYmxlCj4gPgo+ID4gSW4gdGhlIGZpcnN0IGluc3RhbmNlIGl0IGxvb2tl ZCBhcyB0aG91Z2ggeW91J2QgY29waWVkIGFuZCBwYXN0ZWQgYGdpdAo+ID4gbG9nYCwgd2hpY2gg aWYgeW91J2QgZG9uZSBzbyB3b3VsZCBoYXZlIGJlZW4gb2J2aW91cyB0byB5b3UgYW5kIHdvdWxk Cj4gPiBoYXZlIHJlcXVpcmVkIG5vIGZ1cnRoZXIgZXhwbGFuYXRpb24uCj4gPgo+ID4gQWxzbyBi ZWFyIGluIG1pbmQgdGhhdCBJIHRvb2sgeW91ciBzdGFuZGluZyB3aXRoaW4gdGhlIGtlcm5lbAo+ ID4gY29tbXVuaXR5IGludG8gY29uc2lkZXJhdGlvbiwgc28gc3BlYWtpbmcgdG8geW91IGxpa2Ug YSBuMDBiIG9yIGdvaW5nCj4gPiBpbnRvIHVubmVjZXNzYXJ5IGRldGFpbCBjb3VsZCBoYXZlIGJl ZW4gY29uc2lkZXJlZCBzdXBlcmZsdW91cyBhdCBiZXN0Cj4gPiBhbmQgY29uZGVzY2VuZGluZyBh dCB3b3JzdC4KPiAKPiBVbmZvcnR1bmF0ZWx5IG1pbnV0ZSBkZXRhaWxzIGxpa2UgdGhpcyBhcmVu J3QgY29uc2lzdGVudCBhY3Jvc3MgdGhlCj4ga2VybmVsIGF0IGFsbCwgYW5kIHdoaXRlIHNwYWNl IGFuZCBsYXlvdXQgaXNzdWVzIGFyZSB0aGUgbnVtYmVyIDEKPiByZWFzb24gSSBnZXQgc2hvdCBh dCBmb3IgcmFuZG9tIHBhdGNoZXMgSSdtIHNlbmRpbmcgb3V0LiBTbyBtYXliZQo+IHRoZXJlIGFy ZSBwZW9wbGUgd2hvIGxlYXJuZWQgYWxsIHRoZXNlIGxvY2FsIGV4cGVjdGF0aW9ucyAoQXJuZAo+ IHBlcmhhcHMsIG9yIEtlZXM/KSwgaXQncyBkZWZpbml0ZWx5IG5vdCBtZS4gTm90IGFmdGVyIDEw IHllYXJzIGZvcgo+IHN1cmUuCj4gCj4gPj4gdGhlIDJuZCBtYWlsIHN0aWxsIHNheXMgIlRoaXMg aHVydHMgbXkgZXllcyEiLgo+ID4KPiA+IEl0IGNlcnRhaW5seSBkaWQsIHllcy4KPiA+Cj4gPiBV c3VhbGx5IHRha2VuIHRvIG1lYW5pbmcgdGhhdCBpdCB3YXMgaGFyZCB0byByZWFkIGluIHRoZXNl IHNjZW5hcmlvcy4KPiA+Cj4gPj4gT3ZlciB3aGl0ZXNwYWNlIGluIHRoZSBjb21taXQgbWVzc2Fn ZS4KPiA+Cj4gPiBOb3RoaW5nIHRvIGRvIHdpdGggd2hpdGUgc3BhY2UuICBJdCB3YXMgdGhlIGZv cm1hdCBieSB3aGljaCB5b3UgY2hvc2UKPiA+IHRvIHJlZmVyZW5jZSBhIHByZXZpb3VzIGNvbW1p dC4gIEluc3RlYWQgaXQgbG9va2VkIGxpa2UgYSBwYXRjaAo+ID4gZm9ybWF0dGluZyBlcnJvci4g IEkgaGF2ZSByZWNlaXZlZCBwYXRjaGVzIHBhc3RlZCBmcm9tIGBnaXQgbG9nYAo+ID4gYmVmb3Jl LCBhbmQgdGhpcyBsb29rZWQganVzdCB0aGUgc2FtZS4KPiA+Cj4gPiBPbmNlIEknZCByZWFsaXNl ZCB3aGF0IHdhcyBnb2luZyBvbiwgSSBmb2xsb3dlZCB1cCB0byBleHBsYWluIGFuZAo+ID4gcHJv dmlkZWQgc29tZSBmZWVkYmFjayBvbiB3aGF0IHRvIGRvIGRpZmZlcmVudGx5IGluIGZ1dHVyZS4K PiA+Cj4gPj4gVGhpcyBraW5kIG9mIHN0dWZmIGlzIHdoeSBncmFwaGljcyBwZW9wbGUgcmVhbGx5 IGRvbid0IGVuam95IGNvbnRyaWJ1dGluZwo+ID4+IHRvIHRoZSBrZXJuZWwgYXQgbGFyZ2UuIEEg ZnJpZW5kbHkgcmVxdWVzdCB0byByZXNlbmQgd2l0aCB0aGUgY29sb3IgY2hvaWNlCj4gPj4gYWRq dXN0ZWQgd291bGQgZ28gYSBsb3QgZnVydGhlci4KPiA+Cj4gPiBJIGFwb2xvZ2lzZSBpZiBteSBi cmV2aXR5IGh1cnQgeW91ciBmZWVsaW5ncy4gIEkgaGF2ZSAyOTAgZW1haWxzIHRvCj4gPiBnZXQg dGhvdWdoIHBvc3QtcGF0ZXJuaXR5IGxlYXZlIGJlZm9yZSBJIGNhbiBzdGFydCB0byB0aGluayBh Ym91dAo+ID4gZ2V0dGluZyBzb21lIHJlYWwvcGFpZCB3b3JrIGRvbmUuCj4gCj4gVGhpcyBhaW4n dCBhYm91dCBteSBmZWVsaW5ncywgYnV0IHdvcmtpbmcgdG9nZXRoZXIgZWZmaWNpZW50bHkgYW5k IGluCj4gYSBjb25zdHJ1Y3RpdmUgZW52aXJvbm1lbnQuCj4gCj4gQWxzbywgZmFpbGluZyB0byBo YXZlIGFkZXF1YXRlIG1haW50YWluZXIgY292ZXJhZ2Ugb3ZlciBhYnNlbmNlLCBvcgo+IGdlbmVy YWxseSBiZWluZyBvdmVybG9hZGVkLCBpcyBuZXZlciBhIHZhbGlkIGV4Y3VzZSBmb3IgaG93IHlv dSBkZWFsCj4gd2l0aCBjb250cmlidXRvcnMuIEl0IHRha2VzIHNvbWUgZWZmb3J0IGFuZCBhIGJp dCBvZiB0aW1lLCBidXQgZ3JvdXAKPiBtYWludGFpbmVyc2hpcCBpbiBvbmUgZm9ybSBvciBhbm90 aGVyIGNhbiB0YWtlIGNhcmUgb2YgdGhpcyB2ZXJ5IHdlbGwuCj4gQnJldml0eSBqdXN0aWZpZWQg YXMgZWZmaWNpZW50IGNvbW11bmljYXRpb24gdGVuZHMgdG8gdG9ycGVkbyB0aGF0LAo+IHNpbmNl IGF0IGxlYXN0IGluIG15IGV4cGVyaWVuY2UgaXQganVzdCBkcml2ZSBwcm9zcGVjdGl2ZSB2b2x1 bnRlZXJzCj4gYXdheSB0byBtb3JlIHdlbGNvbWluZyBwbGFjZXMuCgpJJ20gdW5zdXJlIG9mIHRo ZSBmb3VuZGF0aW9ucyB3aGljaCB0aGlzIHNjZW5hcmlvIGJ1aWxkcyB1cG9uLiAgTWF5YmUKeW91 J3ZlIGhhZCBzb21lIGJhZCBleHBlcmllbmNlcyB3aXRoIG90aGVyIE1haW50YWluZXJzIGluIHRo ZSBwYXN0CndoaWNoIGhhdmUgbWFkZSB5b3UgdWJlci1zZW5zaXRpdmUsIGJ1dCBGV0lXIEkgdGhp bmsgeW91J3JlCm92ZXItcmVhY3RpbmcgdG8gd2hhdCB3ZXJlIHBlcmZlY3RseSBhZGVxdWF0ZSBy ZXZpZXcgY29tbWVudHMgcHJvdmlkZWQKZnJvbSBvbmUgTWFpbnRhaW5lciB0byBhbm90aGVyLgoK VGhlcmUgd2Fzbid0IGFueSBtYWxpY2Ugb3IgaGFyc2huZXNzIGluIG15IHJlY29tbWVuZGF0aW9u cyB0byB5b3Ugbm9yCmRpZCBJIG1ha2UgYW55IHVucmVhc29uYWJsZSByZXF1ZXN0cyBvZiB5b3Uu ICBNZXJlbHkgYW4gaW5ub2NlbnQKbWlzdW5kZXJzdGFuZGluZyBpbiB0aGUgZmlyc3QgaW5zdGFu Y2UgYW5kIHNvbWUgZ2VudGxlIGFkdmljZSBpbiB0aGUKc2Vjb25kLiAgSWYgY29uc3RydWN0aXZl IGZlZWRiYWNrIGlzbid0IHNvbWV0aGluZyB0aGF0IHlvdSBkZWFsIHdpdGgKd2VsbCwgcGVyaGFw cyBsaWZlIGFzIGEgY29udHJpYnV0b3IgKG91dHNpZGUgb2YgeW91ciBvd24gZG9tYWluIGF0Cmxl YXN0KSBpc24ndCBmb3IgeW91LgoKLS0gCkxlZSBKb25lcyBb5p2O55C85pavXQpMaW5hcm8gU2Vy dmljZXMgVGVjaG5pY2FsIExlYWQKTGluYXJvLm9yZyDilIIgT3BlbiBzb3VyY2Ugc29mdHdhcmUg Zm9yIEFSTSBTb0NzCkZvbGxvdyBMaW5hcm86IEZhY2Vib29rIHwgVHdpdHRlciB8IEJsb2cKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1h aWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMu ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==