All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
	linux-kernel@vger.kernel.org,
	Gwendal Grignou <gwendal@chromium.org>,
	Benson Leung <bleung@chromium.org>
Subject: Re: [PATCH 1/2] Revert "mfd: cros_ec: Remove unused __remove function"
Date: Wed, 4 Jul 2018 15:16:22 +0000	[thread overview]
Message-ID: <20180704151622.sncbvlrlv3tuilrp@penguin> (raw)
In-Reply-To: <20180704064811.GD20176@dell>

Hi Lee,

On Wed, Jul 04, 2018 at 07:48:11AM +0100, Lee Jones wrote:
> On Wed, 20 Jun 2018, Dmitry Torokhov wrote:
> 
> > This reverts commit 556c242045f0c1613aac2e64dc5b2ff0e4bc89e1.
> > 
> > The patch that this change is purported to fix is broken and should be
> > reverted; thus we reverting this one as well.
> 
> You need to provide more information.
> 
> How does the original patch break the build/code execution?
> What is this patch doing to rectify the issue?
> Any other information you think is relevant.

We are reverting this patch because it is not needed: it tries to fix
another patch that is completely broken and needs to be reverted. The
justification for reverting the original broken patch is in the revert
of that patch, but just for reference:

We should not use devm_kzalloc() to allocate refcounted objects.

Thanks.

-- 
Dmitry

  reply	other threads:[~2018-07-04 15:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-20 21:30 [PATCH 1/2] Revert "mfd: cros_ec: Remove unused __remove function" Dmitry Torokhov
2018-06-20 21:30 ` [PATCH 2/2] Revert "mfd: cros_ec: Use devm_kzalloc for private data" Dmitry Torokhov
2018-07-04  7:00   ` Lee Jones
2018-07-04  6:48 ` [PATCH 1/2] Revert "mfd: cros_ec: Remove unused __remove function" Lee Jones
2018-07-04 15:16   ` Dmitry Torokhov [this message]
2018-07-04 16:11     ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180704151622.sncbvlrlv3tuilrp@penguin \
    --to=dmitry.torokhov@gmail.com \
    --cc=arnd@arndb.de \
    --cc=bleung@chromium.org \
    --cc=gwendal@chromium.org \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.