From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: qemu-devel@nongnu.org, qemu-block@nongnu.org
Cc: pl@kamp.de, pbonzini@redhat.com, ronniesahlberg@gmail.com,
famz@redhat.com, stefanha@redhat.com, mreitz@redhat.com,
kwolf@redhat.com, jcody@redhat.com, jsnow@redhat.com,
den@openvz.org, vsementsov@virtuozzo.com
Subject: [Qemu-devel] [PATCH v3 0/4] fix image fleecing
Date: Thu, 5 Jul 2018 10:46:34 +0300 [thread overview]
Message-ID: <20180705074638.770905-1-vsementsov@virtuozzo.com> (raw)
Hi all.
This fixes image fleecing scheme for 3.0, details are in 04 patch.
v3:
02: fix typo in assert, to fix build
v2:
01,02: new patches
03: - improve comment
- fix assert in bdrv_aligned_pwritev
- add asserts to not use the flag on read requests
- support copy_range
04: - expand "detected cases" range
- s/fleecing/serialize_target_writes
- support backup_cow_with_offload
- drop restriction on compressed writes
v1 cover:
It's a continuation of discussion under
"[PATCH v2 2/3] block/fleecing-filter: new filter driver for fleecing" [1].
Here is my try to implement Kevin's idea, that all backup writes (for
fleecing case) should be serialized. (However, I've skipped for now
fixing related permissions).
Looks like these patches may replace patch [1], to make fleecing scheme
safe. But I'm not sure, a look by Kevin is necessary.
A test is still needed, to prove that this patch is necessary and that it
works..
Vladimir Sementsov-Ogievskiy (4):
block: disallow BDRV_REQ_NO_SERIALISING for write
block: split flags in copy_range
block: add BDRV_REQ_SERIALISING flag
block/backup: fix fleecing scheme: use serialized writes
include/block/block.h | 31 ++++++++++++++++--
include/block/block_int.h | 14 +++++---
include/sysemu/block-backend.h | 3 +-
block/backup.c | 20 ++++++++----
block/block-backend.c | 5 +--
block/file-posix.c | 21 +++++++-----
block/io.c | 74 ++++++++++++++++++++++++++++++------------
block/iscsi.c | 9 +++--
block/qcow2.c | 20 +++++++-----
block/raw-format.c | 24 +++++++++-----
qemu-img.c | 2 +-
11 files changed, 159 insertions(+), 64 deletions(-)
--
2.11.1
next reply other threads:[~2018-07-05 7:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-05 7:46 Vladimir Sementsov-Ogievskiy [this message]
2018-07-05 7:46 ` [Qemu-devel] [PATCH v3 1/4] block: disallow BDRV_REQ_NO_SERIALISING for write Vladimir Sementsov-Ogievskiy
2018-07-06 21:32 ` Eric Blake
2018-07-06 21:46 ` Eric Blake
2018-07-09 16:08 ` Vladimir Sementsov-Ogievskiy
2018-07-09 15:56 ` Vladimir Sementsov-Ogievskiy
2018-07-05 7:46 ` [Qemu-devel] [PATCH v3 2/4] block: split flags in copy_range Vladimir Sementsov-Ogievskiy
2018-07-05 7:46 ` [Qemu-devel] [PATCH v3 3/4] block: add BDRV_REQ_SERIALISING flag Vladimir Sementsov-Ogievskiy
2018-07-06 21:52 ` Eric Blake
2018-07-05 7:46 ` [Qemu-devel] [PATCH v3 4/4] block/backup: fix fleecing scheme: use serialized writes Vladimir Sementsov-Ogievskiy
2018-07-06 7:17 ` [Qemu-devel] [PATCH v3 0/4] fix image fleecing Fam Zheng
2018-07-06 13:41 ` Vladimir Sementsov-Ogievskiy
2018-07-06 14:34 ` Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180705074638.770905-1-vsementsov@virtuozzo.com \
--to=vsementsov@virtuozzo.com \
--cc=den@openvz.org \
--cc=famz@redhat.com \
--cc=jcody@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=pl@kamp.de \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=ronniesahlberg@gmail.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.