From: Wei Liu <wei.liu2@citrix.com>
To: Ian Jackson <ian.jackson@citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
Wei Liu <wei.liu2@citrix.com>
Subject: Re: [PATCH v3 3/6] libxc: allow HVM guest to have modules
Date: Thu, 5 Jul 2018 11:51:06 +0100 [thread overview]
Message-ID: <20180705105106.w5u3ejwyphmfp6f4@citrix.com> (raw)
In-Reply-To: <23357.63002.633261.79972@mariner.uk.xensource.com>
On Thu, Jul 05, 2018 at 11:42:34AM +0100, Ian Jackson wrote:
> Wei Liu writes ("Re: [PATCH v3 3/6] libxc: allow HVM guest to have modules"):
> > On Thu, Jul 05, 2018 at 11:29:41AM +0100, Ian Jackson wrote:
> > > AIUI you mean something more like
> > >
> > > Now the code needs to handle virt_base being UNSET_ADDR, which it is
> > > for HVM guests. In that case seg.vstart is interpreted by ???
> > > as an ??? offset from zero ???
> >
> > Now the code needs to handle virt_base being UNSET_ADDR, which it is for
> > HVM guest. In case PVH and PV, virt_base is set by the respective loader
> > by parsing the binary.
>
> That doesn't explain how the necessary value of seg.vstart can be
> calculated without needing to know the not-yet-calculated value of
> virt_base.
virt_base should already be calculated at this point. It is either set
or not. There is possibility for setting 0 at some point but it doesn't
change how we interpret UNSET_ADDR.
Wei.
>
> Thanks,
> Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-07-05 10:51 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-26 11:13 [PATCH v3 0/6] Load ipxe from a standalone file Wei Liu
2018-06-26 11:13 ` [PATCH v3 1/6] Tools.mk.in: drop unused variables Wei Liu
2018-06-26 11:13 ` [PATCH v3 2/6] ipxe: produce a single binary from its build Wei Liu
2018-06-26 11:13 ` [PATCH v3 3/6] libxc: allow HVM guest to have modules Wei Liu
2018-07-05 10:29 ` Ian Jackson
2018-07-05 10:34 ` Wei Liu
2018-07-05 10:35 ` Wei Liu
2018-07-05 10:42 ` Ian Jackson
2018-07-05 10:48 ` Wei Liu
2018-07-05 10:42 ` Ian Jackson
2018-07-05 10:51 ` Wei Liu [this message]
2018-06-26 11:13 ` [PATCH v3 4/6] tools: load IPXE from standalone file Wei Liu
2018-07-05 10:39 ` Ian Jackson
2018-07-05 10:50 ` Wei Liu
2018-06-26 11:13 ` [PATCH v3 5/6] tools: provide --with-system-ipxe Wei Liu
2018-07-05 10:40 ` Ian Jackson
2018-07-05 10:46 ` Wei Liu
2018-06-26 11:13 ` [PATCH v3 6/6] tools: --with-system-{ovmf, seabios, ipxe} should provide absolute paths Wei Liu
2018-07-05 10:41 ` Ian Jackson
2018-07-05 10:46 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180705105106.w5u3ejwyphmfp6f4@citrix.com \
--to=wei.liu2@citrix.com \
--cc=ian.jackson@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.