All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] zmalloc: hide unused lock_zspage
@ 2018-07-06 13:09 Arnd Bergmann
  2018-07-06 14:44 ` Sergey Senozhatsky
  0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2018-07-06 13:09 UTC (permalink / raw)
  To: Minchan Kim, Nitin Gupta
  Cc: Colin Ian King, Arnd Bergmann, Sergey Senozhatsky, Andrew Morton,
	Nick Desaulniers, linux-mm, linux-kernel

Making lock_zspage() static revealed that it is unused in some confiurations:

mm/zsmalloc.c:931:13: error: 'lock_zspage' defined but not used [-Werror=unused-function]

I considered moving it into the same #ifdef that hides its user, but
it seems better to keep it close to trylock_zspage() etc, so this
marks it __maybe_unused() to let the compiler drop it without warning
about it.

Fixes: 0de664ada6b6 ("mm/zsmalloc.c: make several functions and a struct static")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 mm/zsmalloc.c | 26 +++++++++++++-------------
 1 file changed, 13 insertions(+), 13 deletions(-)

diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
index 900bea99452a..58886d40786b 100644
--- a/mm/zsmalloc.c
+++ b/mm/zsmalloc.c
@@ -924,19 +924,6 @@ static void reset_page(struct page *page)
 	page->freelist = NULL;
 }
 
-/*
- * To prevent zspage destroy during migration, zspage freeing should
- * hold locks of all pages in the zspage.
- */
-static void lock_zspage(struct zspage *zspage)
-{
-	struct page *page = get_first_page(zspage);
-
-	do {
-		lock_page(page);
-	} while ((page = get_next_page(page)) != NULL);
-}
-
 static int trylock_zspage(struct zspage *zspage)
 {
 	struct page *cursor, *fail;
@@ -1814,6 +1801,19 @@ static enum fullness_group putback_zspage(struct size_class *class,
 }
 
 #ifdef CONFIG_COMPACTION
+/*
+ * To prevent zspage destroy during migration, zspage freeing should
+ * hold locks of all pages in the zspage.
+ */
+static void lock_zspage(struct zspage *zspage)
+{
+	struct page *page = get_first_page(zspage);
+
+	do {
+		lock_page(page);
+	} while ((page = get_next_page(page)) != NULL);
+}
+
 static struct dentry *zs_mount(struct file_system_type *fs_type,
 			       int flags, const char *dev_name,
 			       void *data, size_t data_size)
-- 
2.9.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] zmalloc: hide unused lock_zspage
  2018-07-06 13:09 [PATCH] zmalloc: hide unused lock_zspage Arnd Bergmann
@ 2018-07-06 14:44 ` Sergey Senozhatsky
  0 siblings, 0 replies; 2+ messages in thread
From: Sergey Senozhatsky @ 2018-07-06 14:44 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: Minchan Kim, Nitin Gupta, Colin Ian King, Sergey Senozhatsky,
	Andrew Morton, Nick Desaulniers, linux-mm, linux-kernel

On (07/06/18 15:09), Arnd Bergmann wrote:
> 
> 
> Fixes: 0de664ada6b6 ("mm/zsmalloc.c: make several functions and a struct static")

This one is still in mmotm/linux-next. Do you mind if we just squash
them?

	-ss

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-07-06 14:44 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-06 13:09 [PATCH] zmalloc: hide unused lock_zspage Arnd Bergmann
2018-07-06 14:44 ` Sergey Senozhatsky

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.