From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FFCCC3279B for ; Fri, 6 Jul 2018 22:34:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 137C522B66 for ; Fri, 6 Jul 2018 22:34:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 137C522B66 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754352AbeGFWeB convert rfc822-to-8bit (ORCPT ); Fri, 6 Jul 2018 18:34:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38500 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754120AbeGFWd7 (ORCPT ); Fri, 6 Jul 2018 18:33:59 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 111BA307D840; Fri, 6 Jul 2018 22:33:58 +0000 (UTC) Received: from t450s.home (ovpn-116-113.phx2.redhat.com [10.3.116.113]) by smtp.corp.redhat.com (Postfix) with ESMTP id 07B522A2DF; Fri, 6 Jul 2018 22:33:55 +0000 (UTC) Date: Fri, 6 Jul 2018 16:33:56 -0600 From: Alex Williamson To: Logan Gunthorpe Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-doc@vger.kernel.org, Stephen Bates , Christoph Hellwig , Bjorn Helgaas , Jonathan Corbet , Ingo Molnar , Thomas Gleixner , "Paul E. McKenney" , Marc Zyngier , Kai-Heng Feng , Frederic Weisbecker , Dan Williams , =?UTF-8?B?SsOpcsO0bWU=?= Glisse , Benjamin Herrenschmidt , Christian =?UTF-8?B?S8O2bmln?= , Matthew Wilcox Subject: Re: [PATCH v5 1/3] PCI: Make specifying PCI devices in kernel parameters reusable Message-ID: <20180706163356.697f529c@t450s.home> In-Reply-To: <20180627174650.27433-2-logang@deltatee.com> References: <20180627174650.27433-1-logang@deltatee.com> <20180627174650.27433-2-logang@deltatee.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.48]); Fri, 06 Jul 2018 22:33:59 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 27 Jun 2018 11:46:48 -0600 Logan Gunthorpe wrote: > Separate out the code to match a PCI device with a string (typically > originating from a kernel parameter) from the > pci_specified_resource_alignment() function into its own helper > function. > > While we are at it, this change fixes the kernel style of the function > (fixing a number of long lines and extra parentheses). > > Additionally, make the analogous change to the kernel parameter > documentation: Separating the description of how to specify a PCI device > into it's own section at the head of the pci= parameter. > > This patch should have no functional alterations. > > Signed-off-by: Logan Gunthorpe > Reviewed-by: Stephen Bates > Acked-by: Christian König Reviewed-by: Alex Williamson From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on archive.lwn.net X-Spam-Level: X-Spam-Status: No, score=-5.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham autolearn_force=no version=3.4.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by archive.lwn.net (Postfix) with ESMTP id 134767D048 for ; Fri, 6 Jul 2018 22:34:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754151AbeGFWeA convert rfc822-to-8bit (ORCPT ); Fri, 6 Jul 2018 18:34:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38500 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754120AbeGFWd7 (ORCPT ); Fri, 6 Jul 2018 18:33:59 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 111BA307D840; Fri, 6 Jul 2018 22:33:58 +0000 (UTC) Received: from t450s.home (ovpn-116-113.phx2.redhat.com [10.3.116.113]) by smtp.corp.redhat.com (Postfix) with ESMTP id 07B522A2DF; Fri, 6 Jul 2018 22:33:55 +0000 (UTC) Date: Fri, 6 Jul 2018 16:33:56 -0600 From: Alex Williamson To: Logan Gunthorpe Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-doc@vger.kernel.org, Stephen Bates , Christoph Hellwig , Bjorn Helgaas , Jonathan Corbet , Ingo Molnar , Thomas Gleixner , "Paul E. McKenney" , Marc Zyngier , Kai-Heng Feng , Frederic Weisbecker , Dan Williams , =?UTF-8?B?SsOpcsO0bWU=?= Glisse , Benjamin Herrenschmidt , Christian =?UTF-8?B?S8O2bmln?= , Matthew Wilcox Subject: Re: [PATCH v5 1/3] PCI: Make specifying PCI devices in kernel parameters reusable Message-ID: <20180706163356.697f529c@t450s.home> In-Reply-To: <20180627174650.27433-2-logang@deltatee.com> References: <20180627174650.27433-1-logang@deltatee.com> <20180627174650.27433-2-logang@deltatee.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.48]); Fri, 06 Jul 2018 22:33:59 +0000 (UTC) Sender: linux-doc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Wed, 27 Jun 2018 11:46:48 -0600 Logan Gunthorpe wrote: > Separate out the code to match a PCI device with a string (typically > originating from a kernel parameter) from the > pci_specified_resource_alignment() function into its own helper > function. > > While we are at it, this change fixes the kernel style of the function > (fixing a number of long lines and extra parentheses). > > Additionally, make the analogous change to the kernel parameter > documentation: Separating the description of how to specify a PCI device > into it's own section at the head of the pci= parameter. > > This patch should have no functional alterations. > > Signed-off-by: Logan Gunthorpe > Reviewed-by: Stephen Bates > Acked-by: Christian König Reviewed-by: Alex Williamson -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html