From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net] net: diag: Don't double-free TCP_NEW_SYN_RECV sockets in tcp_abort Date: Sat, 07 Jul 2018 22:11:46 +0900 (KST) Message-ID: <20180707.221146.161981342461262899.davem@davemloft.net> References: <20180707073140.202004-1-lorenzo@google.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, astrachan@google.com, subashab@codeaurora.org, eric.dumazet@gmail.com, dsa@cumulusnetworks.com To: lorenzo@google.com Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:53314 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753993AbeGGNLu (ORCPT ); Sat, 7 Jul 2018 09:11:50 -0400 In-Reply-To: <20180707073140.202004-1-lorenzo@google.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Lorenzo Colitti Date: Sat, 7 Jul 2018 16:31:40 +0900 > Tested: passes Android sock_diag_test.py, which exercises this codepath If this Android test case exercises this path, why didn't it trigger the double free and thus cause this bug to be found much sooner? Just curious.