From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from magic.merlins.org ([209.81.13.136]:60524 "EHLO mail1.merlins.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732332AbeGKBpz (ORCPT ); Tue, 10 Jul 2018 21:45:55 -0400 Date: Tue, 10 Jul 2018 18:44:01 -0700 From: Marc MERLIN To: Su Yue Cc: Qu Wenruo , linux-btrfs@vger.kernel.org, Su Yue Message-ID: <20180711014401.hic5vcp5h2tzgyxh@merlins.org> References: <20180710180915.onnxuak7vb7uywyn@merlins.org> <9afce26c-0a3f-3389-ba0f-597b26a8cd7e@cn.fujitsu.com> <20180711005852.prhnmohkzjplw54j@merlins.org> <9b612c36-f59c-b4c7-bb84-4a30c4a7d453@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <9b612c36-f59c-b4c7-bb84-4a30c4a7d453@cn.fujitsu.com> Subject: Re: btrfs check lowmem, take 2 Sender: linux-btrfs-owner@vger.kernel.org List-ID: On Wed, Jul 11, 2018 at 09:08:40AM +0800, Su Yue wrote: > > > On 07/11/2018 08:58 AM, Marc MERLIN wrote: > > On Wed, Jul 11, 2018 at 08:53:58AM +0800, Su Yue wrote: > > > > Problems > > > > 1) btrfs check --repair _still_ takes all 32GB of RAM and crashes the > > > > server, despite my deleting lots of snapshots. > > > > Is it because I have too many files then? > > > > > > > Yes. Original check first gather all infomation about extent tree and > > > your files in RAM, then process one by one. > > > But deleting still counts, it does speed lowmem check up. > > > > Understood. > > > > > > 2) I tried Su's master git branch for btrfs-progs to try and see how > > > Oh..No... My master branch is still 4.14. The true mater branch is > > > David's here: > > > https://github.com/kdave/btrfs-progs > > > But the master branch has a known bug which I fixed yesterday, please see > > > the mail. > > > > So, if I git sync it now, it should have your fix, and I can run it, > > correct? > > > Yes, please. Ok, I am now running gargamel:~# time btrfs check --mode=lowmem --repair /dev/mapper/dshelf2 using git master from https://github.com/kdave/btrfs-progs I will report back how long it takes with extent tree check and whether it returns clean, or not. Marc -- "A mouse is a device used to point at the xterm you want to type in" - A.S.R. Microsoft is to operating systems .... .... what McDonalds is to gourmet cooking Home page: http://marc.merlins.org/ | PGP 7F55D5F27AAF9D08