All of lore.kernel.org
 help / color / mirror / Atom feed
From: Huang Rui <ray.huang-5C7GfCeVMHo@public.gmane.org>
To: Evan Quan <evan.quan-5C7GfCeVMHo@public.gmane.org>
Cc: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [PATCH] drm/amd/powerplay: convert the sclk/mclk into Mhz for comparation
Date: Wed, 11 Jul 2018 18:13:25 +0800	[thread overview]
Message-ID: <20180711101324.GB11796@hr-amur2> (raw)
In-Reply-To: <20180711082637.1984-1-evan.quan-5C7GfCeVMHo@public.gmane.org>

On Wed, Jul 11, 2018 at 04:26:37PM +0800, Evan Quan wrote:
> Convert the clocks into right Mhz unit. Otherwise, it will miss
> the equal situation.
> 
> Change-Id: I80e1af975715712f5ddef4ca6a6e356d90932613
> Signed-off-by: Evan Quan <evan.quan@amd.com>

Reviewed-by: Huang Rui <ray.huang@amd.com>

> ---
>  drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c
> index cae76fe65881..c0ceb69a23b0 100644
> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c
> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c
> @@ -1881,7 +1881,7 @@ static int vega12_print_clock_levels(struct pp_hwmgr *hwmgr,
>  		for (i = 0; i < clocks.num_levels; i++)
>  			size += sprintf(buf + size, "%d: %uMhz %s\n",
>  				i, clocks.data[i].clocks_in_khz / 1000,
> -				(clocks.data[i].clocks_in_khz / 1000 == now) ? "*" : "");
> +				(clocks.data[i].clocks_in_khz / 1000 == now / 100) ? "*" : "");
>  		break;
>  
>  	case PP_MCLK:
> @@ -1897,7 +1897,7 @@ static int vega12_print_clock_levels(struct pp_hwmgr *hwmgr,
>  		for (i = 0; i < clocks.num_levels; i++)
>  			size += sprintf(buf + size, "%d: %uMhz %s\n",
>  				i, clocks.data[i].clocks_in_khz / 1000,
> -				(clocks.data[i].clocks_in_khz / 1000 == now) ? "*" : "");
> +				(clocks.data[i].clocks_in_khz / 1000 == now / 100) ? "*" : "");
>  		break;
>  
>  	case PP_PCIE:
> -- 
> 2.18.0
> 
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

  parent reply	other threads:[~2018-07-11 10:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-11  8:26 [PATCH] drm/amd/powerplay: convert the sclk/mclk into Mhz for comparation Evan Quan
     [not found] ` <20180711082637.1984-1-evan.quan-5C7GfCeVMHo@public.gmane.org>
2018-07-11 10:13   ` Huang Rui [this message]
2018-07-11 15:35   ` Alex Deucher
     [not found]     ` <CADnq5_M+OQDMjaHbXHoOMHVfSrQbGSLoz4gHNvYZiJCCjtwe7g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-07-12  2:58       ` Quan, Evan
     [not found]         ` <SN6PR12MB265670F9019D1B6B213E4B30E4590-kxOKjb6HO/FeL/N0e1LXkAdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2018-07-12  3:25           ` Alex Deucher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180711101324.GB11796@hr-amur2 \
    --to=ray.huang-5c7gfcevmho@public.gmane.org \
    --cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    --cc=evan.quan-5C7GfCeVMHo@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.