* [PATCH] staging: gasket: remove redundant pointer bar_data
@ 2018-07-11 10:40 ` Colin King
0 siblings, 0 replies; 2+ messages in thread
From: Colin King @ 2018-07-11 10:40 UTC (permalink / raw)
To: Rob Springer, John Joseph, Ben Chan, Greg Kroah-Hartman, devel
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Pointer bar_data is being assigned but is never used hence it is redundant
and can be removed.
Cleans up clang warning:
warning: variable 'bar_data' set but not used [-Wunused-but-set-variable]
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/staging/gasket/gasket_core.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/gasket/gasket_core.c b/drivers/staging/gasket/gasket_core.c
index ad9442a5bb9d..45914ebc8f44 100644
--- a/drivers/staging/gasket/gasket_core.c
+++ b/drivers/staging/gasket/gasket_core.c
@@ -1610,7 +1610,6 @@ static int gasket_mmap(struct file *filp, struct vm_area_struct *vma)
bool is_coherent_region;
const struct gasket_driver_desc *driver_desc;
struct gasket_dev *gasket_dev = (struct gasket_dev *)filp->private_data;
- struct gasket_bar_data *bar_data;
const struct gasket_bar_desc *bar_desc;
struct gasket_mappable_region *map_regions = NULL;
int num_map_regions = 0;
@@ -1673,8 +1672,6 @@ static int gasket_mmap(struct file *filp, struct vm_area_struct *vma)
* Subtract the base of the bar from the raw offset to get the
* memory location within the bar to map.
*/
- bar_data = &gasket_dev->bar_data[bar_index];
-
bar_desc = &driver_desc->bar_descriptions[bar_index];
permissions = bar_desc->permissions;
if (!gasket_mmap_has_permissions(gasket_dev, vma, permissions)) {
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] staging: gasket: remove redundant pointer bar_data
@ 2018-07-11 10:40 ` Colin King
0 siblings, 0 replies; 2+ messages in thread
From: Colin King @ 2018-07-11 10:40 UTC (permalink / raw)
To: Rob Springer, John Joseph, Ben Chan, Greg Kroah-Hartman, devel
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Pointer bar_data is being assigned but is never used hence it is redundant
and can be removed.
Cleans up clang warning:
warning: variable 'bar_data' set but not used [-Wunused-but-set-variable]
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/staging/gasket/gasket_core.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/gasket/gasket_core.c b/drivers/staging/gasket/gasket_core.c
index ad9442a5bb9d..45914ebc8f44 100644
--- a/drivers/staging/gasket/gasket_core.c
+++ b/drivers/staging/gasket/gasket_core.c
@@ -1610,7 +1610,6 @@ static int gasket_mmap(struct file *filp, struct vm_area_struct *vma)
bool is_coherent_region;
const struct gasket_driver_desc *driver_desc;
struct gasket_dev *gasket_dev = (struct gasket_dev *)filp->private_data;
- struct gasket_bar_data *bar_data;
const struct gasket_bar_desc *bar_desc;
struct gasket_mappable_region *map_regions = NULL;
int num_map_regions = 0;
@@ -1673,8 +1672,6 @@ static int gasket_mmap(struct file *filp, struct vm_area_struct *vma)
* Subtract the base of the bar from the raw offset to get the
* memory location within the bar to map.
*/
- bar_data = &gasket_dev->bar_data[bar_index];
-
bar_desc = &driver_desc->bar_descriptions[bar_index];
permissions = bar_desc->permissions;
if (!gasket_mmap_has_permissions(gasket_dev, vma, permissions)) {
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-07-11 10:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-11 10:40 [PATCH] staging: gasket: remove redundant pointer bar_data Colin King
2018-07-11 10:40 ` Colin King
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.