From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: Alex Vesker <valex@mellanox.com>
Cc: netdev@vger.kernel.org, jiri@mellanox.com, dsahern@gmail.com,
andrew@lunn.ch, rahul.lakkireddy@chelsio.com
Subject: Re: [PATCH net-next v2 04/11] devlink: Add support for region get command
Date: Wed, 11 Jul 2018 11:52:15 -0700 [thread overview]
Message-ID: <20180711115215.716c6802@cakuba.lan> (raw)
In-Reply-To: <1531305788-29420-5-git-send-email-valex@mellanox.com>
On Wed, 11 Jul 2018 13:43:01 +0300, Alex Vesker wrote:
> + DEVLINK_ATTR_REGION_SIZE, /* u32 */
> + err = nla_put_u64_64bit(msg, DEVLINK_ATTR_REGION_SIZE,
> + region->size,
> + DEVLINK_ATTR_PAD);
Size in the comment looks incorrect.
next prev parent reply other threads:[~2018-07-11 18:57 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-11 10:42 [PATCH net-next v2 00/11] devlink: Add support for region access Alex Vesker
2018-07-11 10:42 ` [PATCH net-next v2 01/11] devlink: Add support for creating and destroying regions Alex Vesker
2018-07-11 10:42 ` [PATCH net-next v2 02/11] devlink: Add callback to query for snapshot id before snapshot create Alex Vesker
2018-07-11 10:43 ` [PATCH net-next v2 03/11] devlink: Add support for creating region snapshots Alex Vesker
2018-07-11 10:43 ` [PATCH net-next v2 04/11] devlink: Add support for region get command Alex Vesker
2018-07-11 18:52 ` Jakub Kicinski [this message]
2018-07-11 10:43 ` [PATCH net-next v2 05/11] devlink: Extend the support querying for region snapshot IDs Alex Vesker
2018-07-11 10:43 ` [PATCH net-next v2 06/11] devlink: Add support for region snapshot delete command Alex Vesker
2018-07-11 10:43 ` [PATCH net-next v2 07/11] devlink: Add support for region snapshot read command Alex Vesker
2018-07-11 10:43 ` [PATCH net-next v2 08/11] net/mlx4_core: Add health buffer address capability Alex Vesker
2018-07-11 10:43 ` [PATCH net-next v2 09/11] net/mlx4_core: Add Crdump FW snapshot support Alex Vesker
2018-07-11 10:43 ` [PATCH net-next v2 10/11] devlink: Add generic parameters region_snapshot Alex Vesker
2018-07-11 10:43 ` [PATCH net-next v2 11/11] net/mlx4_core: Use devlink region_snapshot parameter Alex Vesker
2018-07-11 18:48 ` [PATCH net-next v2 00/11] devlink: Add support for region access Jakub Kicinski
2018-07-11 18:48 ` Jakub Kicinski
2018-07-12 6:21 ` Alex Vesker
2018-08-15 20:25 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180711115215.716c6802@cakuba.lan \
--to=jakub.kicinski@netronome.com \
--cc=andrew@lunn.ch \
--cc=dsahern@gmail.com \
--cc=jiri@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=rahul.lakkireddy@chelsio.com \
--cc=valex@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.