From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED, USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2858C5CFE7 for ; Wed, 11 Jul 2018 14:25:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6E5AC20BEC for ; Wed, 11 Jul 2018 14:25:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="O2mz1p++" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6E5AC20BEC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388563AbeGKOaF (ORCPT ); Wed, 11 Jul 2018 10:30:05 -0400 Received: from mail.kernel.org ([198.145.29.99]:38732 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387949AbeGKOaF (ORCPT ); Wed, 11 Jul 2018 10:30:05 -0400 Received: from mail.kernel.org (host-091-097-006-190.ewe-ip-backbone.de [91.97.6.190]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 071A120875; Wed, 11 Jul 2018 14:25:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1531319128; bh=4Gaj+pgTH0AL4J19JDI5HLx3/Cz7oDfetzt3l0Jvod0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=O2mz1p++Jl4t9SycgWoKIgEGGmVUYAw+tWcfDBLISJ+SUMPegjbh/mlmQKg6bmGAF jzoL2QwqRlXTriaalK9tX5LlrnE/apKksfqODNma6MImK5R8boG0C7QRxw1aG5QffA 9yAK0fJRINJfwK3t1jDVIwMlWNb7eVLp/DSvaDK8= Date: Wed, 11 Jul 2018 16:25:26 +0200 From: Sebastian Reichel To: Tony Lindgren Cc: Pavel Machek , kernel list , linux-arm-kernel , linux-omap@vger.kernel.org, nekit1000@gmail.com, mpartap@gmx.net, merlijn@wizzup.org Subject: Re: Vibrations on Droid 4? Message-ID: <20180711142526.dto6iost57zx5t5l@earth.universe> References: <20180709081534.GA6799@amd> <20180709214910.tes6u4ivxomd3aja@earth.universe> <20180709220211.GA7760@amd> <20180710101147.lyu65ro4czvrs2da@earth.universe> <20180710133040.GA4391@amd> <20180710161123.azym6sbboriuj4yc@earth.universe> <20180711080218.GA21225@amd> <20180711132739.GL99251@atomide.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="nh3alkkyqinnafhb" Content-Disposition: inline In-Reply-To: <20180711132739.GL99251@atomide.com> User-Agent: NeoMutt/20180512 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --nh3alkkyqinnafhb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Wed, Jul 11, 2018 at 06:27:39AM -0700, Tony Lindgren wrote: > * Pavel Machek [180711 08:05]: > > Hi! > >=20 > > > > Its parent is gpio@4805d000 , and that one seems to be present. > > > >=20 > > > > user@devuan:/sys/bus/platform/devices$ ls 4805d000.gpio > > > > driver driver_override gpio > > > > gpiochip5 modalias of_node power subsystem uevent > > >=20 > > > Sorry, something went wrong with merging this. The parent > > > of ti,omap-dmtimer-pwm and pwm-vibrator should be / and > > > not gpio6. > >=20 > > Ok, got it to probe... after dts fix and adding EPROBE_DEFFER to > > driver. > .. > > --- a/arch/arm/boot/dts/omap4-droid4-xt894.dts > > +++ b/arch/arm/boot/dts/omap4-droid4-xt894.dts > > @@ -159,13 +159,7 @@ > > =20 > > dais =3D <&mcbsp2_port>, <&mcbsp3_port>; > > }; > > -}; > > - > > -&dss { > > - status =3D "okay"; > > -}; > > =20 > > -&gpio6 { > > pwm8: dmtimer-pwm-8 { > > pinctrl-names =3D "default"; > > pinctrl-0 =3D <&vibrator_direction_pin>; > > @@ -192,7 +186,10 @@ > > pwm-names =3D "enable", "direction"; > > direction-duty-cycle-ns =3D <10000000>; > > }; > > +}; > > =20 > > +&dss { > > + status =3D "okay"; > > }; > > =20 > > &dsi1 { >=20 > Hmm sorry if I did a mismerge on the above. A note to > myself to stop applying patches that apply with fuzz, > that is clearly dangerous with dts files with lots > of similar named properties. It might also have been me doing the mismerge before sending the patch. Anyways, the patch from Pavel looks good to me. As a side-effect dss and dsi references come next to each other. -- Sebastian --nh3alkkyqinnafhb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAltGE1IACgkQ2O7X88g7 +prRQg//TVVAlEp2acCJvfFGnm3G8BHqpenYb/ijA3ili2taxLYGAGKAdkM4CAiZ hqRMSUw7s2OhKGnyXxK+7OGVxeTlzDJYA0kEVvW+d7yFgmEpKYovkMYEiGSUZVlV 5ZOCFdju+QNgo/WBfp/GcWFcFZC02faxbsrniz3kANkIlFA7bAjGMcc+8SjkwgEC 76BiMYSX/IOst1bxlaMjuM6YWPyDvPfDlweZhmVo9C6+VoukjRZYOd2q/VdxTNFE JFh6zKlJcLwjog857V7XzshiZA3ZvfzE+6ioEqRlCdFAx+QP/v7kZRmtGn5y5Zla 2CNrcw1XSrfrWQqkV249SZFSFFU7Zczv2ik8zgqq7lO4UUxh7Gtqi9xbN60M/upo w8pnikOQZHdZIEdozJbLZD9Z96BMiUT6kMlC2E2IwTlYPBCh/nP4gpXaK2lh+lMx 2JN2WX29d8iuHbZcMO18a8zTSgs6A2V/Z8HxPmB0oN6irWTWk5NCk1phuWK5948r HkmZvrsCtV7A7mAapnLIGtUALXMP3oMstUFSCOgw3RLoDg6D3FtzlpWCz4UQ8CT8 RKJsYymQly04KCxzHGMvYMry1Hg/+ASqZlYWYybzxZG/RniUolg/pdBv1dZJWhnA tVeOxE0+FHr1SfFMgUVrprmJbT3cCNq2BnFxiqpk55G/mNBo1DI= =0tye -----END PGP SIGNATURE----- --nh3alkkyqinnafhb-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: sre@kernel.org (Sebastian Reichel) Date: Wed, 11 Jul 2018 16:25:26 +0200 Subject: Vibrations on Droid 4? In-Reply-To: <20180711132739.GL99251@atomide.com> References: <20180709081534.GA6799@amd> <20180709214910.tes6u4ivxomd3aja@earth.universe> <20180709220211.GA7760@amd> <20180710101147.lyu65ro4czvrs2da@earth.universe> <20180710133040.GA4391@amd> <20180710161123.azym6sbboriuj4yc@earth.universe> <20180711080218.GA21225@amd> <20180711132739.GL99251@atomide.com> Message-ID: <20180711142526.dto6iost57zx5t5l@earth.universe> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, On Wed, Jul 11, 2018 at 06:27:39AM -0700, Tony Lindgren wrote: > * Pavel Machek [180711 08:05]: > > Hi! > > > > > > Its parent is gpio at 4805d000 , and that one seems to be present. > > > > > > > > user at devuan:/sys/bus/platform/devices$ ls 4805d000.gpio > > > > driver driver_override gpio > > > > gpiochip5 modalias of_node power subsystem uevent > > > > > > Sorry, something went wrong with merging this. The parent > > > of ti,omap-dmtimer-pwm and pwm-vibrator should be / and > > > not gpio6. > > > > Ok, got it to probe... after dts fix and adding EPROBE_DEFFER to > > driver. > .. > > --- a/arch/arm/boot/dts/omap4-droid4-xt894.dts > > +++ b/arch/arm/boot/dts/omap4-droid4-xt894.dts > > @@ -159,13 +159,7 @@ > > > > dais = <&mcbsp2_port>, <&mcbsp3_port>; > > }; > > -}; > > - > > -&dss { > > - status = "okay"; > > -}; > > > > -&gpio6 { > > pwm8: dmtimer-pwm-8 { > > pinctrl-names = "default"; > > pinctrl-0 = <&vibrator_direction_pin>; > > @@ -192,7 +186,10 @@ > > pwm-names = "enable", "direction"; > > direction-duty-cycle-ns = <10000000>; > > }; > > +}; > > > > +&dss { > > + status = "okay"; > > }; > > > > &dsi1 { > > Hmm sorry if I did a mismerge on the above. A note to > myself to stop applying patches that apply with fuzz, > that is clearly dangerous with dts files with lots > of similar named properties. It might also have been me doing the mismerge before sending the patch. Anyways, the patch from Pavel looks good to me. As a side-effect dss and dsi references come next to each other. -- Sebastian -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: not available URL: