From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH v4 net-next 19/19] net/mlx5e: Kconfig, mutually exclude compilation of TLS and IPsec accel Date: Thu, 12 Jul 2018 17:44:00 -0700 (PDT) Message-ID: <20180712.174400.1595251769011299658.davem@davemloft.net> References: <1531423557-30926-1-git-send-email-borisp@mellanox.com> <1531423557-30926-20-git-send-email-borisp@mellanox.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, davejwatson@fb.com, aviadye@mellanox.com, saeedm@mellanox.com To: borisp@mellanox.com Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:46052 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387803AbeGMA4F (ORCPT ); Thu, 12 Jul 2018 20:56:05 -0400 In-Reply-To: <1531423557-30926-20-git-send-email-borisp@mellanox.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Boris Pismenny Date: Thu, 12 Jul 2018 22:25:57 +0300 > We currently have no devices that support both TLS and IPsec using the > accel framework, and the current code does not support both IPsec and > TLS. This patch prevents such combinations. > > Signed-off-by: Boris Pismenny > --- > drivers/net/ethernet/mellanox/mlx5/core/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/Kconfig b/drivers/net/ethernet/mellanox/mlx5/core/Kconfig > index 2545296..d3e8c70 100644 > --- a/drivers/net/ethernet/mellanox/mlx5/core/Kconfig > +++ b/drivers/net/ethernet/mellanox/mlx5/core/Kconfig > @@ -93,6 +93,7 @@ config MLX5_EN_TLS > depends on TLS_DEVICE > depends on TLS=y || MLX5_CORE=m > depends on MLX5_ACCEL > + depends on !MLX5_EN_IPSEC > default n You absolutely cannot do this. You are forcing a distribution to pick one offload or the other at build time, that's insane. Please find a way to support both offloads in the driver. It is absolutely valid for a distribution to ship the driver in a state that supports both offloads and you must therefore support this properly. Thank you.