From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44449) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fdQPU-000295-H0 for qemu-devel@nongnu.org; Wed, 11 Jul 2018 21:28:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fdQPT-0002le-Gh for qemu-devel@nongnu.org; Wed, 11 Jul 2018 21:28:44 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:51726 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fdQPT-0002lC-BC for qemu-devel@nongnu.org; Wed, 11 Jul 2018 21:28:43 -0400 From: Fam Zheng Date: Thu, 12 Jul 2018 09:28:26 +0800 Message-Id: <20180712012829.20231-2-famz@redhat.com> In-Reply-To: <20180712012829.20231-1-famz@redhat.com> References: <20180712012829.20231-1-famz@redhat.com> Subject: [Qemu-devel] [PATCH v3 1/4] tests: Add an option for snapshot (default: off) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: pbonzini@redhat.com, Fam Zheng , =?UTF-8?q?Alex=20Benn=C3=A9e?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Not using snapshot has the benefit of automatically persisting useful test harnesses, such as docker images and ccache database. Although it will lose some cleanness, it is imaginably useful for patchew. Signed-off-by: Fam Zheng --- tests/vm/basevm.py | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/tests/vm/basevm.py b/tests/vm/basevm.py index 3643117816..e5d6a328d5 100755 --- a/tests/vm/basevm.py +++ b/tests/vm/basevm.py @@ -216,6 +216,8 @@ def parse_args(vm_name): help="build QEMU from source in guest") parser.add_option("--interactive", "-I", action="store_true", help="Interactively run command") + parser.add_option("--snapshot", "-s", action="store_true", + help="run tests with a snapshot") parser.disable_interspersed_args() return parser.parse_args() @@ -241,7 +243,10 @@ def main(vmcls): jobs=args.jobs)] else: cmd = argv - vm.boot(args.image + ",snapshot=on") + img = args.image + if args.snapshot: + img += ",snapshot=on" + vm.boot(img) vm.wait_ssh() except Exception as e: if isinstance(e, SystemExit) and e.code == 0: -- 2.17.1