From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D244C43A1D for ; Thu, 12 Jul 2018 06:35:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 59C86204EC for ; Thu, 12 Jul 2018 06:35:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 59C86204EC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732271AbeGLGnQ (ORCPT ); Thu, 12 Jul 2018 02:43:16 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:38834 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726770AbeGLGnQ (ORCPT ); Thu, 12 Jul 2018 02:43:16 -0400 Received: from localhost (LFbn-1-12247-202.w90-92.abo.wanadoo.fr [90.92.61.202]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 4D626C37; Thu, 12 Jul 2018 06:35:08 +0000 (UTC) Date: Thu, 12 Jul 2018 08:35:06 +0200 From: Greg Kroah-Hartman To: Pawel Laszczak Cc: "linux-usb@vger.kernel.org" , Felipe Balbi , "linux-kernel@vger.kernel.org" , Lukasz Tyrala , Alan Douglas Subject: Re: [PATCH 02/31] usb: usbssp: Added some decoding functions. Message-ID: <20180712063506.GA25007@kroah.com> References: <1531374448-26532-1-git-send-email-pawell@cadence.com> <1531374448-26532-3-git-send-email-pawell@cadence.com> <20180712061030.GB20905@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.0 (2018-05-17) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 12, 2018 at 06:28:33AM +0000, Pawel Laszczak wrote: > > > This patch add additional functions that converts some fields to string. > > > > > > For example function usbssp_trb_comp_code_string take completion c ode > > > value and return string describing completion code. > > > > Odd line-wrapping :( > Do you mean additional space character between "c" and "ode" It wrapped lines at that point for me, yes. > > And why do you want a string for these things? Who cares about them? > It will be used in next version of driver. I have plan to add gadget-debugfs.c file. > At this moment this functions can be useful during debugging driver if someone want to display > some debug information. > > Should I remove this function ? If no one is using it now, yes, it does not need to be there, right? We don't have dead code around for no reason, otherwise someone will come along and remove it :) thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [02/31] usb: usbssp: Added some decoding functions. From: Greg Kroah-Hartman Message-Id: <20180712063506.GA25007@kroah.com> Date: Thu, 12 Jul 2018 08:35:06 +0200 To: Pawel Laszczak Cc: "linux-usb@vger.kernel.org" , Felipe Balbi , "linux-kernel@vger.kernel.org" , Lukasz Tyrala , Alan Douglas List-ID: T24gVGh1LCBKdWwgMTIsIDIwMTggYXQgMDY6Mjg6MzNBTSArMDAwMCwgUGF3ZWwgTGFzemN6YWsg d3JvdGU6Cj4gPiA+IFRoaXMgcGF0Y2ggYWRkIGFkZGl0aW9uYWwgZnVuY3Rpb25zIHRoYXQgY29u dmVydHMgc29tZSBmaWVsZHMgdG8gc3RyaW5nLgo+ID4gPgo+ID4gPiBGb3IgZXhhbXBsZSBmdW5j dGlvbiB1c2Jzc3BfdHJiX2NvbXBfY29kZV9zdHJpbmcgdGFrZSBjb21wbGV0aW9uIGMgb2RlCj4g PiA+IHZhbHVlIGFuZCByZXR1cm4gc3RyaW5nIGRlc2NyaWJpbmcgY29tcGxldGlvbiBjb2RlLgo+ ID4gCj4gPiBPZGQgbGluZS13cmFwcGluZyA6KAo+IERvIHlvdSBtZWFuIGFkZGl0aW9uYWwgc3Bh Y2UgY2hhcmFjdGVyIGJldHdlZW4gImMiIGFuZCAib2RlIgoKSXQgd3JhcHBlZCBsaW5lcyBhdCB0 aGF0IHBvaW50IGZvciBtZSwgeWVzLgoKPiA+IEFuZCB3aHkgZG8geW91IHdhbnQgYSBzdHJpbmcg Zm9yIHRoZXNlIHRoaW5ncz8gIFdobyBjYXJlcyBhYm91dCB0aGVtPwo+IEl0IHdpbGwgYmUgdXNl ZCBpbiBuZXh0IHZlcnNpb24gb2YgZHJpdmVyLiBJIGhhdmUgcGxhbiB0byBhZGQgZ2FkZ2V0LWRl YnVnZnMuYyBmaWxlLgo+IEF0IHRoaXMgbW9tZW50IHRoaXMgZnVuY3Rpb25zIGNhbiBiZSB1c2Vm dWwgZHVyaW5nIGRlYnVnZ2luZyBkcml2ZXIgaWYgc29tZW9uZSB3YW50IHRvIGRpc3BsYXkKPiBz b21lIGRlYnVnIGluZm9ybWF0aW9uLiAKPiAKPiBTaG91bGQgSSByZW1vdmUgdGhpcyBmdW5jdGlv biA/CgpJZiBubyBvbmUgaXMgdXNpbmcgaXQgbm93LCB5ZXMsIGl0IGRvZXMgbm90IG5lZWQgdG8g YmUgdGhlcmUsIHJpZ2h0PyAgV2UKZG9uJ3QgaGF2ZSBkZWFkIGNvZGUgYXJvdW5kIGZvciBubyBy ZWFzb24sIG90aGVyd2lzZSBzb21lb25lIHdpbGwgY29tZQphbG9uZyBhbmQgcmVtb3ZlIGl0IDop Cgp0aGFua3MsCgpncmVnIGstaAotLS0KVG8gdW5zdWJzY3JpYmUgZnJvbSB0aGlzIGxpc3Q6IHNl bmQgdGhlIGxpbmUgInVuc3Vic2NyaWJlIGxpbnV4LXVzYiIgaW4KdGhlIGJvZHkgb2YgYSBtZXNz YWdlIHRvIG1ham9yZG9tb0B2Z2VyLmtlcm5lbC5vcmcKTW9yZSBtYWpvcmRvbW8gaW5mbyBhdCAg aHR0cDovL3ZnZXIua2VybmVsLm9yZy9tYWpvcmRvbW8taW5mby5odG1sCg==