Hi Aapo, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on tegra/for-next] [also build test WARNING on v4.18-rc4 next-20180711] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Aapo-Vienamo/soc-tegra-pmc-Fix-pad-voltage-configuration-for-Tegra186/20180712-053245 base: https://git.kernel.org/pub/scm/linux/kernel/git/tegra/linux.git for-next config: i386-allmodconfig (attached as .config) compiler: gcc-7 (Debian 7.3.0-16) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 All warnings (new ones prefixed by >>): In file included from drivers/pci/controller/pci-tegra.c:41:0: >> include/soc/tegra/pmc.h:205:14: warning: 'enum tegra_io_pad_voltage' declared inside parameter list will not be visible outside of this definition or declaration enum tegra_io_pad_voltage voltage) ^~~~~~~~~~~~~~~~~~~~ include/soc/tegra/pmc.h:205:35: error: parameter 2 ('voltage') has incomplete type enum tegra_io_pad_voltage voltage) ^~~~~~~ include/soc/tegra/pmc.h:204:19: error: function declaration isn't a prototype [-Werror=strict-prototypes] static inline int tegra_io_pad_set_voltage(enum tegra_io_pad id, ^~~~~~~~~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors vim +205 include/soc/tegra/pmc.h 21b49910 Laxman Dewangan 2016-10-10 203 21b49910 Laxman Dewangan 2016-10-10 204 static inline int tegra_io_pad_set_voltage(enum tegra_io_pad id, 21b49910 Laxman Dewangan 2016-10-10 @205 enum tegra_io_pad_voltage voltage) 21b49910 Laxman Dewangan 2016-10-10 206 { 21b49910 Laxman Dewangan 2016-10-10 207 return -ENOSYS; 21b49910 Laxman Dewangan 2016-10-10 208 } 21b49910 Laxman Dewangan 2016-10-10 209 :::::: The code at line 205 was first introduced by commit :::::: 21b4991051780b49b217c363f79366ed94c3b4b7 soc/tegra: pmc: Add I/O pad voltage support :::::: TO: Laxman Dewangan :::::: CC: Thierry Reding --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation