All of lore.kernel.org
 help / color / mirror / Atom feed
From: Igor Mammedov <imammedo@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Stefan Hajnoczi <stefanha@redhat.com>,
	l00284672 <lizhengui@huawei.com>, Fam Zheng <famz@redhat.com>,
	qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/2] qdev: add HotplugHandler->post_plug() callback
Date: Thu, 12 Jul 2018 11:04:19 +0200	[thread overview]
Message-ID: <20180712110419.685f0d04@redhat.com> (raw)
In-Reply-To: <759f6dde-7350-70b9-1867-d2d1781df16b@redhat.com>

On Wed, 11 Jul 2018 18:48:21 +0200
Paolo Bonzini <pbonzini@redhat.com> wrote:

> On 11/07/2018 17:22, Igor Mammedov wrote:
> > It also seems wrong to call _plug handler on maybe partially
> > initialized device so perhaps we should first finish devices/children
> > realization then do reset and only after that call _plug() handler  
> 
> I agree but this is too dangerous until we look at plug() handlers and
I'll put on my TODO list for 3.1

> remove the usage of Error **.
considering we have _per_plug now with all checks, we probably
would be able to remove Error** from _plug but only after splitting/auditing
existing _plug callbacks.

>  Introducing a new callback helps the
> transition.
sure, we can drop it later

> Paolo
> 

  reply	other threads:[~2018-07-12  9:04 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-10 15:50 [Qemu-devel] [PATCH 0/2] virtio-scsi: fix hotplug ->reset() vs event race Stefan Hajnoczi
2018-07-10 15:50 ` [Qemu-devel] [PATCH 1/2] qdev: add HotplugHandler->post_plug() callback Stefan Hajnoczi
2018-07-11 11:01   ` Paolo Bonzini
2018-07-11 13:29   ` Stefan Hajnoczi
2018-07-11 13:32     ` Paolo Bonzini
2018-07-11 14:15       ` Igor Mammedov
2018-07-11 15:22   ` Igor Mammedov
2018-07-11 16:48     ` Paolo Bonzini
2018-07-12  9:04       ` Igor Mammedov [this message]
2018-07-10 15:50 ` [Qemu-devel] [PATCH 2/2] virtio-scsi: fix hotplug ->reset() vs event race Stefan Hajnoczi
2018-07-11  1:43 ` [Qemu-devel] [PATCH 0/2] " Fam Zheng
2018-07-11  3:13 ` l00284672

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180712110419.685f0d04@redhat.com \
    --to=imammedo@redhat.com \
    --cc=famz@redhat.com \
    --cc=lizhengui@huawei.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.