From: Daniel Kiper <dkiper@net-space.pl>
To: The development of GNU GRUB <grub-devel@gnu.org>
Cc: Goffredo Baroncelli <kreijack@inwind.it>
Subject: Re: [PATCH 6/9] btrfs: Refactor the code that read from disk
Date: Thu, 12 Jul 2018 16:10:55 +0200 [thread overview]
Message-ID: <20180712141055.GF7005@router-fw-old.local.net-space.pl> (raw)
In-Reply-To: <20180619173956.7356-7-kreijack@inwind.it>
On Tue, Jun 19, 2018 at 07:39:53PM +0200, Goffredo Baroncelli wrote:
> Move the code in charge to read the data from disk into a separate
> function. This helps to separate the error handling logic (which depend on
s/depend/depends/
> the different raid profiles) from the read from disk logic.
> Refactoring this code increases the general readability too.
>
> This is a preparatory patch, to help the adding of the RAID 5/6 recovery
> code.
>
> Signed-off-by: Goffredo Baroncelli <kreijack@inwind.it>
Otherwise, Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
Daniel
next prev parent reply other threads:[~2018-07-12 14:11 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-19 17:39 [PATCH V6] Add support for BTRFS raid5/6 to GRUB Goffredo Baroncelli
2018-06-19 17:39 ` [PATCH 1/9] btrfs: Add support for reading a filesystem with a RAID 5 or RAID 6 profile Goffredo Baroncelli
2018-07-08 15:51 ` Goffredo Baroncelli
2018-07-09 10:20 ` Daniel Kiper
2018-07-09 16:29 ` Goffredo Baroncelli
2018-07-12 13:46 ` Daniel Kiper
2018-07-18 6:24 ` Goffredo Baroncelli
2018-09-03 12:52 ` Daniel Kiper
2018-06-19 17:39 ` [PATCH 2/9] btrfs: Add helper to check the btrfs header Goffredo Baroncelli
2018-07-12 13:50 ` Daniel Kiper
2018-06-19 17:39 ` [PATCH 3/9] btrfs: Move the error logging from find_device() to its caller Goffredo Baroncelli
2018-07-12 13:51 ` Daniel Kiper
2018-06-19 17:39 ` [PATCH 5/9] btrfs: Move logging code in grub_btrfs_read_logical() Goffredo Baroncelli
2018-07-12 14:06 ` Daniel Kiper
2018-06-19 17:39 ` [PATCH 6/9] btrfs: Refactor the code that read from disk Goffredo Baroncelli
2018-07-12 14:10 ` Daniel Kiper [this message]
2018-06-19 17:39 ` [PATCH 7/9] btrfs: Add support for recovery for a RAID 5 btrfs profiles Goffredo Baroncelli
2018-07-12 14:35 ` Daniel Kiper
2018-06-19 17:39 ` [PATCH 8/9] btrfs: Make more generic the code for RAID 6 rebuilding Goffredo Baroncelli
2018-07-12 14:41 ` Daniel Kiper
2018-06-19 17:39 ` [PATCH 9/9] btrfs: Add RAID 6 recovery for a btrfs filesystem Goffredo Baroncelli
2018-07-12 14:47 ` Daniel Kiper
2018-06-19 18:22 ` [PATCH 4/9] btrfs: Avoid a rescan for a device which was already not found Goffredo Baroncelli
2018-07-12 14:02 ` Daniel Kiper
2018-07-18 18:59 ` Goffredo Baroncelli
-- strict thread matches above, loose matches on Subject: below --
2018-10-22 17:29 [PATCH V11] Add support for BTRFS raid5/6 to GRUB Goffredo Baroncelli
2018-10-22 17:29 ` [PATCH 6/9] btrfs: Refactor the code that read from disk Goffredo Baroncelli
2018-10-18 17:55 [PATCH V10] Add support for BTRFS raid5/6 to GRUB Goffredo Baroncelli
2018-10-18 17:55 ` [PATCH 6/9] btrfs: Refactor the code that read from disk Goffredo Baroncelli
2018-10-11 18:50 [PATCH V9] Add support for BTRFS raid5/6 to GRUB Goffredo Baroncelli
2018-10-11 18:51 ` [PATCH 6/9] btrfs: Refactor the code that read from disk Goffredo Baroncelli
2018-09-27 18:34 [PATCH V8] Add support for BTRFS raid5/6 to GRUB Goffredo Baroncelli
2018-09-27 18:35 ` [PATCH 6/9] btrfs: Refactor the code that read from disk Goffredo Baroncelli
2018-09-19 18:40 [PATCH V7] Add support for BTRFS raid5/6 to GRUB Goffredo Baroncelli
2018-09-19 18:40 ` [PATCH 6/9] btrfs: Refactor the code that read from disk Goffredo Baroncelli
2018-06-03 18:53 [PATCH V5] Add support for BTRFS raid5/6 to GRUB Goffredo Baroncelli
2018-06-03 18:53 ` [PATCH 6/9] btrfs: Refactor the code that read from disk Goffredo Baroncelli
2018-06-14 12:38 ` Daniel Kiper
2018-05-16 18:48 [PATCH V4] Add support for BTRFS raid5/6 to GRUB Goffredo Baroncelli
2018-05-16 18:48 ` [PATCH 6/9] btrfs: refactor the code that read from disk Goffredo Baroncelli
2018-05-30 11:07 ` Daniel Kiper
2018-06-01 18:50 ` Goffredo Baroncelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180712141055.GF7005@router-fw-old.local.net-space.pl \
--to=dkiper@net-space.pl \
--cc=grub-devel@gnu.org \
--cc=kreijack@inwind.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.