From: Josh Poimboeuf <jpoimboe@redhat.com>
To: speck@linutronix.de
Subject: [MODERATED] Re: [patch V10 08/10] Control knobs and Documentation 8
Date: Thu, 12 Jul 2018 11:22:57 -0500 [thread overview]
Message-ID: <20180712162257.ntv44ueudncbabrj@treble> (raw)
In-Reply-To: <20180712142957.626429955@linutronix.de>
On Thu, Jul 12, 2018 at 04:19:10PM +0200, speck for Thomas Gleixner wrote:
> -static int __init smt_cmdline_disable(char *str)
> +void __init cpu_smt_disable(bool force)
> {
> + if (cpu_smt_control == CPU_SMT_FORCE_DISABLED)
Also needs to check for CPU_SMT_NOT_SUPPORTED.
> + return;
> +
> cpu_smt_control = CPU_SMT_DISABLED;
> - if (str && !strcmp(str, "force")) {
> + if (force) {
> pr_info("SMT: Force disabled\n");
> cpu_smt_control = CPU_SMT_FORCE_DISABLED;
> }
> +}
A bit weird that cpu_smt_control is written to twice in the force case.
An if-else would be clearer.
--
Josh
next prev parent reply other threads:[~2018-07-12 16:23 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-12 14:19 [patch V10 00/10] Control knobs and Documentation 0 Thomas Gleixner
2018-07-12 14:19 ` [patch V10 01/10] Control knobs and Documentation 1 Thomas Gleixner
2018-07-12 15:34 ` [MODERATED] " Greg KH
2018-07-12 15:38 ` Thomas Gleixner
2018-07-12 15:46 ` Thomas Gleixner
2018-07-12 17:08 ` [MODERATED] " Greg KH
2018-07-12 14:19 ` [patch V10 02/10] Control knobs and Documentation 2 Thomas Gleixner
2018-07-12 17:09 ` [MODERATED] " Greg KH
2018-07-12 14:19 ` [patch V10 03/10] Control knobs and Documentation 3 Thomas Gleixner
2018-07-12 16:13 ` [MODERATED] " Josh Poimboeuf
2018-07-13 9:10 ` Thomas Gleixner
2018-07-12 17:09 ` [MODERATED] " Greg KH
2018-07-12 14:19 ` [patch V10 04/10] Control knobs and Documentation 4 Thomas Gleixner
2018-07-12 17:10 ` [MODERATED] " Greg KH
2018-07-12 14:19 ` [patch V10 05/10] Control knobs and Documentation 5 Thomas Gleixner
2018-07-12 17:10 ` [MODERATED] " Greg KH
2018-07-12 14:19 ` [patch V10 06/10] Control knobs and Documentation 6 Thomas Gleixner
2018-07-12 16:14 ` [MODERATED] " Josh Poimboeuf
2018-07-12 17:10 ` Greg KH
2018-07-12 14:19 ` [patch V10 07/10] Control knobs and Documentation 7 Thomas Gleixner
2018-07-12 17:11 ` [MODERATED] " Greg KH
2018-07-12 14:19 ` [patch V10 08/10] Control knobs and Documentation 8 Thomas Gleixner
2018-07-12 16:22 ` Josh Poimboeuf [this message]
2018-07-12 17:12 ` [MODERATED] " Greg KH
2018-07-13 9:18 ` Thomas Gleixner
2018-07-12 17:17 ` [MODERATED] " Greg KH
2018-07-12 14:19 ` [patch V10 09/10] Control knobs and Documentation 9 Thomas Gleixner
2018-07-12 16:24 ` [MODERATED] " Josh Poimboeuf
2018-07-12 17:17 ` Greg KH
2018-07-12 17:16 ` Greg KH
2018-07-15 3:12 ` Kees Cook
2018-07-12 14:19 ` [patch V10 10/10] Control knobs and Documentation 10 Thomas Gleixner
2018-07-12 16:03 ` [MODERATED] " Linus Torvalds
2018-07-12 16:31 ` Peter Zijlstra
2018-07-12 16:13 ` Josh Poimboeuf
2018-07-12 16:26 ` Josh Poimboeuf
2018-07-13 9:09 ` Thomas Gleixner
2018-07-12 17:18 ` [MODERATED] " Greg KH
2018-07-15 7:30 ` Borislav Petkov
2018-07-27 16:41 ` Dave Hansen
2018-07-12 14:54 ` [patch V10 00/10] Control knobs and Documentation 0 Thomas Gleixner
2018-07-12 19:30 ` [MODERATED] " Josh Poimboeuf
2018-07-13 15:03 ` Thomas Gleixner
2018-07-13 8:30 ` [MODERATED] " Jiri Kosina
2018-07-13 16:22 ` Paolo Bonzini
2018-07-13 16:56 ` Andrew Cooper
2018-07-13 17:01 ` Paolo Bonzini
2018-07-13 17:28 ` Konrad Rzeszutek Wilk
2018-07-15 13:58 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180712162257.ntv44ueudncbabrj@treble \
--to=jpoimboe@redhat.com \
--cc=speck@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.