From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linutronix.de (146.0.238.70:993) by crypto-ml.lab.linutronix.de with IMAP4-SSL for ; 12 Jul 2018 19:30:58 -0000 Received: from mx3-rdu2.redhat.com ([66.187.233.73] helo=mx1.redhat.com) by Galois.linutronix.de with esmtps (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1fdhIm-0004Ro-Rp for speck@linutronix.de; Thu, 12 Jul 2018 21:30:57 +0200 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BA136818BAF3 for ; Thu, 12 Jul 2018 19:30:49 +0000 (UTC) Received: from treble (ovpn-122-49.rdu2.redhat.com [10.10.122.49]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 96E5D1C67B for ; Thu, 12 Jul 2018 19:30:49 +0000 (UTC) Date: Thu, 12 Jul 2018 14:30:48 -0500 From: Josh Poimboeuf Subject: [MODERATED] Re: [patch V10 00/10] Control knobs and Documentation 0 Message-ID: <20180712193048.2f57ta7vnaie2672@treble> References: <20180712141902.576562442@linutronix.de> MIME-Version: 1.0 In-Reply-To: <20180712141902.576562442@linutronix.de> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit To: speck@linutronix.de List-ID: On Thu, Jul 12, 2018 at 04:19:02PM +0200, speck for Thomas Gleixner wrote: > The following series provides the following changes: > > - Fix EPT=off handling so it avoids flushing > > - Expose proper VMX mitigation information in sysfs > > - Drops the MSR list mechanism for flush 'always' to prepare for runtime > control. The default flush mechanism is conditional anyway and the MSR > list is set up at guest init time, which is nasty to run time switch > especially because the static key is a global control which can be > flipped by an update. > > - Make the flush always/conditional static key based. > > - Serialize the kvm parameter setter function > > - Enable runtime control for the kvm parameter > > - Add the l1tf command line option. It's not run time controllable as it > does not make sense to have 3 knobs at runtime. For the command line > the combo knob setting the default is convenient > > - Documentation update > > This takes the review comments into account as much as still applicable. > > Thanks to Jiri for testing the lot and debugging and fixing my brainfarts! > > Git bundle follows in separate mail. It looks great to me (other than the few minor issues I already pointed out). Reviewed-by: Josh Poimboeuf -- Josh