From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH mlx5-next v1 2/8] net/mlx5: Add support for flow table destination number Date: Thu, 12 Jul 2018 16:05:56 -0600 Message-ID: <20180712220555.GV30390@mellanox.com> References: <20180711111045.6282-1-leon@kernel.org> <20180711111045.6282-3-leon@kernel.org> <20180712212618.GS30390@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org To: Or Gerlitz Cc: Yishai Hadas , Doug Ledford , Leon Romanovsky , RDMA mailing list , Saeed Mahameed , linux-netdev List-Id: linux-rdma@vger.kernel.org On Fri, Jul 13, 2018 at 12:51:10AM +0300, Or Gerlitz wrote: > On Fri, Jul 13, 2018 at 12:26 AM, Jason Gunthorpe wrote: > > On Fri, Jul 13, 2018 at 12:00:41AM +0300, Or Gerlitz wrote: > >> On Wed, Jul 11, 2018 at 2:10 PM, Leon Romanovsky wrote: > >> > From: Yishai Hadas > >> > > >> > Add support to set a destination from a flow table number. > >> > This functionality will be used in downstream patches from this > >> > series by the DEVX stuff. > >> > >> Reading your cover letter, I still don't understand what is missing > >> in the current mlx5 fs core API for your needs. After all, you do > >> create flow tables from the IB driver through fs core calls, right? > >> so @ the end of the day, you have the FT pointer to provide the > >> core, why you need the FT number? > > > > Via the devx API userspace can create flow tables directly without > > going to the driver's flow steering core. > > so why you change the core? User space flow tables don't get any traffic until they are linked into the main steering. The only ID the kernel gets for them when adding this link is the actual PRM handle, not a pointer - hence the change. Jason