From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tiwei Bie <tiwei.bie@intel.com>
Subject: Re: [PATCH v2 5/7] eal: bring forward init of interrupt
 handling
Date: Fri, 13 Jul 2018 17:10:43 +0800
Message-ID: <20180713091042.GA21549@debian>
References: <cover.1530009564.git.anatoly.burakov@intel.com>
 <5f6bc60bf193daf4eb07f4484c52878bb1b751de.1530009564.git.anatoly.burakov@intel.com>
 <5431396.k1M6VaMcRs@xps>
 <CALwxeUvx2UXSQLTQrSiBZvOEEqmgz9NBUxnEPxJndLcdb_2w3Q@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Cc: Thomas Monjalon <thomas@monjalon.net>,
 Anatoly Burakov <anatoly.burakov@intel.com>, dev@dpdk.org,
 Jianfeng Tan <jianfeng.tan@intel.com>,
 Bruce Richardson <bruce.richardson@intel.com>,
 "Ananyev, Konstantin" <konstantin.ananyev@intel.com>, qi.z.zhang@intel.com,
 Stephen Hemminger <stephen@networkplumber.org>,
 Olivier Matz <olivier.matz@6wind.com>,
 Ferruh Yigit <ferruh.yigit@intel.com>,
 Maxime Coquelin <maxime.coquelin@redhat.com>
To: David Marchand <david.marchand@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id 2855A1B057
 for <dev@dpdk.org>; Fri, 13 Jul 2018 11:11:03 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <CALwxeUvx2UXSQLTQrSiBZvOEEqmgz9NBUxnEPxJndLcdb_2w3Q@mail.gmail.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, Jul 13, 2018 at 10:09:42AM +0200, David Marchand wrote:
[...]
> Well, there was an issue vith virtio at one time (interrupt handler
> did not have the right iopl for virtio callback).
> http://git.dpdk.org/dpdk/commit/lib/librte_eal/linuxapp/eal/eal.c?id=fd6949c55c9a48e81c625138679159829d51ac51
> 
> Now... time has passed since then.
> It is worth checking the issue is still here, and if it is the case,
> revisit this.

Now rte_virtio_pmd_init() which calls rte_eal_iopl_init()
is called as a constructor [1], so the issue isn't there
any more.

[1] http://git.dpdk.org/dpdk/tree/drivers/net/virtio/virtio_ethdev.c?id=1d406458db47#n1789

Best regards,
Tiwei Bie

> I suppose virtio pmd should deal with this itself.
> 
> 
> -- 
> David Marchand