All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: cota@braap.org, famz@redhat.com, berrange@redhat.com,
	f4bug@amsat.org, richard.henderson@linaro.org, balrogg@gmail.com,
	aurelien@aurel32.net, agraf@suse.de
Cc: qemu-devel@nongnu.org, "Alex Bennée" <alex.bennee@linaro.org>
Subject: [Qemu-devel] [PATCH v2 for 3.0 12/16] docker: drop QEMU_TARGET check, fallback in EXECUTABLE not set
Date: Fri, 13 Jul 2018 13:17:37 +0100	[thread overview]
Message-ID: <20180713121741.19262-13-alex.bennee@linaro.org> (raw)
In-Reply-To: <20180713121741.19262-1-alex.bennee@linaro.org>

The addition of QEMU_TARGET was intended to ensure we fall back to
checking for the existence of an image if the build system was not
currently configured to build it. However this breaks the direct use
of the rule for building custom binfmt_misc images. We already check
for EXECUTABLE so let us just use that as a proxy for deciding if we
are just going to check the image exits.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 tests/docker/Makefile.include | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include
index e32c35be0d..ec23620153 100644
--- a/tests/docker/Makefile.include
+++ b/tests/docker/Makefile.include
@@ -58,13 +58,11 @@ docker-image-%: $(DOCKER_FILES_DIR)/%.docker
 docker-binfmt-image-debian-%: $(DOCKER_FILES_DIR)/debian-bootstrap.docker
 	$(if $(EXECUTABLE),,\
 		$(error EXECUTABLE not set, debootstrap of debian-$* would fail))
-	$(if $(wildcard $(EXECUTABLE)),,\
-		$(error Please build $(EXECUTABLE) first))
 	$(if $(DEB_ARCH),,\
 		$(error DEB_ARCH not set, debootstrap of debian-$* would fail))
 	$(if $(DEB_TYPE),,\
 		$(error DEB_TYPE not set, debootstrap of debian-$* would fail))
-	$(if $(filter $(QEMU_TARGET),$(TARGET_DIRS)),				\
+	$(if $(wildcard $(EXECUTABLE)),						\
 		$(call quiet-command,						\
 			DEB_ARCH=$(DEB_ARCH)					\
 			DEB_TYPE=$(DEB_TYPE)					\
@@ -136,7 +134,6 @@ DOCKER_PARTIAL_IMAGES += debian-tricore-cross debian-powerpc-cross fedora-i386-c
 # broken so we need a qemu-linux-user for this target
 docker-binfmt-image-debian-powerpc-user: DEB_ARCH = powerpc
 docker-binfmt-image-debian-powerpc-user: DEB_TYPE = jessie
-docker-binfmt-image-debian-powerpc-user: QEMU_TARGET = ppc-linux-user
 docker-binfmt-image-debian-powerpc-user: EXECUTABLE = ${BUILD_DIR}/ppc-linux-user/qemu-ppc
 docker-image-debian-powerpc-user-cross: docker-binfmt-image-debian-powerpc-user
 DOCKER_USER_IMAGES += debian-powerpc-user
-- 
2.17.1

  parent reply	other threads:[~2018-07-13 12:27 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-13 12:17 [Qemu-devel] [PATCH v2 for 3.0 00/16] various docker fixes Alex Bennée
2018-07-13 12:17 ` [Qemu-devel] [PATCH v2 for 3.0 01/16] tests/.gitignore: don't ignore docker tests Alex Bennée
2018-07-13 12:17 ` [Qemu-devel] [PATCH v2 for 3.0 02/16] docker: base debian-tricore on qemu:debian9 Alex Bennée
2018-07-17 14:49   ` Philippe Mathieu-Daudé
2018-07-13 12:17 ` [Qemu-devel] [PATCH v2 for 3.0 03/16] shippable: Build the TriCore docker image Alex Bennée
2018-07-13 13:27   ` Alex Bennée
2018-07-17  2:55     ` Philippe Mathieu-Daudé
2018-07-13 12:17 ` [Qemu-devel] [PATCH v2 for 3.0 04/16] docker: fail more gracefully on docker.py check Alex Bennée
2018-07-13 12:17 ` [Qemu-devel] [PATCH v2 for 3.0 05/16] docker: split configure_qemu from build_qemu Alex Bennée
2018-07-17  2:50   ` Philippe Mathieu-Daudé
2018-07-13 12:17 ` [Qemu-devel] [PATCH v2 for 3.0 06/16] docker: move make check into check_qemu helper Alex Bennée
2018-07-17  3:00   ` Philippe Mathieu-Daudé
2018-07-17  9:59     ` Alex Bennée
2018-07-17 14:56       ` Philippe Mathieu-Daudé
2018-07-13 12:17 ` [Qemu-devel] [PATCH v2 for 3.0 07/16] docker: gracefully skip check_qemu Alex Bennée
2018-07-17  3:02   ` Philippe Mathieu-Daudé
2018-07-17 10:22     ` Alex Bennée
2018-07-17 15:05       ` Philippe Mathieu-Daudé
2018-07-13 12:17 ` [Qemu-devel] [PATCH v2 for 3.0 08/16] docker: Makefile.include don't include partial images Alex Bennée
2018-07-17  3:07   ` Philippe Mathieu-Daudé
2018-07-13 12:17 ` [Qemu-devel] [PATCH v2 for 3.0 09/16] docker: disable debian-powerpc-user-cross Alex Bennée
2018-07-17 15:52   ` Philippe Mathieu-Daudé
2018-07-13 12:17 ` [Qemu-devel] [PATCH v2 for 3.0 10/16] docker: add test-unit runner Alex Bennée
2018-07-17  3:37   ` Philippe Mathieu-Daudé
2018-07-13 12:17 ` [Qemu-devel] [PATCH v2 for 3.0 11/16] docker: add expansion for docker-test-FOO to Makefile.include Alex Bennée
2018-07-16  1:42   ` Philippe Mathieu-Daudé
2018-07-16  9:07     ` Alex Bennée
2018-07-17 15:03       ` Philippe Mathieu-Daudé
2018-07-13 12:17 ` Alex Bennée [this message]
2018-07-17 15:51   ` [Qemu-devel] [PATCH v2 for 3.0 12/16] docker: drop QEMU_TARGET check, fallback in EXECUTABLE not set Philippe Mathieu-Daudé
2018-07-13 12:17 ` [Qemu-devel] [PATCH v2 for 3.0 13/16] docker: add --hint to docker.py check Alex Bennée
2018-07-17  3:24   ` Philippe Mathieu-Daudé
2018-07-17 15:14     ` Philippe Mathieu-Daudé
2018-07-13 12:17 ` [Qemu-devel] [PATCH v2 for 3.0 14/16] docker: Update debootstrap script after Debian migration from Alioth to Salsa Alex Bennée
2018-07-13 12:17 ` [Qemu-devel] [PATCH v2 for 3.0 15/16] docker: add commentary to debian-bootstrap.docker Alex Bennée
2018-07-17 15:02   ` Philippe Mathieu-Daudé
2018-07-13 12:17 ` [Qemu-devel] [PATCH v2 for 3.0 16/16] docker: ignore distro versioning of debootstrap Alex Bennée
2018-07-17 15:52   ` Philippe Mathieu-Daudé
2018-07-17 16:02 ` [Qemu-devel] [PATCH v2 for 3.0 00/16] various docker fixes Philippe Mathieu-Daudé
2018-07-17 18:53   ` Alex Bennée
2018-07-17 20:28     ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180713121741.19262-13-alex.bennee@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=agraf@suse.de \
    --cc=aurelien@aurel32.net \
    --cc=balrogg@gmail.com \
    --cc=berrange@redhat.com \
    --cc=cota@braap.org \
    --cc=f4bug@amsat.org \
    --cc=famz@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.