All of lore.kernel.org
 help / color / mirror / Atom feed
From: kbuild test robot <lkp@intel.com>
To: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
Cc: kbuild-all@01.org, Linus Walleij <linus.walleij@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Subject: Re: [PATCH 2/2] pinctrl: berlin: add the as370 SoC pinctrl driver
Date: Sat, 14 Jul 2018 02:17:28 +0800	[thread overview]
Message-ID: <201807140207.XSb6HG19%fengguang.wu@intel.com> (raw)
In-Reply-To: <20180713174726.44d1f7cc@xhacker.debian>

[-- Attachment #1: Type: text/plain, Size: 2395 bytes --]

Hi Jisheng,

I love your patch! Yet something to improve:

[auto build test ERROR on pinctrl/devel]
[also build test ERROR on v4.18-rc4 next-20180713]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Jisheng-Zhang/dt-binding-pinctrl-berlin-document-AS370-SoC-pinctrl/20180713-235943
base:   https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git devel
config: x86_64-allmodconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All error/warnings (new ones prefixed by >>):

   drivers/pinctrl/berlin/pinctrl-as370.c:330:1: sparse: 'MODULE_DEVICE_TABLE()' has implicit return type
>> drivers/pinctrl/berlin/pinctrl-as370.c:330:1: warning: data definition has no type or storage class
    MODULE_DEVICE_TABLE(of, as370_pinctrl_match);
    ^~~~~~~~~~~~~~~~~~~
>> drivers/pinctrl/berlin/pinctrl-as370.c:330:1: error: type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE' [-Werror=implicit-int]
>> drivers/pinctrl/berlin/pinctrl-as370.c:330:1: warning: parameter names (without types) in function declaration
   cc1: some warnings being treated as errors

sparse warnings: (new ones prefixed by >>)

>> drivers/pinctrl/berlin/pinctrl-as370.c:330:1: sparse: 'MODULE_DEVICE_TABLE()' has implicit return type
   drivers/pinctrl/berlin/pinctrl-as370.c:330:1: warning: data definition has no type or storage class
    MODULE_DEVICE_TABLE(of, as370_pinctrl_match);
    ^~~~~~~~~~~~~~~~~~~
   drivers/pinctrl/berlin/pinctrl-as370.c:330:1: error: type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE' [-Werror=implicit-int]
   drivers/pinctrl/berlin/pinctrl-as370.c:330:1: warning: parameter names (without types) in function declaration
   cc1: some warnings being treated as errors

vim +330 drivers/pinctrl/berlin/pinctrl-as370.c

   322	
   323	static const struct of_device_id as370_pinctrl_match[] = {
   324		{
   325			.compatible = "syna,as370-soc-pinctrl",
   326			.data = &as370_soc_pinctrl_data,
   327		},
   328		{}
   329	};
 > 330	MODULE_DEVICE_TABLE(of, as370_pinctrl_match);
   331	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 64672 bytes --]

      reply	other threads:[~2018-07-13 18:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-13  9:45 [PATCH 0/2] pinctrl: berlin: add as370 SoC support Jisheng Zhang
2018-07-13  9:46 ` [PATCH 1/2] dt-binding: pinctrl: berlin: document AS370 SoC pinctrl Jisheng Zhang
2018-07-13  9:47 ` [PATCH 2/2] pinctrl: berlin: add the as370 SoC pinctrl driver Jisheng Zhang
2018-07-13 18:17   ` kbuild test robot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201807140207.XSb6HG19%fengguang.wu@intel.com \
    --to=lkp@intel.com \
    --cc=Jisheng.Zhang@synaptics.com \
    --cc=devicetree@vger.kernel.org \
    --cc=kbuild-all@01.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=sebastian.hesselbarth@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.